Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Beg

Slow NPCChat execution on Looking glass

Recommended Posts

Hello.
I've recently noticed a very slow execution of all methods on NPCChat class, when running a script on looking glass.
I understand looking glass uses a lot more resources, but so much difference between execution times seems odd. This script requires so much npc talking that using looking glass makes it 33% less efficient. I've already fixed the problem by using my own NPCChat methods. Im just looking to know the reason why it is so much slower and if theres something to be done about it.
These are the time i've gathered:

With looking glass
[16:36:34] Executed NPCChat.getName() in 154 ms
[16:36:34] Executed NPCChat.getMessage() in 102 ms
[16:36:34] Executed NPCChat.getOptions() in 116 ms
[16:36:34] Executed NPCChat.getSelectOptionInterface() in 118 ms
[16:36:34] Executed NPCChat.getClickContinueInterface() in 103 ms
[16:36:34] Executed NPCChat.getSelectOptionInterfaces() in 125 ms
Without looking glass
[16:44:48] Executed NPCChat.getName() in 1 ms
[16:44:48] Executed NPCChat.getMessage() in 1 ms
[16:44:48] Executed NPCChat.getOptions() in 4 ms
[16:44:48] Executed NPCChat.getSelectOptionInterface() in 1 ms
[16:44:48] Executed NPCChat.getClickContinueInterface() in 1 ms
[16:44:48] Executed NPCChat.getSelectOptionInterfaces() in 1 ms

The script i've used to get this times:

public class Debug extends Script {

    @Override
    public void run() {
        debugNPCChatMethods();
    }

    private void debugNPCChatMethods() {
        long t1, t2;

        t1 = System.currentTimeMillis();
        NPCChat.getName();
        t2 = System.currentTimeMillis();
        System.out.println("Executed NPCChat.getName() in " + (t2-t1) + " ms");

        t1 = System.currentTimeMillis();
        NPCChat.getMessage();
        t2 = System.currentTimeMillis();
        System.out.println("Executed NPCChat.getMessage() in " + (t2-t1) + " ms");

        t1 = System.currentTimeMillis();
        NPCChat.getOptions();
        t2 = System.currentTimeMillis();
        System.out.println("Executed NPCChat.getOptions() in " + (t2-t1) + " ms");

        t1 = System.currentTimeMillis();
        NPCChat.getSelectOptionInterface();
        t2 = System.currentTimeMillis();
        System.out.println("Executed NPCChat.getSelectOptionInterface() in " + (t2-t1) + " ms");

        t1 = System.currentTimeMillis();
        NPCChat.getClickContinueInterface();
        t2 = System.currentTimeMillis();
        System.out.println("Executed NPCChat.getClickContinueInterface() in " + (t2-t1) + " ms");

        t1 = System.currentTimeMillis();
        NPCChat.getSelectOptionInterfaces();
        t2 = System.currentTimeMillis();
        System.out.println("Executed NPCChat.getSelectOptionInterfaces() in " + (t2-t1) + " ms");

    }
}


Using looking glass with OSBuddy.jar version 3.24.1.

java version "1.8.0_102"
Java(TM) SE Runtime Environment (build 1.8.0_102-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.102-b14, mixed mode)

Operating System: Ubuntu 18.04.2 LTS
Kernel: Linux 5.0.0-23-generic
Architecture: x86-64

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Our picks

    • This update features:

      Fixed broken hooks from today's update


      Fix wilderness level with RuneLite (Thanks @Todd)


      Add support for Kotlin .class files in scripts (Thanks @wastedbro)


      Overhaul Inventory API (Thanks @wastedbro)


      Add List support for common methods


      Change method grouping to make more sense (by functionality)


      Refactor methods to utilize Java 8 streams instead of cumbersome loops




      Recognize chatbox minimization (Thanks @JoeDezzy1)


      Fix Screen#isInViewport when NPC chat is open (Thanks @JoeDezzy1)


      Fix login bot bugs (Thanks @erickho123)


      Fix hint arrow return values (Thanks @Encoded)


      Fix depositAllExcept functionality (Thanks @wastedbro)


      Change containing box interface bound and adjust for Y values (Thanks @erickho123)
      • 151 replies
    • This release will:

      Fix prayers and world hopper API (Thanks @JoeDezzy1 and @erickho123)


      Improve banking API (Thanks @Encoded)


      Adds methods for returning and using Java Lists, rather than arrays


      Slightly randomizes some hardcoded behaviour


      Removes sleeps from waitConditions; the efficiency saving potential is negligible in these use-cases, therefore cleaner code is preferable


      Other back-end improvements





      Note: If you are using LG, please restart both the RS client and TRiBot.
      • 90 replies
    • This release will:

      Add new internal framework for capturing exceptions


      Fix issue with not selecting the last column in world hopper (Thanks @Todd)


      Add a message about pin usage in Banking#openBank (Thanks @Todd)


      Disable the firewall by default (Thanks @Todd)


      Fix handling of the welcome screen after login (Thanks @Encoded)


      Fix wrong amount bank withdrawal (Thanks @Encoded)


      Fix Screen#isInViewport


      Fix Game#isInViewport (Thanks @Encoded)


      Call onBreakEnd for ListenerManager Breaking Listeners (Thanks @Encoded)


      Fix Prayer#getPrayerPoints NumberFormatException (Thanks @JoeDezzy1)



      Note: If you are using LG, please restart both the RS client and TRiBot.
      • 28 replies
    • This release will:

      Fix LG for both OSBuddy and RuneLite


      Fix issue where the resizable client isn't able to be made smaller (Thanks @JoeDezzy1)


      Fix detection of the logout game tab when resizable mode and side panels are enabled (Thanks @JoeDezzy1)


      Add initial support for Sentry to allow us to identify and easily debug exceptions happening with all TRiBot users


      Add methods to determine if the bank is actually loaded, and not just the overarching interface (Thanks @wastedbro)



      Upcoming updates:

      Improved CLI support


      Full Sentry support


      Much more
      • 64 replies
    • This release will:

      Fix NPE in Camera API (Thanks @wastedbro)


      Update deposit box interface ids (Thanks @Encoded)


      Add various bank methods (Thanks @wastedbro)


      Banking#getWithdrawXQuantity


      Banking#getDefaultWithdrawQuantity


      Banking#arePlaceholdersOn




      Fix resizeable minimap bug (Thanks @wastedbro)


      Remove Java 8 requirement


      Please note: TRiBot is not yet fully compatible with Java 10+




      Fix the break handler issues by ensuring the break handler thread never gets paused


      Fix broken settings hooks



      Upcoming updates:

      Improved CLI support


      Much more



      Note: If you are using LG, please restart both the RS client and TRiBot
      • 68 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...