Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Sign in to follow this  
Plee

Clicking RSObject behind another RSObject

Recommended Posts

Posted (edited)

My script clicks a target, an RSObject, to attempt to mine it. Problem is sometimes another object gets in the way and then the script gets stuck clicking the object obstructing the view. I'm using the isClickable() and isOnScreen() method, both which returns true even if the obstruction is blocking my target. Is there a way to make sure i can have my camera move to see the target reliably or any other solution? 

Edited by Plee

Share this post


Link to post
Share on other sites
Posted (edited)

I check via uptext to ensure that it is the right one. I think with those methods, if u input a string, then it will ensure it clicks it via a right click if it has to.

 

Here's one of my "universal" clicking methods if you want something as reference. Not for your purpose I think what I said is fine, this is just for reference.

/**
     * A safe way to ensure that you click an object.
     *
     * When normally clicking, other {@code Positionables} may obstruct your path, making you click on them instead. If
     * such case occurs, it would simply do a right click and click the uptext option.
     *
     * @param desiredUptext The option that you want to select
     * @return true if successful click, false otherwise
     */
    private static boolean safeClick(String desiredUptext)
    {
        // fail safe for spam right click on option
        if (ChooseOption.isOpen())
        {
            ChooseOption.select("Cancel");
            System.out.println("safeClick: Option right click was open, cancelling options...");
            return false;
        }

        // Before clicking, ensure nothing is in the way
        if (!Game.isUptext(desiredUptext))
        {
            Mouse.click(3);

            if (Timing.waitChooseOption(desiredUptext, 500))
            {
                ChooseOption.select(desiredUptext); // cant return this for w.e reason always false?
                return true;
            }
            else
            {
                ChooseOption.select("Cancel");
                return false;
            }
        }
        else
        {
            Mouse.click(1);
            return true;
        }
    }

 

	/**
     * With supplied parameters, ensures that the entity will be clicked.
     *
     * Does all the null checking, camera movement, zoom out to ensure the above goal is met. If returns false, you
     * need to make the account walk to object and recall.
     *
     * @param clickableEntity   An entity that is clickable and has a position
     * @param uptext            String value representing the uptext when mouse hovers the npc
     * @param animation         Desired animation when interacting with object. -1 if no animation to occur.
     * @return                  True if click was successful, false otherwise.
     **/
    private static <T extends Clickable07 & Positionable> boolean clickEntity(T clickableEntity, String uptext, int animation)
    {
        if (!clickableEntity.isClickable() && !attemptAimCamera(clickableEntity))
        {
            System.out.println("clickEntity: Unable to click entity. It is too far away; resolve from caller.");
            return false;
        }

        clickableEntity.hover();
        Timing.waitUptext(uptext, General.random(650, 800));

        BooleanSupplier boolSupp = animation == -1 ? GBooleanSuppliers.waitToStopMoving() : GBooleanSuppliers.waitForAnimation(animation);

        // Split into two if statements for readability
        if (clickableEntity.getPosition().distanceTo(Player.getPosition()) <= 1)
        {
            if (!safeClick(uptext)  ||
                !Timing.waitCondition(GBooleanSuppliers.waitForAnimation(animation), General.random(1800, 1950)))
            {
                System.out.println("clickEntity: Failed to click entity (1)");
                return false;
            }
        }
        else if (!(safeClick(uptext)                                                                     &&
                   Timing.waitCondition(GBooleanSuppliers.waitToStartMoving(), General.random(625, 800)) &&
                   Timing.waitCondition(boolSupp, General.random(5200, 5400))))
        {
            System.out.println("clickEntity: Failed to click entity (2)");
            return false;
        }

        return true;
    }

    /**
     * WastedBro's implementation (with slight tweaks) that aims the camera at an entity.
     *
     * Attempts to do so 2-5 times. This is random to avoid patterns each attempt is different than the last.
     *
     * @param clickableEntity Any Type that implements the Clickable and Positionable interfaces (RSObject, RSNPC, etc)
     * @return Whether or not the target is in camera view
     */
    private static <T extends Clickable07 & Positionable> boolean attemptAimCamera(T clickableEntity)
    {
        if(clickableEntity == null)
            return false;

        int numberOfCameraAdjusts = 0;
        int maxCameraAdjusts = General.random(2, 5);

        while(!clickableEntity.isClickable() && numberOfCameraAdjusts <= maxCameraAdjusts)
        {
            if (numberOfCameraAdjusts == 0)
            {
                Camera.turnToTile(clickableEntity);
            }
            else if (numberOfCameraAdjusts == maxCameraAdjusts)
            {
                CameraZoom.zoomOut();
            }
            else
            {
                // If we fail to find by rotation, then lower the angle (to see further)
                int angle = Camera.getCameraAngle();
                Camera.setCameraAngle(angle - General.randomSD(5, angle, 30, 11));
            }

            numberOfCameraAdjusts++;
        }

        return clickableEntity.isClickable();
    }

 

Edited by TheGengar
  • Like 1

Share this post


Link to post
Share on other sites
Posted (edited)

You can take advantage of the method RSMenuNode.correlatesTo to accurately click options that correspond to RSObjects, RSNPCs, RSPlayers, and RSInterfaces. This would require you to create your own clicking method though. If you want to stick with tribots, use the full option of the target. Ex. "Trade playerName" instead of "Trade". This won't work for things with similar naming so if you're mining I'm pretty sure they're all called "Rocks" so it may not work.

Edit: Looks like there's a clicking method that accepts a Predicate<RSMenuNode> so you wouldn't need to create your own clicking method to use RSMenuNode.correlatesTo

Edited by Naton
  • Like 1

Share this post


Link to post
Share on other sites
10 hours ago, Plee said:

isOnScreen()

Do not use this method to check if you can click something, as it only tells you if the object's tile is on screen, which is not very helpful.

 

Your best bet would be doing what @Naton said and passing more arguments to the clicking method.

Here is an example where we want to try to chop down an oak without missclicking (in this example oak is a RSObject which implements Clickable) :

oak.click();

^ This will hover over the object's model and will click there, regardless if there is something blocking the view, which can result in the script clicking the wrong object.

 

oak.click("Chop-down");

^ This will hover over the model and will successfully select the "Chop-down" option. It's better than the first method call, but it can still click other trees (which also have the same option available).

 

oak.click("Chop-down Oak");

^ This guarantees the best accuracy, and the only way it's going to miss its mark is if there's another oak blocking the view to your target oak. But that shouldn't be a problem if your script is supposed to chop down oaks. :D

 

  • Like 1

Share this post


Link to post
Share on other sites
5 hours ago, Einstein said:

Do not use this method to check if you can click something, as it only tells you if the object's tile is on screen, which is not very helpful.

 

Your best bet would be doing what @Naton said and passing more arguments to the clicking method.

Here is an example where we want to try to chop down an oak without missclicking (in this example oak is a RSObject which implements Clickable) :

oak.click();

^ This will hover over the object's model and will click there, regardless if there is something blocking the view, which can result in the script clicking the wrong object.

 

oak.click("Chop-down");

^ This will hover over the model and will successfully select the "Chop-down" option. It's better than the first method call, but it can still click other trees (which also have the same option available).

 

oak.click("Chop-down Oak");

^ This guarantees the best accuracy, and the only way it's going to miss its mark is if there's another oak blocking the view to your target oak. But that shouldn't be a problem if your script is supposed to chop down oaks. :D

 

Thank you, I was using ore.click("Mine"); but i utilized your third suggestion and it fixed the problem. Thanks for the help

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this  

  • Our picks

    • [CONTEST ANNOUNCEMENT] 2019 Botter's Choice Awards
      2019 Botter’s Choice Awards

      To celebrate the launch of our TRiBot Official RuneScape Bot Blog,

      we’re doing a giveaway! 

      The TRiBot Official RuneScape Bot Blog: 

      Teaching you how to do more advanced botting, faster.
      Contest Details

      Prize: 3 winners will be selected to win 25 TRiBot credits.

      How to enter:

      Respond to this forum post by November 12th tagging the thread for: 

      Your favorite script

      Provide a brief explanation (1-2 sentences) why you think that script should be put in the top 5. 

      Who can enter?

      Botter’s who are not currently scripters. Sorry scripters, the people are going to vote. Your contest is here.

      The top 5 in each category will be showcased on our TRiBot Official RuneScape Bot Blog in a “People’s Choice” section and promoted across the TRiBot website. 

      -- Credits will be awarded based on thoughtfulness and humor -- 

      Bonus points

      Use a meme in your explanation. Because we all love memes.

      *no purchase necessary. Winners will be announced on Friday, November 15, 2019 at 4:00 p.m. on our News and Announcements forum. 

      -- Vote Below -- 
        • Like
      • 28 replies
    • [READ TO THE END FOR A TEASER]

      I've noticed some new TRiBotters have had some troubles finding out sources of how to do certain things, such as using advanced scripts and often get lost in the forums.

      We are still getting posts asking where to start, what to do, recommended scripts, etc. 

      As many of you know, I am new to the team, and had troubles myself learning how to bot, let alone script. 

      So, what our team decided to do was make it easier to learn how to bot, how to script, and just become an overall better botter and scripter faster. 

      As some of you might have seen, I've posted 3 new blogs, you can check it out by clicking on the following picture or here.


      These first 3 blogs are the first of many blogs that will be TRiBot official. They are encouraged to be challenged, improved upon and act as A Best Practices Guide for Botters.

      What information would you like to see in the blogs?

      👇 [TEASER] 👇

      .

      .

      .

      We are going to be hosting a  CONTEST  this  OCTOBER.

      Its scary to think how soon you'll find out.👻

      Stay tuned.


      - RileyZ
      • 8 replies
    • Today marks a big day for TRiBot! To make it easier for users to use TRiBot, we've created installers available for every platform! These installers are all bundled with the latest version of OpenJDK 1.8 (Java 😎, which is LG compatible.

      Using TRiBot is now easy. Simply download the installer for your platform, install TRiBot, and run it. The TRiBot Loader will correctly identify the bundled JDK so there's no need to change the Java selection.

      Windows

      EXE installer: TRiBot-windows-x64-4.0.3.exe


      MSI installer: TRiBot-windows-x64-4.0.3.msi


      Portable version: TRiBot-windows-x64-4.0.3.zip


      Mac OS

      Installer: TRiBot-macos-4.0.3.dmg


      Portable version: TRiBot-macos-4.0.3.tgz


      Unix/Linux

      Installer: TRiBot-unix-4.0.3.sh


      RPM installer (CentOS/Fedora): TRiBot-linux-4.0.3.rpm


      DEB installer (Debian): TRiBot-linux-4.0.3.deb


      Portable version: TRiBot-unix-4.0.3.tar.gz


      Platform Independent

      JAR file: tribot-loader-4.0.3.jar


      Note that this jar file does not include the bundled JDK.



      Windows and Mac OS users may notice a warning message stating that the installer/application is un-recognized or un-trusted. Please ignore this message and proceed with running the installer/application. We need to acquire a code signing certificate so that we can sign the installers letting the operating system know that these files can be trusted. It will take a week or more to acquire one, so please hold tight.

      Other notable changes to the TRiBot Loader:

      Support getting the version from OpenJDK distributions


      Add check for bundled JDK


      Copy OpenJDK tools.jar to the bundled JDK if not present


      Set the current java as the first available list entry


      Ignore Java versions which are symbolic links


      Make the bundled JDK the preferred Java version


      Update icon images


      Reduce the number of HTTP calls
        • Thanks
        • Like
      • 24 replies
    • TRiBot is looking to improve a lot of its customer relationship management, customer on boarding process, customer experience, design elements, community engagement and pretty much everything else you can imagine when it comes to marketing.

      Our goal: To ensure that the marketing done TRULY reflects the experience and does not shine an inaccurate light on what TRiBot is lacking in.

      So I ask, what do you love about TRiBot and what do you hate about TRiBot? What does O S Bot, Rune M8, PowR Bot and Dre amBot do better? (yes I purposely didn't spell it right 😂).

      Love, 

      RileyZ
        • Like
      • 18 replies
    • Hello TRiBot,

      Today we have a significant release that has been in the works for the last month addressing several key issues, features and bugs in the backlog.

      With these changes, we are also including a new TRiBot Loader which will allow you to select any version that is released. This adds the flexibility of allowing you to revert to a previous version should an issue arise, run development only builds, view an accurate change log between versions etc. we are very proud to offer this feature and think it will add a lot more functionality down the road as we continue to release new versions.

      These changes include 80+ commits by our development team, a list of them is summarized below and also available for your viewing pleasure in the new TRiBot Loader.

      In addition, we have taken additional steps to improve as a development team by adding continuous integration and deployment into our workflow to assist in delivering timely releases such as bug fixes as well as new features on a weekly basis depending on our development cycle.
        • Thanks
        • Like
      • 39 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...