Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Sign in to follow this  
IceKontroI

Compelling reasons to not use TRiBot Keyboard class

Recommended Posts

Posted (edited)

I'm currently developing an advanced framework to improve on the faults of TRiBot's Keyboard class. If the community and admins assist me in this process I will release the entire source code.

To see for yourself, you can use a test script I wrote that observes OSRS client KeyEvents directly: https://pastebin.com/raw/dL0MtDRf. Unless you type with a single finger, you will very likely see how alarming the difference is.

Here are some major issues:

  • Typing is not asynchronous. To type the string "ab", the "b" can only be typed after the "a" key has been released. Humans type so that just the presses are synchronized, the releases happen independently.
    • If keys are ALWAYS pressed linearly (and they are), it's easy to see from a KeyEvent log that the player is a bot.
  • Calling Keyboard.sendPress(capitalKeyChar, correspondingKeyCode) will insert a "shift" press event.
    • This is not mentioned in the javadoc.
    • This should be decoupled because it's unintuitive.
    • This directly prevents any scripter from having full control over the base functions typing is comprised of.
      • This is the primary reason I can't write the framework I plan to (and it's almost entirely done).
  • Some events fire incorrectly
    • Typing a single quote (') not only inserts a shift before, but also uses the keyCode for right arrow key (39) instead of the correct one (222).
      • This causes the corresponding events to not properly mimic human behavior:
      • [21:56:57] TRIBOT KEYBOARD
        [21:56:59] Pressed Shift, code: 16
        [21:56:59] Pressed Right, code: 39
        [21:56:59] Released Right, code: 39
        [21:56:59] Released Shift, code: 16
        [21:56:59] ACTUAL HUMAN KEYBOARD
        [21:57:03] Pressed Quote, code: 222
        [21:57:03] Released Quote, code: 222
      • Not only is the wrong keycode being shown, but also what you can't see is that the press and release KeyEvents have shift modifiers, which would be impossible for a single quote char on most keyboards.

I'm sure there are more issues, the Keyboard class seems to have been left unchanged for quite some time. As I've mentioned, I'm almost finished with the framework I'm designing. I just need the decoupling mentioned in bullet point 2 to be taken care of and I'll release it publicly, free, and open source.

@TRiLeZ, @Todd@JoeDezzy1, @erickho123, @Encoded, @wastedbro.

Edited by IceKontroI
  • Like 6
  • Thanks 1

Share this post


Link to post
Share on other sites

Even if we don't know if JaGeX monitors KeyEvents, should this not be alarming? This sounds like an easy detection, and just another flag to check for before making the final decision on if an account is botting.  

 

Does the login script use this? 

Share this post


Link to post
Share on other sites
On 7/13/2019 at 11:08 PM, IceKontroI said:

I'm currently developing an advanced framework to improve on the faults of TRiBot's Keyboard class. If the community and admins assist me in this process I will release the entire source code.

To see for yourself, you can use a test script I wrote that observes OSRS client KeyEvents directly: https://pastebin.com/raw/dL0MtDRf. Unless you type with a single finger, you will very likely see how alarming the difference is.

Here are some major issues:

  • Typing is not asynchronous. To type the string "ab", the "b" can only be typed after the "a" key has been released. Humans type so that just the presses are synchronized, the releases happen independently.
    • If keys are ALWAYS pressed linearly (and they are), it's easy to see from a KeyEvent log that the player is a bot.
  • Calling Keyboard.sendPress(capitalKeyChar, correspondingKeyCode) will insert a "shift" press event.
    • This is not mentioned in the javadoc.
    • This should be decoupled because it's unintuitive.
    • This directly prevents any scripter from having full control over the base functions typing is comprised of.
      • This is the primary reason I can't write the framework I plan to (and it's almost entirely done).
  • Some events fire incorrectly
    • Typing a single quote (') not only inserts a shift before, but also uses the keyCode for right arrow key (39) instead of the correct one (222).
      • This causes the corresponding events to not properly mimic human behavior:
      • [21:56:57] TRIBOT KEYBOARD
        [21:56:59] Pressed Shift, code: 16
        [21:56:59] Pressed Right, code: 39
        [21:56:59] Released Right, code: 39
        [21:56:59] Released Shift, code: 16
        [21:56:59] ACTUAL HUMAN KEYBOARD
        [21:57:03] Pressed Quote, code: 222
        [21:57:03] Released Quote, code: 222
      • Not only is the wrong keycode being shown, but also what you can't see is that the press and release KeyEvents have shift modifiers, which would be impossible for a single quote char on most keyboards.

I'm sure there are more issues, the Keyboard class seems to have been left unchanged for quite some time. As I've mentioned, I'm almost finished with the framework I'm designing. I just need the decoupling mentioned in bullet point 2 to be taken care of and I'll release it publicly, free, and open source.

@TRiLeZ, @Todd@JoeDezzy1, @erickho123, @Encoded, @wastedbro.

This sounds very interesting, did you complete your framework?

Share this post


Link to post
Share on other sites
2 hours ago, IceKontroI said:

It's in development, working prototype is almost complete. I'll need to do significant testing before I can release this publicly, however, to ensure safety.

Thats awesome dude, glad to hear youre still working on it. Are you still planning on releasing it open source?

Share this post


Link to post
Share on other sites
2 hours ago, NeuroGenix said:

Thats awesome dude, glad to hear youre still working on it. Are you still planning on releasing it open source?

It's integrated into other systems I designed, but If there's demand for it I can isolate it and publish a standalone version open source for all to see and use. I do need to be 100% confident it won't cause bans though, so validating may take a good long while.

Share this post


Link to post
Share on other sites
7 hours ago, IceKontroI said:

It's integrated into other systems I designed, but If there's demand for it I can isolate it and publish a standalone version open source for all to see and use. I do need to be 100% confident it won't cause bans though, so validating may take a good long while.

Id be interested in trying it out, Im currently working on a f2p progressive, multi-method, script that will use the keyboard class a lot for buying and selling on the GE and when pressing the space bar to get through dialogue boxes. I'd be happy to help with the testing, and I dont expect my f2p accounts to survive longer than 24 hours so they'll be a good source of data in terms of validating you method because I could have one batch using it and another not which could result in any differences in ban rate becoming apparent quite quickly.

Share this post


Link to post
Share on other sites
Posted (edited)
3 hours ago, NeuroGenix said:

Id be interested in trying it out, Im currently working on a f2p progressive, multi-method, script that will use the keyboard class a lot for buying and selling on the GE and when pressing the space bar to get through dialogue boxes. I'd be happy to help with the testing, and I dont expect my f2p accounts to survive longer than 24 hours so they'll be a good source of data in terms of validating you method because I could have one batch using it and another not which could result in any differences in ban rate becoming apparent quite quickly.

EDIT: Might be a small issue, if you're using tabs to run your farm the key press events will likely be messed up. I've not yet been able to find a workaround for this issue yet. There are tons of small bugs like this I need to fix, will be in contact when I do.

Edited by IceKontroI

Share this post


Link to post
Share on other sites

It would be appreciated if you could type up a bug report on the gitlab for the incorrect key events that you've found so that the tribot keyboard class could be fixed (the devs could also possibly come up with a solution to #2 in your post)

Share this post


Link to post
Share on other sites
On 10/9/2019 at 3:16 PM, IceKontroI said:

EDIT: Might be a small issue, if you're using tabs to run your farm the key press events will likely be messed up. I've not yet been able to find a workaround for this issue yet. There are tons of small bugs like this I need to fix, will be in contact when I do.

Ok thats great mate, thank you :)

On 10/9/2019 at 4:24 PM, Naton said:

It would be appreciated if you could type up a bug report on the gitlab for the incorrect key events that you've found so that the tribot keyboard class could be fixed (the devs could also possibly come up with a solution to #2 in your post)

Sounds like a good idea to me.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this  

  • Our picks

    • [CONTEST ANNOUNCEMENT] 2019 Botter's Choice Awards
      2019 Botter’s Choice Awards

      To celebrate the launch of our TRiBot Official RuneScape Bot Blog,

      we’re doing a giveaway! 

      The TRiBot Official RuneScape Bot Blog: 

      Teaching you how to do more advanced botting, faster.
      Contest Details

      Prize: 3 winners will be selected to win 25 TRiBot credits.

      How to enter:

      Respond to this forum post by November 12th tagging the thread for: 

      Your favorite script

      Provide a brief explanation (1-2 sentences) why you think that script should be put in the top 5. 

      Who can enter?

      Botter’s who are not currently scripters. Sorry scripters, the people are going to vote. Your contest is here.

      The top 5 in each category will be showcased on our TRiBot Official RuneScape Bot Blog in a “People’s Choice” section and promoted across the TRiBot website. 

      -- Credits will be awarded based on thoughtfulness and humor -- 

      Bonus points

      Use a meme in your explanation. Because we all love memes.

      *no purchase necessary. Winners will be announced on Friday, November 15, 2019 at 4:00 p.m. on our News and Announcements forum. 

      -- Vote Below -- 
        • Like
      • 28 replies
    • [READ TO THE END FOR A TEASER]

      I've noticed some new TRiBotters have had some troubles finding out sources of how to do certain things, such as using advanced scripts and often get lost in the forums.

      We are still getting posts asking where to start, what to do, recommended scripts, etc. 

      As many of you know, I am new to the team, and had troubles myself learning how to bot, let alone script. 

      So, what our team decided to do was make it easier to learn how to bot, how to script, and just become an overall better botter and scripter faster. 

      As some of you might have seen, I've posted 3 new blogs, you can check it out by clicking on the following picture or here.


      These first 3 blogs are the first of many blogs that will be TRiBot official. They are encouraged to be challenged, improved upon and act as A Best Practices Guide for Botters.

      What information would you like to see in the blogs?

      👇 [TEASER] 👇

      .

      .

      .

      We are going to be hosting a  CONTEST  this  OCTOBER.

      Its scary to think how soon you'll find out.👻

      Stay tuned.


      - RileyZ
      • 8 replies
    • Today marks a big day for TRiBot! To make it easier for users to use TRiBot, we've created installers available for every platform! These installers are all bundled with the latest version of OpenJDK 1.8 (Java 😎, which is LG compatible.

      Using TRiBot is now easy. Simply download the installer for your platform, install TRiBot, and run it. The TRiBot Loader will correctly identify the bundled JDK so there's no need to change the Java selection.

      Windows

      EXE installer: TRiBot-windows-x64-4.0.3.exe


      MSI installer: TRiBot-windows-x64-4.0.3.msi


      Portable version: TRiBot-windows-x64-4.0.3.zip


      Mac OS

      Installer: TRiBot-macos-4.0.3.dmg


      Portable version: TRiBot-macos-4.0.3.tgz


      Unix/Linux

      Installer: TRiBot-unix-4.0.3.sh


      RPM installer (CentOS/Fedora): TRiBot-linux-4.0.3.rpm


      DEB installer (Debian): TRiBot-linux-4.0.3.deb


      Portable version: TRiBot-unix-4.0.3.tar.gz


      Platform Independent

      JAR file: tribot-loader-4.0.3.jar


      Note that this jar file does not include the bundled JDK.



      Windows and Mac OS users may notice a warning message stating that the installer/application is un-recognized or un-trusted. Please ignore this message and proceed with running the installer/application. We need to acquire a code signing certificate so that we can sign the installers letting the operating system know that these files can be trusted. It will take a week or more to acquire one, so please hold tight.

      Other notable changes to the TRiBot Loader:

      Support getting the version from OpenJDK distributions


      Add check for bundled JDK


      Copy OpenJDK tools.jar to the bundled JDK if not present


      Set the current java as the first available list entry


      Ignore Java versions which are symbolic links


      Make the bundled JDK the preferred Java version


      Update icon images


      Reduce the number of HTTP calls
        • Thanks
        • Like
      • 24 replies
    • TRiBot is looking to improve a lot of its customer relationship management, customer on boarding process, customer experience, design elements, community engagement and pretty much everything else you can imagine when it comes to marketing.

      Our goal: To ensure that the marketing done TRULY reflects the experience and does not shine an inaccurate light on what TRiBot is lacking in.

      So I ask, what do you love about TRiBot and what do you hate about TRiBot? What does O S Bot, Rune M8, PowR Bot and Dre amBot do better? (yes I purposely didn't spell it right 😂).

      Love, 

      RileyZ
        • Like
      • 18 replies
    • Hello TRiBot,

      Today we have a significant release that has been in the works for the last month addressing several key issues, features and bugs in the backlog.

      With these changes, we are also including a new TRiBot Loader which will allow you to select any version that is released. This adds the flexibility of allowing you to revert to a previous version should an issue arise, run development only builds, view an accurate change log between versions etc. we are very proud to offer this feature and think it will add a lot more functionality down the road as we continue to release new versions.

      These changes include 80+ commits by our development team, a list of them is summarized below and also available for your viewing pleasure in the new TRiBot Loader.

      In addition, we have taken additional steps to improve as a development team by adding continuous integration and deployment into our workflow to assist in delivering timely releases such as bug fixes as well as new features on a weekly basis depending on our development cycle.
        • Thanks
        • Like
      • 39 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...