Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Sign in to follow this  
IceKontroI

Compelling reasons to not use TRiBot Keyboard class

Recommended Posts

Posted (edited)

I'm currently developing an advanced framework to improve on the faults of TRiBot's Keyboard class. If the community and admins assist me in this process I will release the entire source code.

To see for yourself, you can use a test script I wrote that observes OSRS client KeyEvents directly: https://pastebin.com/raw/dL0MtDRf. Unless you type with a single finger, you will very likely see how alarming the difference is.

Here are some major issues:

  • Typing is not asynchronous. To type the string "ab", the "b" can only be typed after the "a" key has been released. Humans type so that just the presses are synchronized, the releases happen independently.
    • If keys are ALWAYS pressed linearly (and they are), it's easy to see from a KeyEvent log that the player is a bot.
  • Calling Keyboard.sendPress(capitalKeyChar, correspondingKeyCode) will insert a "shift" press event.
    • This is not mentioned in the javadoc.
    • This should be decoupled because it's unintuitive.
    • This directly prevents any scripter from having full control over the base functions typing is comprised of.
      • This is the primary reason I can't write the framework I plan to (and it's almost entirely done).
  • Some events fire incorrectly
    • Typing a single quote (') not only inserts a shift before, but also uses the keyCode for right arrow key (39) instead of the correct one (222).
      • This causes the corresponding events to not properly mimic human behavior:
      • [21:56:57] TRIBOT KEYBOARD
        [21:56:59] Pressed Shift, code: 16
        [21:56:59] Pressed Right, code: 39
        [21:56:59] Released Right, code: 39
        [21:56:59] Released Shift, code: 16
        [21:56:59] ACTUAL HUMAN KEYBOARD
        [21:57:03] Pressed Quote, code: 222
        [21:57:03] Released Quote, code: 222
      • Not only is the wrong keycode being shown, but also what you can't see is that the press and release KeyEvents have shift modifiers, which would be impossible for a single quote char on most keyboards.

I'm sure there are more issues, the Keyboard class seems to have been left unchanged for quite some time. As I've mentioned, I'm almost finished with the framework I'm designing. I just need the decoupling mentioned in bullet point 2 to be taken care of and I'll release it publicly, free, and open source.

@TRiLeZ, @Todd@JoeDezzy1, @erickho123, @Encoded, @wastedbro.

Edited by IceKontroI
  • Like 5
  • Thanks 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this  

  • Our picks

    • This update features:

      Fixed broken hooks from today's update


      Fix wilderness level with RuneLite (Thanks @Todd)


      Add support for Kotlin .class files in scripts (Thanks @wastedbro)


      Overhaul Inventory API (Thanks @wastedbro)


      Add List support for common methods


      Change method grouping to make more sense (by functionality)


      Refactor methods to utilize Java 8 streams instead of cumbersome loops




      Recognize chatbox minimization (Thanks @JoeDezzy1)


      Fix Screen#isInViewport when NPC chat is open (Thanks @JoeDezzy1)


      Fix login bot bugs (Thanks @erickho123)


      Fix hint arrow return values (Thanks @Encoded)


      Fix depositAllExcept functionality (Thanks @wastedbro)


      Change containing box interface bound and adjust for Y values (Thanks @erickho123)
        • Like
      • 151 replies
    • This release will:

      Fix prayers and world hopper API (Thanks @JoeDezzy1 and @erickho123)


      Improve banking API (Thanks @Encoded)


      Adds methods for returning and using Java Lists, rather than arrays


      Slightly randomizes some hardcoded behaviour


      Removes sleeps from waitConditions; the efficiency saving potential is negligible in these use-cases, therefore cleaner code is preferable


      Other back-end improvements





      Note: If you are using LG, please restart both the RS client and TRiBot.
        • Sad
        • Haha
        • Thanks
        • Like
      • 90 replies
    • This release will:

      Add new internal framework for capturing exceptions


      Fix issue with not selecting the last column in world hopper (Thanks @Todd)


      Add a message about pin usage in Banking#openBank (Thanks @Todd)


      Disable the firewall by default (Thanks @Todd)


      Fix handling of the welcome screen after login (Thanks @Encoded)


      Fix wrong amount bank withdrawal (Thanks @Encoded)


      Fix Screen#isInViewport


      Fix Game#isInViewport (Thanks @Encoded)


      Call onBreakEnd for ListenerManager Breaking Listeners (Thanks @Encoded)


      Fix Prayer#getPrayerPoints NumberFormatException (Thanks @JoeDezzy1)



      Note: If you are using LG, please restart both the RS client and TRiBot.
        • Thanks
        • Like
      • 28 replies
    • This release will:

      Fix LG for both OSBuddy and RuneLite


      Fix issue where the resizable client isn't able to be made smaller (Thanks @JoeDezzy1)


      Fix detection of the logout game tab when resizable mode and side panels are enabled (Thanks @JoeDezzy1)


      Add initial support for Sentry to allow us to identify and easily debug exceptions happening with all TRiBot users


      Add methods to determine if the bank is actually loaded, and not just the overarching interface (Thanks @wastedbro)



      Upcoming updates:

      Improved CLI support


      Full Sentry support


      Much more
        • Like
      • 64 replies
    • This release will:

      Fix NPE in Camera API (Thanks @wastedbro)


      Update deposit box interface ids (Thanks @Encoded)


      Add various bank methods (Thanks @wastedbro)


      Banking#getWithdrawXQuantity


      Banking#getDefaultWithdrawQuantity


      Banking#arePlaceholdersOn




      Fix resizeable minimap bug (Thanks @wastedbro)


      Remove Java 8 requirement


      Please note: TRiBot is not yet fully compatible with Java 10+




      Fix the break handler issues by ensuring the break handler thread never gets paused


      Fix broken settings hooks



      Upcoming updates:

      Improved CLI support


      Much more



      Note: If you are using LG, please restart both the RS client and TRiBot
        • Like
      • 68 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...