Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Sign in to follow this  
TheGengar

Using child/component values in script where entity selector is unable to filter them out?

Recommended Posts

To determine the letter of the fairy ring combination, and set it, I use the rotationZ of a interface child within the entire combination interface. The issue I'm facing is that I hard coded the indexes and I've read that it is bad practice. I'm unable to filter out the index I want using Laniax's entity selector since the child index has no text/actions and no unique textid or colour. I was wondering how I could overcome this? Is there another viable method aside from hardcoding child values?

Below is the code. It works perfectly. Would love any input regarding refactoring or better coding etiquette. :D

Thanks.

public class FairyRingHandler
{
    private static final int TELEPORT_ANIMATION = 3265;

    // Interfaces
    private static final int master = 398;
    private static final int childRotationOne = 3;
    private static final int childRotationTwo = 4;
    private static final int childRotationThree = 5;
    private static final int leftChildClockwise = 19;
    private static final int midChildClockwise = 21;
    private static final int rightChildClockwise = 23;

    // Rotation values
    private static final int restingRotation = 0;
    private static final int firstRotation = 1536;
    private static final int secondRotation = 1024;
    private static final int thirdRotation = 512;

    // Arrays
    private static final int[] rotations = {restingRotation, firstRotation, secondRotation, thirdRotation};
    private static final char[] validLeftChars = {'A', 'D', 'C', 'B'};
    private static final char[] validMidChars = {'I', 'L', 'K', 'J'};
    private static final char[] validRightChars = {'P', 'S', 'R', 'Q'};

    public static boolean setFairyRingCombination(String combination)
    {
        if (combination.length() != 3)
        {
            System.out.println("SetFairyRingCombination: Invalid combination length");
            return false;
        }

        // Rule out invalid character
        combination.toUpperCase();

        char letter1 = combination.charAt(0);
        char letter2 = combination.charAt(1);
        char letter3 = combination.charAt(2);

        if (!areValidCharacters(letter1, letter2, letter3))
        {
            System.out.println("setFairyRingCombination: Invalid characters entered.");
            return false;
        }

        // Open interface if it is not open
        if (!Interfaces.isInterfaceValid(master))
        {
            RSObject fairyRing = Entities.find(ObjectEntity::new).nameEquals("Fairy ring").getFirstResult();

            if (fairyRing == null)
            {
                System.out.println("setFairyRingCombination: No fairy rings are present.");
                return false;
            }

            String previousCombination = getFairyRingCombination();
            String action = "Last-destination (" + previousCombination + ")";

            // Tele to last destination
            if (previousCombination.equals(combination))
            {
                if (AccurateMouse.click(fairyRing, action))
                {
                    waitToFInishTeleporting();
                    return true;
                }

                System.out.println("setFairyRingCombination: Failed to open fairy ring interface.");
                return false;
            }

            // Open the interface
            if (!AccurateMouse.click(fairyRing, "Configure") || 
                !Timing.waitCondition(GBooleanSuppliers.isInterfaceValid(master), General.random(4800, 5340)))
            {
                System.out.println("setFairyRingCombination: Failed to open fairy ring interface.");
                return false;
            }
        }

        setCombinationLetter(letter1, leftChildClockwise);
        setCombinationLetter(letter2, midChildClockwise);
        setCombinationLetter(letter3, rightChildClockwise);

        if (!getFairyRingCombination().equals(combination))
        {
            System.out.println("setFairyRingCombination: Failed to set fairy ring combination, resetting");
            setFairyRingCombination(combination);
        }

        RSInterface confirm = Entities.find(InterfaceEntity::new).actionEquals("Confirm").getFirstResult();

        if (confirm == null)
        {
            System.out.println("setFairyRingCombination: Unable to find the confirm button, closing interface");

            RSInterface close = Entities.find(InterfaceEntity::new).actionEquals("Close").getFirstResult();

            if (close == null)
            {
                System.out.println("setFairyRingCombination: Unable to find close button?");
                return false;
            }

            close.click();
            return false;
        }

        confirm.click();

        if (!waitToFInishTeleporting())
        {
            System.out.println("setFairyRingCombination: Failed to teleport?");
            return false;
        }

        return true;
    }

    private static boolean waitToFInishTeleporting()
    {
        return  Timing.waitCondition(GBooleanSuppliers.waitForAnimation(TELEPORT_ANIMATION), General.random(1850, 2000)) &&
                Timing.waitCondition(GBooleanSuppliers.waitForAnimation(-1), General.random(3150, 3400));
    }

    private static boolean areValidCharacters(char one, char two, char three)
    {
        return isValidChar(one, validLeftChars) && isValidChar(two, validMidChars) && isValidChar(three, validRightChars);
    }

    private static boolean isValidChar(char givenChar, char[] validChars)
    {
        for (char character : validChars)
        {
            if (givenChar == character)
            {
                return true;
            }
        }

        return false;
    }

    private static void setCombinationLetter(char letter, int clockwiseIndex)
    {
        if (!Interfaces.isInterfaceValid(master))
        {
            System.out.println("setCombinationLetter: Fairy ring interface is not open.");
            return;
        }

        // case variables
        char[] characterCombination;
        int rotationChild;

        switch (clockwiseIndex)
        {
            case 19:
                characterCombination = validLeftChars;
                rotationChild = childRotationOne;
                break;
            case 21:
                characterCombination = validMidChars;
                rotationChild = childRotationTwo;
                break;
            case 23:
                characterCombination = validRightChars;
                rotationChild = childRotationThree;
                break;
            default:
                System.out.println("setCombinationLetter: Invalid lettrs, returning.");
                return;
        }

        // Find letter placement in the array.
        int currentRotation = Interfaces.get(master, rotationChild).getRotationZ();
        int desiredRotationIndex = getDesiredRotationIndex(characterCombination, letter);
        int currentRotationIndex = getCurrentRotationIndex(currentRotation);

        // Compare the two indexes and determine if you need to rotate clock, counter or nothing.
        int numberOfRotations;
        RSInterface rotationInterface;

        // TODO make it so if 3 rots required, do the other way (i.e. from clock to counter)
        if (currentRotationIndex < desiredRotationIndex)
        {
            // rotate clockwise the difference
            numberOfRotations = desiredRotationIndex - currentRotationIndex;
            rotationInterface = Interfaces.get(master, clockwiseIndex);
        }
        else
        {
            numberOfRotations = currentRotationIndex - desiredRotationIndex;
            rotationInterface = Interfaces.get(master, clockwiseIndex + 1);
        }

        // Rotate
        for (int i = 0; i < numberOfRotations; i++)
        {
            // CLick specified index
            rotationInterface.click();

            Timing.waitCondition(()->
            {
                General.sleep(125);
                return isRotationValueValid(rotationChild);
            }, General.random(1450, 1600));
        }
    }

    private static boolean isRotationValueValid(int rotationChild)
    {
        RSInterface rotationInterface = Interfaces.get(master, rotationChild);

        for (Integer rotation : rotations)
        {
            if (rotation == rotationInterface.getRotationZ())
            {
                return true;
            }
        }

        return false;
    }

    private static int getDesiredRotationIndex(char[] characterCombination, char letter)
    {
        int counter = 0;

        for (char character : characterCombination)
        {
            if (character == letter)
            {
                return counter;
            }

            counter++;
        }

        System.out.println("getDesiredRotationIndex: Error, unable to find character in given array");
        return -1;
    }

    private static int getCurrentRotationIndex(int currentRotation)
    {
        int counter = 0;

        for (int rotation : rotations)
        {
            if (rotation == currentRotation)
            {
                return counter;
            }

            counter++;
        }

        System.out.println("getCurrentRotationIndex: Error, unable to find rotation in given array");
        return -1;
    }

    /**
     * Returns a three-letter string whcih represents the fairy code combination. Please note that this should only be
     * called when the interface is not rotating (i.e. is at rest).
     *
     * @return combination
     */
    public static String getFairyRingCombination()
    {
        // Get rotation indexes and get the corresponding letters
        if (Interfaces.isInterfaceValid(master))
        {
            RSInterface masterInterface = Interfaces.get(master);

            int rotationIndexOne = getCurrentRotationIndex(masterInterface.getChild(childRotationOne).getRotationZ());
            int rotationIndexTwo = getCurrentRotationIndex(masterInterface.getChild(childRotationTwo).getRotationZ());
            int rotationIndexThree = getCurrentRotationIndex(masterInterface.getChild(childRotationThree).getRotationZ());

            if (rotationIndexOne == -1 || rotationIndexTwo == -1 || rotationIndexThree == -1)
            {
                System.out.println("getFairyRingCombination: The fairy ring is rotating thus unable to determine combination.");
                System.out.println("getFairyRingCombination: Please wait for it to stop rotating.");
                return "";
            }

            char charOne = validLeftChars[rotationIndexOne];
            char charTwo = validMidChars[rotationIndexTwo];
            char charThree = validRightChars[rotationIndexThree];

            return new String(new char[]{charOne, charTwo, charThree});
        }
        else
        {
            RSObject fairyRing = Entities.find(ObjectEntity::new).nameEquals("Fairy ring").getFirstResult();

            if (fairyRing == null)
            {
                System.out.println("getFairyRingCombination: No fairy rings are present.");
                return "";
            }

            String[] actions = fairyRing.getDefinition().getActions();
            String action = null;

            for (String s : actions)
            {
                if (s.startsWith("Last"))
                {
                    action = s;
                }
            }

            if (action == null)
            {
                System.out.println("getFairyRingCombination: Action is null some how ?.");
                return "";
            }

            return action.split("[()]")[1];
        }
    }
}

 

Share this post


Link to post
Share on other sites

It's only bad practice in the sense that interface IDs are subject to change. If you don't mind updating them if/when they do get changed, it's not really the end of the world.

Some things you could try though:

-Use the 'travel log' interface. It shows places you've recently gone to and you could probably grab info from there. I think you can also set favorites and have it activate the desired teleport location from there?

-Use DTMs/color to determine if the correct letter is selected in each spot

-Find some other identifying aspect of the interface other than text to identify each unique letter

  • Like 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this  

  • Our picks

    • [CONTEST ANNOUNCEMENT] 2019 Botter's Choice Awards
      2019 Botter’s Choice Awards

      To celebrate the launch of our TRiBot Official RuneScape Bot Blog,

      we’re doing a giveaway! 

      The TRiBot Official RuneScape Bot Blog: 

      Teaching you how to do more advanced botting, faster.
      Contest Details

      Prize: 3 winners will be selected to win 25 TRiBot credits.

      How to enter:

      Respond to this forum post by November 12th tagging the thread for: 

      Your favorite script

      Provide a brief explanation (1-2 sentences) why you think that script should be put in the top 5. 

      Who can enter?

      Botter’s who are not currently scripters. Sorry scripters, the people are going to vote. Your contest is here.

      The top 5 in each category will be showcased on our TRiBot Official RuneScape Bot Blog in a “People’s Choice” section and promoted across the TRiBot website. 

      -- Credits will be awarded based on thoughtfulness and humor -- 

      Bonus points

      Use a meme in your explanation. Because we all love memes.

      *no purchase necessary. Winners will be announced on Friday, November 15, 2019 at 4:00 p.m. on our News and Announcements forum. 

      -- Vote Below -- 
        • Like
      • 28 replies
    • [READ TO THE END FOR A TEASER]

      I've noticed some new TRiBotters have had some troubles finding out sources of how to do certain things, such as using advanced scripts and often get lost in the forums.

      We are still getting posts asking where to start, what to do, recommended scripts, etc. 

      As many of you know, I am new to the team, and had troubles myself learning how to bot, let alone script. 

      So, what our team decided to do was make it easier to learn how to bot, how to script, and just become an overall better botter and scripter faster. 

      As some of you might have seen, I've posted 3 new blogs, you can check it out by clicking on the following picture or here.


      These first 3 blogs are the first of many blogs that will be TRiBot official. They are encouraged to be challenged, improved upon and act as A Best Practices Guide for Botters.

      What information would you like to see in the blogs?

      👇 [TEASER] 👇

      .

      .

      .

      We are going to be hosting a  CONTEST  this  OCTOBER.

      Its scary to think how soon you'll find out.👻

      Stay tuned.


      - RileyZ
      • 8 replies
    • Today marks a big day for TRiBot! To make it easier for users to use TRiBot, we've created installers available for every platform! These installers are all bundled with the latest version of OpenJDK 1.8 (Java 😎, which is LG compatible.

      Using TRiBot is now easy. Simply download the installer for your platform, install TRiBot, and run it. The TRiBot Loader will correctly identify the bundled JDK so there's no need to change the Java selection.

      Windows

      EXE installer: TRiBot-windows-x64-4.0.3.exe


      MSI installer: TRiBot-windows-x64-4.0.3.msi


      Portable version: TRiBot-windows-x64-4.0.3.zip


      Mac OS

      Installer: TRiBot-macos-4.0.3.dmg


      Portable version: TRiBot-macos-4.0.3.tgz


      Unix/Linux

      Installer: TRiBot-unix-4.0.3.sh


      RPM installer (CentOS/Fedora): TRiBot-linux-4.0.3.rpm


      DEB installer (Debian): TRiBot-linux-4.0.3.deb


      Portable version: TRiBot-unix-4.0.3.tar.gz


      Platform Independent

      JAR file: tribot-loader-4.0.3.jar


      Note that this jar file does not include the bundled JDK.



      Windows and Mac OS users may notice a warning message stating that the installer/application is un-recognized or un-trusted. Please ignore this message and proceed with running the installer/application. We need to acquire a code signing certificate so that we can sign the installers letting the operating system know that these files can be trusted. It will take a week or more to acquire one, so please hold tight.

      Other notable changes to the TRiBot Loader:

      Support getting the version from OpenJDK distributions


      Add check for bundled JDK


      Copy OpenJDK tools.jar to the bundled JDK if not present


      Set the current java as the first available list entry


      Ignore Java versions which are symbolic links


      Make the bundled JDK the preferred Java version


      Update icon images


      Reduce the number of HTTP calls
      • 24 replies
    • TRiBot is looking to improve a lot of its customer relationship management, customer on boarding process, customer experience, design elements, community engagement and pretty much everything else you can imagine when it comes to marketing.

      Our goal: To ensure that the marketing done TRULY reflects the experience and does not shine an inaccurate light on what TRiBot is lacking in.

      So I ask, what do you love about TRiBot and what do you hate about TRiBot? What does O S Bot, Rune M8, PowR Bot and Dre amBot do better? (yes I purposely didn't spell it right 😂).

      Love, 

      RileyZ
      • 18 replies
    • Hello TRiBot,

      Today we have a significant release that has been in the works for the last month addressing several key issues, features and bugs in the backlog.

      With these changes, we are also including a new TRiBot Loader which will allow you to select any version that is released. This adds the flexibility of allowing you to revert to a previous version should an issue arise, run development only builds, view an accurate change log between versions etc. we are very proud to offer this feature and think it will add a lot more functionality down the road as we continue to release new versions.

      These changes include 80+ commits by our development team, a list of them is summarized below and also available for your viewing pleasure in the new TRiBot Loader.

      In addition, we have taken additional steps to improve as a development team by adding continuous integration and deployment into our workflow to assist in delivering timely releases such as bug fixes as well as new features on a weekly basis depending on our development cycle.
      • 39 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...