Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Sign in to follow this  
left nostril

Interface Trouble

Recommended Posts

For some reason I can't get this interface to work. I am fairly new to scripting and am just trying to make some simple scripts.

Every time I run this script, it will click the pot of flour and water over and over again and never actually clicks the make pizza button. Here is my code.

public class MakeDough extends Task {

    final static int FLOUR_ID = 1933;
    final static int WATER_ID = 1921;
    final static int PIZZADOUGH_ID = 2283;
    
    RSInterface doughButton = Interfaces.get(270, 16);
    @Override
    public boolean activate() {
        return (Inventory.getCount(FLOUR_ID)>0 && Inventory.getCount(WATER_ID)>0 && !Banking.isBankScreenOpen());

    }


    @Override
    public void execute() {
        RSItem[] potOfFlour = Inventory.find(FLOUR_ID);
        RSItem[] bowlOfWater = Inventory.find(WATER_ID);

        if (Clicking.click("Use", potOfFlour[0])) {
            Timing.waitCondition(new Condition() {
                @Override
                public boolean active() {
                    General.random(100, 200);
                    return Game.isUptext("Use");
                }
            }, 3000);
        }
        if (Clicking.click("Use", bowlOfWater[0])) {
            Timing.waitCondition(new Condition() {
                @Override
                public boolean active() {
                    General.random(100, 200);
                    return Interfaces.isInterfaceValid(270);
                }
            }, 3000);
        }
 
            if (doughButton.click("Make")) {
                Timing.waitCondition(new Condition() {
                    @Override
                    public boolean active() {
                        General.random(100, 200);
                        return Inventory.getCount(FLOUR_ID)=0 || Inventory.getCount(WATER_ID)=0;
                    }
                }, General.random(1000, 22500));
            }
        
    }
}

Edited by left nostril

Share this post


Link to post
Share on other sites
4 hours ago, left nostril said:

Awesome! that worked perfect. Thank you!

You might have fixed the problem with the interface, but I am more concerned about the runtime exceptions that can crash your script at any point.

 

The interface doughButton needs to be null checked before attempting to invoke click, or any one of its methods. Otherwise a NullPointerException can occur.

 Clicking.click("Use", potOfFlour[0]) There is no guarantee that index 0 of the array (first element) exists. Attempting to access a non-existing array index will result in an ArrayIndexOutOfBoundsException. This can be prevented by checking if the length of the array is greater than the index that you want to access. For example, an array of length 1 is guaranteed to have index 0. An array of length 4 is guaranteed to have indexes 0, 1, 2, 3 etc.

Here is an edited version of the code posted in the OP. It still has plenty of problems, but it will no longer crash the script:

Spoiler
@Override
public void execute() {
	RSItem[] potOfFlour = Inventory.find(FLOUR_ID);
	if (potOfFlour.length > 0) {
		if (potOfFlour[0].click("Use")) {
			Timing.waitCondition(new Condition() {
				@Override
				public boolean active() {
					General.random(100, 200);
					return Game.isUptext("Use");
				}
			}, 3000);
		}
	}
	
	RSItem[] bowlOfWater = Inventory.find(WATER_ID);
	if (bowlOfWater.length > 0) {
		if (bowlOfWater[0].click("Use")) {
			Timing.waitCondition(new Condition() {
				@Override
				public boolean active() {
					General.random(100, 200);
					return Interfaces.isInterfaceValid(270);
				}
			}, 3000);
		}
	}

	RSInterface doughButton = Interfaces.get(270, 16);
	if (doughButton != null) {
		if (doughButton.click("Make")) {
			Timing.waitCondition(new Condition() {
				@Override
				public boolean active() {
					General.random(100, 200);
					return Inventory.getCount(FLOUR_ID) == 0 || Inventory.getCount(WATER_ID) == 0;
				}
			}, General.random(1000, 22500));
		}
	}
}

 

 

 

Edited by Einstein

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this  

  • Our picks

    • This update features:

      Fixed broken hooks from today's update


      Fix wilderness level with RuneLite (Thanks @Todd)


      Add support for Kotlin .class files in scripts (Thanks @wastedbro)


      Overhaul Inventory API (Thanks @wastedbro)


      Add List support for common methods


      Change method grouping to make more sense (by functionality)


      Refactor methods to utilize Java 8 streams instead of cumbersome loops




      Recognize chatbox minimization (Thanks @JoeDezzy1)


      Fix Screen#isInViewport when NPC chat is open (Thanks @JoeDezzy1)


      Fix login bot bugs (Thanks @erickho123)


      Fix hint arrow return values (Thanks @Encoded)


      Fix depositAllExcept functionality (Thanks @wastedbro)


      Change containing box interface bound and adjust for Y values (Thanks @erickho123)
        • Like
      • 150 replies
    • This release will:

      Fix prayers and world hopper API (Thanks @JoeDezzy1 and @erickho123)


      Improve banking API (Thanks @Encoded)


      Adds methods for returning and using Java Lists, rather than arrays


      Slightly randomizes some hardcoded behaviour


      Removes sleeps from waitConditions; the efficiency saving potential is negligible in these use-cases, therefore cleaner code is preferable


      Other back-end improvements





      Note: If you are using LG, please restart both the RS client and TRiBot.
        • Sad
        • Haha
        • Thanks
        • Like
      • 90 replies
    • This release will:

      Add new internal framework for capturing exceptions


      Fix issue with not selecting the last column in world hopper (Thanks @Todd)


      Add a message about pin usage in Banking#openBank (Thanks @Todd)


      Disable the firewall by default (Thanks @Todd)


      Fix handling of the welcome screen after login (Thanks @Encoded)


      Fix wrong amount bank withdrawal (Thanks @Encoded)


      Fix Screen#isInViewport


      Fix Game#isInViewport (Thanks @Encoded)


      Call onBreakEnd for ListenerManager Breaking Listeners (Thanks @Encoded)


      Fix Prayer#getPrayerPoints NumberFormatException (Thanks @JoeDezzy1)



      Note: If you are using LG, please restart both the RS client and TRiBot.
        • Thanks
        • Like
      • 28 replies
    • This release will:

      Fix LG for both OSBuddy and RuneLite


      Fix issue where the resizable client isn't able to be made smaller (Thanks @JoeDezzy1)


      Fix detection of the logout game tab when resizable mode and side panels are enabled (Thanks @JoeDezzy1)


      Add initial support for Sentry to allow us to identify and easily debug exceptions happening with all TRiBot users


      Add methods to determine if the bank is actually loaded, and not just the overarching interface (Thanks @wastedbro)



      Upcoming updates:

      Improved CLI support


      Full Sentry support


      Much more
        • Like
      • 64 replies
    • This release will:

      Fix NPE in Camera API (Thanks @wastedbro)


      Update deposit box interface ids (Thanks @Encoded)


      Add various bank methods (Thanks @wastedbro)


      Banking#getWithdrawXQuantity


      Banking#getDefaultWithdrawQuantity


      Banking#arePlaceholdersOn




      Fix resizeable minimap bug (Thanks @wastedbro)


      Remove Java 8 requirement


      Please note: TRiBot is not yet fully compatible with Java 10+




      Fix the break handler issues by ensuring the break handler thread never gets paused


      Fix broken settings hooks



      Upcoming updates:

      Improved CLI support


      Much more



      Note: If you are using LG, please restart both the RS client and TRiBot
        • Like
      • 68 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...