Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Sign in to follow this  
Jerminater

Bank pin system broken?

Recommended Posts

Scenario:

I have an empty script with Banking.openBank();

Script will click the bank, and click again right away which enters an incorrect number into the interface.

Deleted hooks.dat

Only way it succeeds is if it clicked the bank and the mouse is not hovering a pin number button when the interface pops up.

Solutions?

Share this post


Link to post
Share on other sites

It's clicking the pin screen because you're calling Banking.openBank(); over and over again. It's trying to right click the banker/bankbooth to open the bank, but the bank is already open.

You need to not call for it to open the bank if the bank is open, and should add a waitcondition for when it successfully clicks the bank booth/banker.

Share this post


Link to post
Share on other sites
1 hour ago, Adventure_Time said:

It's clicking the pin screen because you're calling Banking.openBank(); over and over again. It's trying to right click the banker/bankbooth to open the bank, but the bank is already open.

You need to not call for it to open the bank if the bank is open, and should add a waitcondition for when it successfully clicks the bank booth/banker.

Sorry I should have elaborated more. I placed a 3 second delay in the loop so it only calls every 3 seconds. Still does it.

Share this post


Link to post
Share on other sites
5 hours ago, HeyImJamie said:

I assume you're checking to see if the bank is open before calling that method?

That seemed to do the trick. In my code, I have a check if I am still at the bank, and if the bank successfully closed. I use a custom bank opening method. I just failed to wait if the bank is open yet before trying again. 

Dumb mistake lol. Just fixed up my method.

Share this post


Link to post
Share on other sites
4 minutes ago, Jerminater said:

That seemed to do the trick. In my code, I have a check if I am still at the bank, and if the bank successfully closed. I use a custom bank opening method. I just failed to wait if the bank is open yet before trying again. 

Dumb mistake lol. Just fixed up my method.

Happens! :P Glad it's fixed.

Share this post


Link to post
Share on other sites
On 7/18/2018 at 9:11 AM, HeyImJamie said:

Happens! :P Glad it's fixed.

@HeyImJamie

Yeah no, not fixed. I thought it was lol. No idea how to troubleshoot this. It is not being called twice. I stopped using my custom method.

Bank pin is entered immediately after opening.

guvTvkf.png

This is the code that is called:

40Utc7P.png

and "Print 2" is never printed to the debugger as the pin bot fails, though it prints as succeeded:

GUU2hkA.png

Edited by Jerminater

Share this post


Link to post
Share on other sites

I'm having this issue as well, so I decided to test the method individually 

 

@Override
public void run() {
	Banking.openBank();

	while(true) {
		General.sleep(500);
	}
}

The openBank() method opens the bank and clicks again very quickly which can accidentally input a pin number which will cause the pinbot to not work properly. Going to submit an issue 

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this  

  • Our picks

    • This update features:

      Fixed broken hooks from today's update


      Fix wilderness level with RuneLite (Thanks @Todd)


      Add support for Kotlin .class files in scripts (Thanks @wastedbro)


      Overhaul Inventory API (Thanks @wastedbro)


      Add List support for common methods


      Change method grouping to make more sense (by functionality)


      Refactor methods to utilize Java 8 streams instead of cumbersome loops




      Recognize chatbox minimization (Thanks @JoeDezzy1)


      Fix Screen#isInViewport when NPC chat is open (Thanks @JoeDezzy1)


      Fix login bot bugs (Thanks @erickho123)


      Fix hint arrow return values (Thanks @Encoded)


      Fix depositAllExcept functionality (Thanks @wastedbro)


      Change containing box interface bound and adjust for Y values (Thanks @erickho123)
      • 151 replies
    • This release will:

      Fix prayers and world hopper API (Thanks @JoeDezzy1 and @erickho123)


      Improve banking API (Thanks @Encoded)


      Adds methods for returning and using Java Lists, rather than arrays


      Slightly randomizes some hardcoded behaviour


      Removes sleeps from waitConditions; the efficiency saving potential is negligible in these use-cases, therefore cleaner code is preferable


      Other back-end improvements





      Note: If you are using LG, please restart both the RS client and TRiBot.
      • 90 replies
    • This release will:

      Add new internal framework for capturing exceptions


      Fix issue with not selecting the last column in world hopper (Thanks @Todd)


      Add a message about pin usage in Banking#openBank (Thanks @Todd)


      Disable the firewall by default (Thanks @Todd)


      Fix handling of the welcome screen after login (Thanks @Encoded)


      Fix wrong amount bank withdrawal (Thanks @Encoded)


      Fix Screen#isInViewport


      Fix Game#isInViewport (Thanks @Encoded)


      Call onBreakEnd for ListenerManager Breaking Listeners (Thanks @Encoded)


      Fix Prayer#getPrayerPoints NumberFormatException (Thanks @JoeDezzy1)



      Note: If you are using LG, please restart both the RS client and TRiBot.
        • Like
      • 28 replies
    • This release will:

      Fix LG for both OSBuddy and RuneLite


      Fix issue where the resizable client isn't able to be made smaller (Thanks @JoeDezzy1)


      Fix detection of the logout game tab when resizable mode and side panels are enabled (Thanks @JoeDezzy1)


      Add initial support for Sentry to allow us to identify and easily debug exceptions happening with all TRiBot users


      Add methods to determine if the bank is actually loaded, and not just the overarching interface (Thanks @wastedbro)



      Upcoming updates:

      Improved CLI support


      Full Sentry support


      Much more
      • 64 replies
    • This release will:

      Fix NPE in Camera API (Thanks @wastedbro)


      Update deposit box interface ids (Thanks @Encoded)


      Add various bank methods (Thanks @wastedbro)


      Banking#getWithdrawXQuantity


      Banking#getDefaultWithdrawQuantity


      Banking#arePlaceholdersOn




      Fix resizeable minimap bug (Thanks @wastedbro)


      Remove Java 8 requirement


      Please note: TRiBot is not yet fully compatible with Java 10+




      Fix the break handler issues by ensuring the break handler thread never gets paused


      Fix broken settings hooks



      Upcoming updates:

      Improved CLI support


      Much more



      Note: If you are using LG, please restart both the RS client and TRiBot
      • 68 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...