Jump to content
Ulsting

Would like Feedback on my Script

Recommended Posts

Greetings all,

I have just created my first script! I am making this post primarily to have other scripters give me feedback on my code in general. Specifically, I am looking for comments about my ABC2 implementation as well as my TRiBot API usage, and whether I could be doing things better with regards to either. But any advice is welcome.

One thing in particular I am not quite proud of is how I determined what is "open ground". I have looked at other firemaker scripts that I could find and they seemed to be doing it in much the same way. I tried to come up with a more elegant, robust, and all together decent solution but after a while I just wanted to get a working script and start getting feedback.

For those of you who aren't scripters and would just like to try the firemaker in order to help me bug test, YOU HAVE BEEN WARNED, it has NOT been tested very thoroughly nor am I at all an experienced scripter and as such, I can not speak as to how well I have implemented anti ban techniques.

That being said, if anyone would like to test my script and find bugs or behavior that should be changed, you are more than welcome to. Please include the client log along with your bug report, as I have made the script quite verbose intentionally, at least for now.

 

Firemaker.java

 

AntiBanExtenderUtil.java

 

Edited by Ulsting
  • Like 2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Similar Content

    • By duk151
      Request: Alching on charged bracelets of ethereum
      Description:   Starting with some gold and nature rune in your inventory and have revenant ethers in your bank. Buying 26 uncharged bracelets of ethereum from grand exchange and charge each bracelet with 1 revenant ether. After 26 bracelets are charged it is now time for high alching all of them from your inventory and now profits are made and should go on repeat.  If it possible to set max buying price for uncharged bracelets it would be great. Sorry for my bad English, I can record all the process and send it to you, to understand me more.
      Please add me on Discord if you are willing to write this script for me. Thank you,
      Discord  duk151#5871

      Payment Amount: $110  If all works fine.
      Time:  As soon as possible
    • By Encoded
      http://encodedscripting.com/
      Auto Wintertodt Pro subdues the Wintertodt located on Zeah for profitable firemaking experience.
      This is a dangerous activity. Do not bot with any items you are not willing to lose!
      Requirements:
      - 50+ Firemaking
      Recommended:
      - 21+ Woodcutting w/ Mithril axe if fletching
      - 41+ Woodcutting w/ Rune axe if not fletching
      Current Options:
      - Fletching
      - Lighting Brazier
      - Fixing Brazier
      - Idling at 500 Points
      Braziers Supported:
      - South West
      - South East
      Food Supported:
      - Any item with the "Eat" option, including cakes.
      - Wine
      - Saradomin brews if using item id.
      ABC2 ABCL 10
      Dragon axe special attack supported.
      Purchase:
      6 credits for 1 month, 3 instances. 8 credits for 1 month, 5 instances. 12 credits for 3 months, 3 instances.
      Note: Instances are the amount of accounts that can be ran simultaneously. 90 minute monthly trial; try it before you buy it!

      Click here to purchase.
      Progress Reports:


      Dynamic Signatures:

      Usage Guidelines:
      Have roofs disabled and camera at max zoom.
      Food name must be the exact name when inputting it in the GUI.
      Must have all required items at script start:
      - Axe equipped or in inventory.
      - Tinderbox in inventory.
      - Knife in inventory (only if fletching).
      - Hammer in inventory (only if fixing brazier).
      Client freezing when starting the script?
      Add wintertodt.encodedscripting.com and 192.241.226.189 to TRiBot's firewall always allow.
      Script Support: https://discord.gg/FDnMbkU
      Food Tab Explained

      Food ID or Name - The case sensitive name of the food or the id of it.
      Amount to Withdraw - The maximum amount of food that will be withdrawn when banking. 
      Food Amount To Bank At - The minimum amount of food the script will return to the bank at after a round is finished. 
      Eat At Bank - Withdraws additional food to heal to full or close to full at the bank.
      Use ABC2 Eat At Health - Relies on TRiBot's antiban to determine what health value to eat at.
      Minimum Health to Eat At - self explanatory
      Health Variation - The random amount that is added or subtracted from the minimum health to eat at value. Prevents the script from always eating at the same hp. 
    • By agro36
      All of the current ones are broken / not working at all.
       
      Anyone that can do one that works? 
    • By lets be friends
      1.
      If you're using a local script, is there a way to run the script from within the same script if the script is ending? So basically if the script stops for some reason I want to rerun it. Sometimes the bot will fuck itself trying to dismiss a random (has been happening for like a year) so the script will stop. Would be nice if I could just automatically re-run it from the onEnd function or something so that as the script ends it also restarts itself. I could add other parameters so that it doesnt re-run when I don't want it to.

      2.
      Do extra threads slow down the script by much?
      Will having a concurrent thread that updates my database every 5 minutes or so and the rest of the time it will just sleep going to slow my script down? Or would it be better to start the thread when it needs to update and stop it when its done? and would that slow down the script noticeably?
      Right now it will update every 5 minutes but it takes a few seconds to do it and I would rather get rid of that if I can. Also if the extra thread doesn't slow down the script at all it would be nice to chuck some other stuff in there to speed up the actual botting part. like getting prices or something.
    • By fulma
      hey, need help. im running two bots,  bot after ~14 mins stops. running zulrah script. any thoughts?  
      [08:12:48] at java.security.AccessController.doPrivileged(Native Method) [08:12:48] at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) [08:12:48] at java.awt.EventQueue.dispatchEvent(Unknown Source) something like that and after these lines bot automatically stops. to able run script again , i have to kill script instance.
    • By Bot123455
      I made this NMZ Pot Sipper in my free time after taking a Java class this last fall semester. I am very new to the Tribot API and Java in general so it is not the best script, but it seems to work well.



      Features:
      - Drinks an overload potion when needed
      - Drinks prayer potion when needed
      - Dynamic Sleeping
      - GUI with useful information
       
      To start the script simply go into NMZ put your melee prayer up and start the script! I am looking for more proggies and testers so any constructive feedback would be wonderful, please no flame I am not claiming to be good at scripting nor am I claiming this NMZ script is good in anyway just practicing and improving.
      Repository Link: https://tribot.org/repository/script/id/2618
      GitHub Code: https://github.com/kingboypwnz/KingboyNMZ
       
      Coming Soon:
      - fix HP XP/Hour
      - Super Restore Support
      - Absorption potion Support
      - Rockcake Support
      - Updated GUI/Paint
      - Better Anti-Ban (still no bans reported as writing this)
    • By Rezon365
      I'm talking about F2P, long run account scripts that will get you 100k?/h
       
      Premium scripts or not doesn't matter
  • Our picks

    • This update will:

      Fix GE inventory item positioning bug


      Fix broken object hooks
      • 23 replies
    • This release will:

      Fix some ClosedChannelException bug


      Fix bug in RSObject#getAllTiles


      Add game tab support for "Kourend Favour"
      • 15 replies
    • This release will:

      Fix Settings UI placement bug


      Fix game object location bug


      Fix small layout bug making the client shift up and down


      Fix client crashing bug where loading the client with a small display area will cause the client to crash


      Fix annoying Linux bug relating to painting events and peers


      Fix settings saving bug where settings are saved to disk more often than they should


      Fix RSInterface#isBeingDrawn bug affecting a limited amount of people


      Drop Java 1.7 bytecode version for 1.8


      Important: Since the downloadable RS client uses Java 7, it will no longer be compatible with Looking Glass. To make up for this, we will add support for using other clients such as RuneLite (at a later date).


      This change was necessary to allow us to use Java 8 syntax. It also paves the way for Java 9/10/11 support.
      • 40 replies
    • This update will:

      Fix the RSMenuNode bug which also fixes the bug with bank opening


      Fix the incorrect object positions bug


      Fix and re-enable the LG Objects API Accelerator


      Fix the RSObject#getAllTiles bug
      • 22 replies
    • Try our development release by checking "Development Release" on the TRiBot Loader. Note that these new features are currently in beta.

      This release features:

      Re-sizable mode support for both LG and the regular client


      Slightly improved login bot


      Removed final access modifiers from API classes


      Added RSServer hook wrapper to get the client's cached list of server/world info


      [NEW] Bug fix for intelligent banking


      [NEW] Improvement to the stability of LG over time


      [NEW] Vastly improved the reliability and speed of Screen#getColorAt on both LG and the regular client


      [NEW] Fix LG login problems


      [NEW] Fixed re-sizable mode container bug


      [NEW] Fixed re-sizable mode mouse bug


      [NEW] Use of public constants in the Banking API


      [NEW] Use of other various constants such as Projection#NULL_PT and Screen#EMPTY_COLOR



      More features to come very soon!

      Please test it and let us know here if there are any new bugs introduced in this release.
      • 12 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×