Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Ulsting

Would like Feedback on my Script

Recommended Posts

Greetings all,

I have just created my first script! I am making this post primarily to have other scripters give me feedback on my code in general. Specifically, I am looking for comments about my ABC2 implementation as well as my TRiBot API usage, and whether I could be doing things better with regards to either. But any advice is welcome.

One thing in particular I am not quite proud of is how I determined what is "open ground". I have looked at other firemaker scripts that I could find and they seemed to be doing it in much the same way. I tried to come up with a more elegant, robust, and all together decent solution but after a while I just wanted to get a working script and start getting feedback.

For those of you who aren't scripters and would just like to try the firemaker in order to help me bug test, YOU HAVE BEEN WARNED, it has NOT been tested very thoroughly nor am I at all an experienced scripter and as such, I can not speak as to how well I have implemented anti ban techniques.

That being said, if anyone would like to test my script and find bugs or behavior that should be changed, you are more than welcome to. Please include the client log along with your bug report, as I have made the script quite verbose intentionally, at least for now.

 

Firemaker.java

 

AntiBanExtenderUtil.java

 

Edited by Ulsting
  • Like 2

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Similar Content

    • By Optimus
      Hey guys, Optimus here
        I noticed that TRiBot was lacking a good FREE auto fighter, so I decided to release a Lite Version of Optimus Combat & Magic for free!
      This version of the script has had certain features disabled, but is still very rich in features, so enjoy   To activate the script on the repository, please use the following links:
        https://tribot.org/repository/script/id/3097-optimus-combat-magic/ - Lite Version

      https://tribot.org/repository/script/id/651-optimus-combat-magic/ - Premium Version
      Note: There is a 10 hour FREE TRIAL for anybody who wants to try out the PREMIUM VERSION of the script on the repository
        Preview:   Features Overview:   AIO Combat Features: Green features: FREE            Blue features: PREMIUM
        Start the script from absolutely anywhere in RS and it will navigate to your saved location. Complete all in one combat system that can fight every single monster in Runescape including but not limited too: -Brutal dragons
      -Wyverns
      -Everything in the stronghold of security -Slayer dungeons -Sand crabs -Rock crabs -Dragons -Giants -Goblins -Ghouls -Dagganoths -Chaos Druids
      -And hundreds more different monsters! (Anything you can think of).   Can use all types of food Supports all weapons and special attacks (Full list of spec weapons here: https://pastebin.com/raw/bf56k5Bg) Customisable looting by Item Name, Item ID, or items worth more than x price (Automatic price lookup). Re-equips ammo that you loot ABC2 antiban with a 10/10 rating Can bury bones Load & save GUI settings Profit calculations and xp tracking Customisable mouse speeds Easy to use banking system that works at every bank in RS Can drink every potion in the game Progressive training (Upgrade gear, switch training spots & more) Full worldhopping system that can worldhop when many different conditions are met Full prayer support Superior antiban Slayer task support Safe spotting support Telekinetic grab support Supports all teleport items and spells Guthans healing Dwarf multicannon support Bones to peaches support Automatically uses the Looting bag and Herb sack Automatically resets Rock crabs and Sand crabs aggro (Including 10k island). Keeps a safe distance while using ranged/magic on Brutal dragons Herb cleaning and dropping   AND MORE!   AIO Magic Features: (Premium only) This script can reliably and safely train magic using the following methods:   Every single combat spell available, from air strike to ice barrage; It's all supported Every single curse spell available Stun/combo alching!
      This is the best magic xp in the game, you cast a regular combat spell or curse, quickly followed by a high level alchemy spell.
      This can earn you up to 180k magic xp/hour! Splashing! All alchemy spells All enchantment spells Superheat item All teleport spells The script can also train with the following lunar spells! Humidify Plank make Superglass make Tan leather Spin Flax String Jewellery and More!   To activate the script on the repository, please use the following links:
        https://tribot.org/repository/script/id/3097-optimus-combat-magic/ - Lite Version

      https://tribot.org/repository/script/id/651-optimus-combat-magic/ - Premium Version
      Note: There is a 10 hour FREE TRIAL for anybody who wants to try out the PREMIUM VERSION of the script on the repository   Gallery:    

       
                     
    • By rs06botHein
      Hey Tribot Scripters,
       
      I am looking for a small private script. 
      If possible I want to buy the source code too.
      Private message or skype (below).
       
      Thx in advance!
    • By syhler
      I'm trying to add a JSON library by adding every java file from https://github.com/stleary/JSON-java to my project. But it keeps giving me the error
      java.lang.NoClassDefFoundError: scripts/JSONObject Which makes sense because it fails to load the JSONObject. But why?
       Error Loading Local Script: JSONObject! I have tried to make a package inside the scripts package called "org.json" without any luck, I have also tried to put the files directly into scripts package.(Check picture for reference)

      I don't think the run method has anything to do with it, but it looks like this
      @Override public void run() { println("Hey Test"); JSONObject json = null; try { json = JsonParser.readJsonFromUrl("url"); } catch (IOException e) { e.printStackTrace(); } assert json != null; println(json.toString()); } JsonParser.readJsonFromUrl Comes from a class which is taken from StackOverflow - https://stackoverflow.com/questions/4308554/simplest-way-to-read-json-from-a-url-in-java- 
      And looks something like that
      public class JsonParser{ private static String readAll(Reader rd) throws IOException { StringBuilder sb = new StringBuilder(); int cp; while ((cp = rd.read()) != -1) { sb.append((char) cp); } return sb.toString(); } public static JSONObject readJsonFromUrl(String url) throws IOException, JSONException { InputStream is = new URL(url).openStream(); try { BufferedReader rd = new BufferedReader(new InputStreamReader(is, Charset.forName("UTF-8"))); String jsonText = readAll(rd); JSONObject json = new JSONObject(jsonText); return json; } finally { is.close(); } } } Yes, I do have VIP (at least for 2 days) and I'm using IntelliJ Idea. To set my project up I have used the guide from here.
      Thank you for your time  
       
    • By Encoded
      http://encodedscripting.com/
      Auto Wintertodt Pro subdues the Wintertodt located on Zeah for profitable firemaking experience.
      This is a dangerous activity. Do not bot with any items you are not willing to lose!
      Requirements:
      - 50+ Firemaking
      Recommended:
      - 21+ Woodcutting w/ Mithril axe if fletching
      - 41+ Woodcutting w/ Rune axe if not fletching
      Current Options:
      - Fletching
      - Lighting Brazier
      - Fixing Brazier
      - Idling at 500 Points
      Braziers Supported:
      - South West
      - South East
      Food Supported:
      - Any item with the "Eat" option, including cakes.
      - Wine
      - Saradomin brews if using item id.
      ABC2 ABCL 10
      Dragon axe special attack supported.
      Purchase:
      5 credits for 1 month, 3 instances. 7 credits for 1 month, 5 instances. 10 credits for 3 months, 3 instances. 2 credits for 14 days, 1 instance.
      Note: Instances are the amount of accounts that can be ran simultaneously. 90 minute monthly trial; try it before you buy it!

      Click here to purchase.
      Progress Reports:


      Dynamic Signatures:

      Usage Guidelines:
      Have roofs disabled and camera at max zoom.
      Food name must be the exact name when inputting it in the GUI.
      Must have all required items at script start:
      - Axe equipped or in inventory.
      - Tinderbox in inventory.
      - Knife in inventory (only if fletching).
      - Hammer in inventory (only if fixing brazier).
      Client freezing when starting the script?
      Add wintertodt.encodedscripting.com and 192.241.226.189 to TRiBot's firewall always allow.
      Script Support: https://discord.gg/FDnMbkU
      Food Tab Explained

      Food ID or Name - The case sensitive name of the food or the id of it.
      Amount to Withdraw - The maximum amount of food that will be withdrawn when banking. 
      Food Amount To Bank At - The minimum amount of food the script will return to the bank at after a round is finished. 
      Eat At Bank - Withdraws additional food to heal to full or close to full at the bank.
      Use ABC2 Eat At Health - Relies on TRiBot's antiban to determine what health value to eat at.
      Minimum Health to Eat At - self explanatory
      Health Variation - The random amount that is added or subtracted from the minimum health to eat at value. Prevents the script from always eating at the same hp. 
    • By Starfox
      Hello everyone,
       
      I am posting this to let anyone who wants to join know that I am now hosting a Discord chat for TRiBot users. You can use this chat to talk to other users, ask questions, or simply hang out in the chat. We are the most active botting chat so far with over 40 users online at all times of day.
       
      You can use Discord on the web, or download the application for Windows, Mac OS, or Linux if you prefer. You can find the Discord site here.
       
      To join the chat, simply follow this link and you will automatically join the chat once you accept the invite. All members are welcome, and even if you don't have anything to say you are welcome to afk in the Discord chat. It is required that you make your Discord chat username the same as your TRiBot username so it is easier for other members to identify you. You also must register an e-mail with discord; this is to prevent spam accounts from joining (sorry).
       
       
      I reserve the right to permanently ban anyone from this unofficial chat for any reason. 


      TRiBot Discord Chat Roles:
      @administrator - All tribot admins get this role Your username separated from other members in a nice and shiny red color Ability to do any action in the discord chat except manage the server @moderator - All tribot mods get this role Your username separated from other members in a beautiful green color Kick and ban members Remove messages Move members between channels Create an instant invite to the discord chat Mute members Deafen members Ability to use the @everyone mention to notify all users in the chat of a message @user_moderator Kick members Remove messages Create an instant invite to the discord chat Move members between channels @scripter - All tribot scripters get this role This role is given to people who have the scripter role on TRiBot. You can ask these members questions about programming and script writing. @verified - This role is given out to people who have confirmed their identity on TRiBot. @market_banned - These members are banned from the black market on the TRiBot forums. @trade_with_caution - These members have the TWC pip on the TRiBot forums. @everyone - The default role for anyone in the chat. If you would like to become @verified, simply private message @Starfox or @TacoManStan on TRiBot and discord stating that you would like to be verified.
       
      Moderators and User Moderators, you have the ability to create instant invites to the TRiBot Chat. To create one, click the symbol next to the cog on the #tribotchat text channel. You can replace my global invite link with your own in your signature. I can use this as a metric to see how many people are using your link to join. Who knows, maybe I will reward the users who are getting more people to join =^).
       
      Moderator Application Format:
      Link to your tribot profile List past experiences moderating other forums (with sources) A brief description of your character as a person Send your application to Starfox on discord through a private message.
       
      TRiBot Discord Chat Channels:
      #tribotchat1 The main chat channel for general discussion #tribotchat2 The second chat channel for general discussion overflow #tribotscripting The chat channel to talk about scripting, ask questions, or get help with scripting #oldschoolchat Talk about anything old school runescape related here  
       
      TRiBot Discord Chat Rules:
      You must make your Discord chat username the same as your TRiBot forum username. Do not impersonate any TRiBot member. Do not spam the text channel with tons of the same message or similar messages. If you are purposefully annoying or otherwise unnecessarily argumentative, expect a ban. Do not flame other members of the chat. Arguing is allowed. General in-good-taste banter and harmless comments are also allowed. No Black Market transactions are allowed to take place on Discord. You must conduct them on the forums or elsewhere. Do not purposefully start arguments for the sake of trolling and/or provoke people in the chat. No doxing/hacking/phishing. Do not brag or talk about hacking/doxing other users. You cannot advertise anything of your own such as a website or service. If you break any of the above rules, you will be immediately un-verified and removed from the discord chat.
       
       
       
      If you'd like to support the TRiBot Discord Chat, copy this text into your signature (credits to @Encoded for the image):
        [url][img=http://i.imgur.com/YDz8pP0.png][/img]https://discord.gg/2bYcdjB[/url]  
      I hope to see you in the chat soon!
    • By duk151
      Request: Alching on charged bracelets of ethereum
      Description:   Starting with some gold and nature rune in your inventory and have revenant ethers in your bank. Buying 26 uncharged bracelets of ethereum from grand exchange and charge each bracelet with 1 revenant ether. After 26 bracelets are charged it is now time for high alching all of them from your inventory and now profits are made and should go on repeat.  If it possible to set max buying price for uncharged bracelets it would be great. Sorry for my bad English, I can record all the process and send it to you, to understand me more.
      Please add me on Discord if you are willing to write this script for me. Thank you,
      Discord  duk151#5871

      Payment Amount: $110  If all works fine.
      Time:  As soon as possible
    • By Wormsarecool
      New To TriBot!
      Quick, possibly stupid, question for y'all.
      Say I bought the Auto Tithe Farm and Auto Wintertodt scrips; do those scripts activate the second I purchase them and add them to my client, or do they activate the first time I run them in the client?
      Thanks all!!!
      edit; only reason I ask is because I'm trying to purchase credits and it continues to say something in the lines of "Your card is not made for purchases like this." So was going to attempt to purchase the scripts I want ahead of time.. unless someone can help me out with my situation. Attempting to purchase 25 credits for $25 with my Prepaid Visa Debit Card.
    • By agro36
      All of the current ones are broken / not working at all.
       
      Anyone that can do one that works? 
    • By lets be friends
      1.
      If you're using a local script, is there a way to run the script from within the same script if the script is ending? So basically if the script stops for some reason I want to rerun it. Sometimes the bot will fuck itself trying to dismiss a random (has been happening for like a year) so the script will stop. Would be nice if I could just automatically re-run it from the onEnd function or something so that as the script ends it also restarts itself. I could add other parameters so that it doesnt re-run when I don't want it to.

      2.
      Do extra threads slow down the script by much?
      Will having a concurrent thread that updates my database every 5 minutes or so and the rest of the time it will just sleep going to slow my script down? Or would it be better to start the thread when it needs to update and stop it when its done? and would that slow down the script noticeably?
      Right now it will update every 5 minutes but it takes a few seconds to do it and I would rather get rid of that if I can. Also if the extra thread doesn't slow down the script at all it would be nice to chuck some other stuff in there to speed up the actual botting part. like getting prices or something.
    • By fulma
      hey, need help. im running two bots,  bot after ~14 mins stops. running zulrah script. any thoughts?  
      [08:12:48] at java.security.AccessController.doPrivileged(Native Method) [08:12:48] at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) [08:12:48] at java.awt.EventQueue.dispatchEvent(Unknown Source) something like that and after these lines bot automatically stops. to able run script again , i have to kill script instance.
  • Our picks

    • This release will:

      Fix prayers and world hopper API (Thanks @JoeDezzy1 and @erickho123)


      Improve banking API (Thanks @Encoded)


      Adds methods for returning and using Java Lists, rather than arrays


      Slightly randomizes some hardcoded behaviour


      Removes sleeps from waitConditions; the efficiency saving potential is negligible in these use-cases, therefore cleaner code is preferable


      Other back-end improvements





      Note: If you are using LG, please restart both the RS client and TRiBot.
        • Sad
        • Haha
        • Thanks
        • Like
      • 64 replies
    • This release will:

      Add new internal framework for capturing exceptions


      Fix issue with not selecting the last column in world hopper (Thanks @Todd)


      Add a message about pin usage in Banking#openBank (Thanks @Todd)


      Disable the firewall by default (Thanks @Todd)


      Fix handling of the welcome screen after login (Thanks @Encoded)


      Fix wrong amount bank withdrawal (Thanks @Encoded)


      Fix Screen#isInViewport


      Fix Game#isInViewport (Thanks @Encoded)


      Call onBreakEnd for ListenerManager Breaking Listeners (Thanks @Encoded)


      Fix Prayer#getPrayerPoints NumberFormatException (Thanks @JoeDezzy1)



      Note: If you are using LG, please restart both the RS client and TRiBot.
        • Thanks
        • Like
      • 28 replies
    • This release will:

      Fix LG for both OSBuddy and RuneLite


      Fix issue where the resizable client isn't able to be made smaller (Thanks @JoeDezzy1)


      Fix detection of the logout game tab when resizable mode and side panels are enabled (Thanks @JoeDezzy1)


      Add initial support for Sentry to allow us to identify and easily debug exceptions happening with all TRiBot users


      Add methods to determine if the bank is actually loaded, and not just the overarching interface (Thanks @wastedbro)



      Upcoming updates:

      Improved CLI support


      Full Sentry support


      Much more
        • Like
      • 64 replies
    • This release will:

      Fix NPE in Camera API (Thanks @wastedbro)


      Update deposit box interface ids (Thanks @Encoded)


      Add various bank methods (Thanks @wastedbro)


      Banking#getWithdrawXQuantity


      Banking#getDefaultWithdrawQuantity


      Banking#arePlaceholdersOn




      Fix resizeable minimap bug (Thanks @wastedbro)


      Remove Java 8 requirement


      Please note: TRiBot is not yet fully compatible with Java 10+




      Fix the break handler issues by ensuring the break handler thread never gets paused


      Fix broken settings hooks



      Upcoming updates:

      Improved CLI support


      Much more



      Note: If you are using LG, please restart both the RS client and TRiBot
        • Like
      • 68 replies
    • This release will:

      Add support for using custom F key bindings to switch between game tabs (Thanks @erickho123)


      Fix tab opening for "Skills" and "Kourend Tasks" (Thanks @erickho123)



      Note: If you are using LG, please restart both the RS client and TRiBot
        • Like
      • 34 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...