Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Buy OSRS Gold

Sell OSRS Gold
God

Godspower33 Scripter Application

Recommended Posts

1) Snippets:  N / A

2) Tutorials:  N / A

3) Randoms/updates submitted:  N / A

4) Scripts available to the public: [Source] (Link to thread)
 

I previously applied with these three scripts, I went through and did a near complete re-write on all of them.

Source: Gods Fungus

 

Source: Gods Man Killer

 

Source: Gods Pizza Topper


5) Short biography / Coding Experience: 

I'm currently a college student studying Computer Science. I have been scripting for TRiBot for awhile now, before that I had worked on private servers and on Scar. I have been writing some public scripts and maintaining them, but mostly I have written scripts that I use for personal botting. I have always been a gold-farmer and I like to write new scripts for any new or unique methods that I find or hear about.


6) Reasons why you feel you deserve Scripter: 

I would make a good addition because I can provide quality scripts with consistent updates when needed and not go inactive without some form of notice ( which is unlikely, I haven't gone inactive since I started botting.) 

7) What you plan to provide the community with: 

Providing the community with quality scripts, and tutorials if I see the need to create some for the benefit of the community. Also maintaining all my scripts available on repository if any user reports a bug or error in the script.

8) Do you agree to continue to not only update, but provide more free, open sourced scripts to the community? 

Yes.

 

@Usa  Source: Gods Man Killer  Is the script that has abc2 implementation. 

 

@laniax I don't mean to say this the wrong way, but what would constitute a non-basic script? I do know that my Man Killer, Pizza Topper are fairly basic, only requiring a few actions. I suppose it could be said about the Fungus collector as well. I would just like your opinion on a good script to write. When you say my naming conventions are named weirdly, are you referring to the naming I chose to use, or based off Java naming conventions. Also, what do you mean specifically when you say my code is complex and annoyingly split up? I went back through and added in ABC2 trackers, and Choose option menu opening. I appreciate your time for checking out my code, thanks.

@Usa Ah okay, I see now. I was originally adding a static value to my ab2WaitTimes because I thought it wouldn't have a value in there at first since I didn't generate trackers and add the value to the list until after it attacks a npc. That makes a lot more sense, I didn't fully understand abc2 from the tutorial and tried searching for open source scripts that have it, however I didn't find any that were of help. I think I understand now how I should be generating trackers and using them off your pseudo-code now. I am gonna update the source code later tonight once I get back home.

 

@Usa Can I get an update on my decision please? It's been nearly two months since I originally posted my application, and I tried reaching out to you via Discord when you were online, but no response.

Edited by godspower33
  • Like 3

Share this post


Link to post
Share on other sites

While your code is mostly decent, I would like to see you contribute more recently to the community. It's still a yes from me as you're active in the community/discord as well, but I wish you had applied with different concept scripts than last time.

Share this post


Link to post
Share on other sites

I'm not really impressed, basic scripts, code is obviously convoluted, naming is weird sometimes, things are annoyingly split up.
But the interaction with the TRiBot API looks okay, i was planning to vote yes until i checked on your ABC2 usage in your man killer, i cannot find any trackers being generated, or any reaction times being slept, nor any choose option menu items being hovered, etc. If you properly implement ABC2 - 10 into one of your scripts, i'd change my vote. But for now it's a no.

  • Like 3

Share this post


Link to post
Share on other sites

Follow up to laniax's post since he hasn't commented about your changes.

When hovering or menu opening, make sure the mouse is in bounds first.
For the generate method, you should be using the average wait times that your character was idle for. For combat, idle is defined as the duration you are in combat before having to perform an action.
You should only be generating trackers in your combat method. Walking is something that can be quantified and not something that is variable.

I see no need for move to anticipated or switch on high competition and the rest of the ABC2 methods appear to be implemented.
 

Share this post


Link to post
Share on other sites

For your Gods Man Killer,

	@Override
	public void execute() {
		GodsManKiller.status = "Killing a man";
		RSNPC[] man = NPCs.find("Man");
		if (man.length > 0) {
			final RSNPC target = AntiBan.selectNextTarget(man);
			abc2WaitTimes.add(General.random(1200, 2800));

You add to your list of wait times a static value General.random(1200, 2800)

What you want to do is calculate the reaction time, and generate the trackers based off that waiting time.

Example:

sleepReactionTime()
Find NPC
Walk to NPC if not on screen
If NPC on screen continue
Timer startTime
Attack NPC
Sleep until combat is complete...
While in combat -> if shouldHover -> hover(NPC)
If combat is complete -> generateTrackers(currentTime - startTime)
Loop

Few notes:
- You will want to sleep for the reaction time before performing the next task... not just attacking, that will include walking to the NPC and any other actions that sets you up prior to performing your task whatever it may be (Combat, Talking, etc.)
- You need to get the elapsed time that you were performing the task, that is the value you pass when generating the trackers
- You will also want to perform timed actions while in that loop when you are currently in combat, do not perform them immediately after as that will create a detectable pattern

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

  • Our picks

    • Hi everyone,

      I'd like to thank everyone for their patience in this transition period. Since last week, we've worked out the remaining bugs with this integration.

      Some users have still been having issues with connecting their forums account to their Auth0 account. To resolve this, we've imported all forums accounts into Auth0.

      Unfortunately, the accounts which were imported today were using an unsupported password hashing algorithm. Hence, random passwords were set during the import.

      What does this mean for me?

      If you've previously linked your forums account to your Auth0 account, you don't have to do anything. Nothing changes for you.


      If you haven't logged in via our new login yet,

      Try logging in with your forums email address and the last password you used


      If you are unable to login, please use the "Forgot password" tool on the login page:
      Follow the instructions to reset your password
       
        • Like
      • 1 reply
    • Hello everyone,

      Last week we tried to roll out Auth0 Login, but we lost that battle. Now it's time to win the war!

      Important changes

      When logging into the client, you'll now have to enter your Auth0 account credentials instead of your forums credentials

      Note: 2FA is still handled through your forums account (for the time being)



      Changes for existing users

      You'll have to link your Auth0 account to your forums account here: https://tribot.org/forums/settings/login/?service=11


      Auth0 accounts have been created for most existing users. Please use your forums email address and password to login.



      Important notes

      Make sure to verify your email address upon creating a new Auth0 account


      When we mention your Auth0 account, we mean your account used for auth.tribot.org as displayed below
      • 71 replies
    • To better support the upcoming changes (TRiBot X, new repository), we're switching our login handler to Auth0. Instead of logging in with the standard form, you'll now be required to login through our Auth0 application.

      All existing accounts which have been used within approximately the past year have been imported into Auth0 using the same email and password combination which has been stored on the forums.

      What does this mean for users?

      Your account credentials are now even more securely stored


      You'll be able to login via Facebook, Google, and others in the future


      Is there anything users have to do differently now?

      Existing users: You'll have to login with the standard login, open your Account Settings, then link your Auth0 account


      New users: You'll be redirected to our Auth0 app (auth.tribot.org) where you'll be able to create an account


      Why was this change made?

      The new apps we are creating (such as the new repository) aren't able to use the forums to handle user logins


      To centralize all user accounts in one area


      To ensure that the client login doesn't go down when the forums are having problems


      To speed up our development


      Other considerations

      There's no documentation or official support for using Invision Community combined with Auth0, so there are still a few kinks we're working out


      We're in the works of creating an account management panel specifically for Auth0 accounts (ETA August)


      It's not possible to change email addresses for the time being (this will be resolved this August)


      Changing passwords is a weird process for the time being. To change your password, you'll have to use the "Don't remember your password" tool on the Auth0 login page
        • Like
      • 11 replies
    • Over the past month, we've been working hard on TRiBot's new repository - a much needed update. This change has been deemed necessary for TRiBot X, and will allow us to really speed up development of all aspects of TRiBot.

      Today we are going to share what we've been working on!


      Now you must be wondering what kind of features the new repository will have.... well, you'll have to be patient for a little while longer. We're still figuring out various technical aspects so we can't provide answers to all possible questions. We're also focusing on development rather than writing about it so that everyone can get access to our latest developments at lightning speed. I will however answer a few users' questions.

      We're planning on a release of this early to mid August, giving users some goodies before TRiBot X's release.

      Thank you all for being patient. I hope everyone is excited as much as I am!
        • Like
      • 17 replies
    • Over the past few months, I’ve been working diligently on a new project - TRiBot X. Everything has been written from the ground up, with all of the best practices of software engineering. Every aspect of TRiBot has been re-imagined to support three main goals: flexibility, useability, and reliability.
        • Like
      • 50 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...