Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
TheD

TheD Scripter Application v2

Recommended Posts

Hi,

I'd like to start off by asking you to read this: 

As you can read I have been gone for some time, against my will. I understand that I have to re-earn my scripter rank, and that is the reason why I am re-applying for the rank.

My previous scripter application can be found here.

~~Start of Application~~

1) Snipplets: 
https://tribot.org/forums/index.php?/topic/9493-snippets-some-random-event-codes-instructions/ Random events (Niles, giles, miles, mime, frog island) (OLD)

https://tribot.org/forums/index.php?/topic/9496-snippet-big-monster-attacking-looting/ an alternative way for attacking big monsters. (OLD)

https://tribot.org/forums/index.php?/topic/9841-snippet-walking-method/ Walking method (OLD)

 

2) Tutorials:

https://tribot.org/forums/index.php?/topic/9844-simple-version-check/ Version checking (OLD)
https://tribot.org/forums/index.php?/topic/9499-tut-news-system/ News system (New)

 

3) Randoms/updates submitted: 
I have send the code for solving; Niles, Giles, Miles, Sandwich lady, Frog Island to Trilez. I have also posted them recently here in the form of a snippet: https://tribot.org/forums/index.php?/topic/9493-snippets-some-random-event-codes-instructions/ (OLD)

4) Scripts available to the public: 

Pre-note: I made all the scripts mostly in one class, so it was easier to get it up on pastebin.

DChickens [thread] [Source]  
DGnomeAgility [thread] [Source] 
DClay [thread] [Source]
DStunAlcher [thread] [Source] 

DCows [thread] [Source] *LATEST* This one was created last, and reflects my programming knowledge best, in my opinion.

 

5) Short biography / Coding Experience: 
Hi, I am TheD which stands for TheDutch. I come from the Netherlands and am currently 22 years young. Before I was sent to jail (read story above) I was working on my own Game Framework in C++ based on SDL & OpenGL. In the past I have created several games and have been the owner of a RuneScape Private server in the past with around 250 players online at the same time. I have also created several zombie maps for Call of Duty - World at War. Search for "TripleMGames" on YouTube, and you'll find maps our team created. Besides that I love to work with raspberry pi and hack WII Remotes to create my own custom remote controllers such as a belt I created for RollBotic (See YouTube) 

I am experienced in the following programming languages:
- C++
- C#
- Java
- JavaScript

I Started programming around 7 years ago, I have programmed robots since when RSBuddy was first released. I always strive to think one step forward in anti ban and detection of the bots. Besides all that I have always been one of the leaders in private script development. On TRiBot alone I had over 15 private scripts in 2013. Like I said in my last submission I do not want to keep scripts to myself anymore. I find it much more satisfying to release all my creations to the public.

 

6) Reasons why you feel you deserve Scripter:

I have been on TRiBot since nearly the start of 07scape, I am always trying to create new innovative scripts that offer more. I unfortunately have been absent in the past, but I am trying my hardest and am currently re-integrating to the community. Taking feedback and improving what I do based on the feedback I get. However, my scripts run and ran flawless for countless hours on end, and I will continue to release both free & premium scripts (once I can). I believe that I can provide TRiBot with quality scripts that the community needs. 

 

7) What you plan to provide the community with: 
Knowledge about anti ban, and how ABC2 is a tool to assist you in writing a safe script, not the entire solution. I'd like to create both free, premium and open sourced scripts where I can. I take script requests already, and am just releasing them to the public for free :).

8) Do you agree to continue to not only update, but provide more free, open sourced scripts to the community? 
Yes, absolutely

9) Extra

I like to believe that my knowledge is different than others, I might not write scripts just like everyone else, but they work, and have always had a low ban-rate on the structure. 
I would ask other script writers to not only answer yes or no, but if you got any feedback for me, on any script,guide,tutorial or just code structure. Please post below or send as a private message to @TheD feedback can help me improve, and that's my main goal. :)

Thanks for your time to read this thread.

Kind regards,

DScripting - TheD

Edit: Added a script that best reflects my actual knowledge of programming in Java for Tribot. See the source: https://github.com/DScripting/DCows

 

  • Like 5

Share this post


Link to post
Share on other sites

Your attitude is pretty great, your code is pretty terrible. I'm not sure how to combine that into a yes/no vote at this time. 

 

Edit: After going through more of your code, it has to be a no. Just way too bad. 

Edited by Assume
  • Like 4

Share this post


Link to post
Share on other sites

If the application was solely judged on attitude & character, you would probably pass with flying colors. Unfortunately, it's not.

I don't want to come off too strong, but the code is definitely stopping me from voting yes.

It's a no from me, for now. I'll PM you with my observations later today when I'm not too busy.

Edited by Final Calibur
  • Like 2

Share this post


Link to post
Share on other sites

Like said above, your attitude towards criticism and scripting overall is impressive. 

However, my vote remains no because your code does not meet a scriptwriter's code. I suggest rewriting your scripts with the criticism you are given here and reapply in the next 2-3 weeks with your improved code. Please don't apply with old poor code.

To begin with, your chicken killer is quite cluttered for a simple chicken killer.

private long Start_str_XP = Skills.getXP(SKILLS.STRENGTH);

This should be lower camel case according to oracle conventions. Your naming is not consistent in some cases.

As well, the entire class is cluttered. Your code is not organized or structured at ALL. The code is already eye bothering to read. If you were to write a bigger script, this will become a problem. Don't shove everything into one class.

 

 

  1. if(Interfaces.get(233, 2) != null)
  2.         {
  3.             Interfaces.get(233, 2).click("Continue");
  4.             DAntiban.smartSleep(750,900);
  5.         }

You are not properly nullchecking. Your application should actually be auto denied because of https://tribot.org/forums/topic/32245-scripting-knowledge-requirements

Good thing is that proper null checking is an easy concept to grasp. You should first cache the interface to prevent a NPE. 

 

As well, you have a newsloader class however in every script, you define latestNews and newsStartTime. This is so redundant and you could easily fix this by making it part of your NewsLoader class. 

 

  1.  RSObject[] rope = Objects.getAt(new RSTile(2478,3420,2));
  2.             if(rope[0] != null && rope.length > 0)  DynamicClicking.clickRSObject(rope[0], "Walk-on");
  3.             goSleep(2000);

This is wrong in so many ways. You cannot check if rope[0] is null before checking if rope.length > 0. This will result in an AOOB exception.  (Short circuit evaluation).

This method will go to sleep even if the rope did not exist. It will also go to sleep if it failed to click the object.  (This is shown throughout your script as well)

 

Begin to use RSArea. Stop doing RSTile#getX() < xx and RSTile#getX() > xx. It just shows that you are not THAT famliar with the API yet.

 

There's just too many flaws with your script. It's extremely unorganized and cluttered. 

Please read trilez scripting tutorial to give you a REALLY good idea of how you can start off on the RIGHT foot: https://tribot.org/forums/topic/30185-trilezs-scripting-tutorial/

 

 

If this application gets denied, dont submit your old code again with your application otherwise it'll be accounted against you again. Submit code that reflects you currently. skimmed through your code enough to know you're not ready for, however without a doubt, I'm sure you will take this criticism and improve your code. 

 

  • Like 3

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

  • Our picks

    • Today marks a big day for TRiBot! To make it easier for users to use TRiBot, we've created installers available for every platform! These installers are all bundled with the latest version of OpenJDK 1.8 (Java 😎, which is LG compatible.

      Using TRiBot is now easy. Simply download the installer for your platform, install TRiBot, and run it. The TRiBot Loader will correctly identify the bundled JDK so there's no need to change the Java selection.

      Windows

      EXE installer: TRiBot-windows-x64-4.0.3.exe


      MSI installer: TRiBot-windows-x64-4.0.3.msi


      Portable version: TRiBot-windows-x64-4.0.3.zip


      Mac OS

      Installer: TRiBot-macos-4.0.3.dmg


      Portable version: TRiBot-macos-4.0.3.tgz


      Unix/Linux

      Installer: TRiBot-unix-4.0.3.sh


      RPM installer (CentOS/Fedora): TRiBot-linux-4.0.3.rpm


      DEB installer (Debian): TRiBot-linux-4.0.3.deb


      Portable version: TRiBot-unix-4.0.3.tar.gz


      Platform Independent

      JAR file: tribot-loader-4.0.3.jar


      Note that this jar file does not include the bundled JDK.



      Windows and Mac OS users may notice a warning message stating that the installer/application is un-recognized or un-trusted. Please ignore this message and proceed with running the installer/application. We need to acquire a code signing certificate so that we can sign the installers letting the operating system know that these files can be trusted. It will take a week or more to acquire one, so please hold tight.

      Other notable changes to the TRiBot Loader:

      Support getting the version from OpenJDK distributions


      Add check for bundled JDK


      Copy OpenJDK tools.jar to the bundled JDK if not present


      Set the current java as the first available list entry


      Ignore Java versions which are symbolic links


      Make the bundled JDK the preferred Java version


      Update icon images


      Reduce the number of HTTP calls
        • Like
      • 4 replies
    • TRiBot is looking to improve a lot of its customer relationship management, customer on boarding process, customer experience, design elements, community engagement and pretty much everything else you can imagine when it comes to marketing.

      Our goal: To ensure that the marketing done TRULY reflects the experience and does not shine an inaccurate light on what TRiBot is lacking in.

      So I ask, what do you love about TRiBot and what do you hate about TRiBot? What does O S Bot, Rune M8, PowR Bot and Dre amBot do better? (yes I purposely didn't spell it right 😂).

      Love, 

      RileyZ
        • Like
      • 7 replies
    • Hello TRiBot,

      Today we have a significant release that has been in the works for the last month addressing several key issues, features and bugs in the backlog.

      With these changes, we are also including a new TRiBot Loader which will allow you to select any version that is released. This adds the flexibility of allowing you to revert to a previous version should an issue arise, run development only builds, view an accurate change log between versions etc. we are very proud to offer this feature and think it will add a lot more functionality down the road as we continue to release new versions.

      These changes include 80+ commits by our development team, a list of them is summarized below and also available for your viewing pleasure in the new TRiBot Loader.

      In addition, we have taken additional steps to improve as a development team by adding continuous integration and deployment into our workflow to assist in delivering timely releases such as bug fixes as well as new features on a weekly basis depending on our development cycle.
        • Thanks
        • Like
      • 39 replies
    • Over the last three weeks, I've been working on upgrading our server infrastructure. It's finally ready and is now live!

      Why?

      Increased reliability - less server errors


      Increased availability - less downtime


      Increased security - keeping us and you secure


      Increased capacity - ability to serve you better


      Increased speed - less waiting for things to load


      Faster development - server and service updates will come faster


      What are the changes?

      Move from a single AWS EC2 instance to AWS ECS (Elastic Container Service)


      Distributed computing


      Load balancing


      Git management of server files and filesystem


      Redis caching


      How?

      AWS ECS (with 10 EC2 instances)


      AWS ElastiCache (Redis)


      AWS Load Balancing


      AWS EFS (Elastic file system)


      Please bare with us as I continue to tune the server for maximum performance. Slow loading speeds may occur temporarily. I thank everyone for their patience.

      Please post on this thread if you experience any issues other than slow loading times.
        • Like
      • 51 replies
    • This update features:

      Fixed broken hooks from today's update


      Fix wilderness level with RuneLite (Thanks @Todd)


      Add support for Kotlin .class files in scripts (Thanks @wastedbro)


      Overhaul Inventory API (Thanks @wastedbro)


      Add List support for common methods


      Change method grouping to make more sense (by functionality)


      Refactor methods to utilize Java 8 streams instead of cumbersome loops




      Recognize chatbox minimization (Thanks @JoeDezzy1)


      Fix Screen#isInViewport when NPC chat is open (Thanks @JoeDezzy1)


      Fix login bot bugs (Thanks @erickho123)


      Fix hint arrow return values (Thanks @Encoded)


      Fix depositAllExcept functionality (Thanks @wastedbro)


      Change containing box interface bound and adjust for Y values (Thanks @erickho123)
        • Like
      • 151 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...