Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Liam.

Liam.'s Scripter Application

Does Liam. deserve the scripter rank?  

51 members have voted

You do not have permission to vote in this poll, or see the poll results. Please sign in or register to vote in this poll.

Recommended Posts

It's a definite yes from me.

You definitely have the knowledge required, you're very active, and I do see you helping users on a consistent basis.

I don't care that you've written private scripts in the past. The rules were not properly explained, and you've never made any attempt to hide what you did. I respect that.

To be honest, there is no real reason for anyone to vote no, other than out of a personal issue with you. You already meet and surpass the knowledge requirements, and definitely have the passion to do more than just try to cash in. Besides, this is for regular scripter, not premium.

  • Like 3

Share this post


Link to post
Share on other sites

Your code across your scripts are not consistent. Some uses oracle conventions and some don't. I assume this was before you decided to take time to learn about them.

You're using Boolean objects for no reason, you should really stick with boolean (primitive)

I noticed while examining some of your scripting libs that you don't use proper null checking: https://github.com/Internetwarrior/tribotscripts/blob/master/scripts/tribot/liam/lib/game/equipment/EquipmentManager.java. Maybe that was just a fluke, but if not, you should really learn how to null check properly because that is a scripting requirement. (Cache definition value then nullcheck)

You're using the class name in order to get the script's status in EnCrafter, but what you should really be doing is creating an abstract method for your nodes.

You say you've been programming seriously using Java for about 2 years, but your code doesn't exhibit 2 years of serious java coding. Regardless, I'm still voting yes (just make sure you get all 3 scripts up), since I've seen you active in the community and seem to know enough about scripting. Making scripts for the community isn't exactly that hard once you know the fundamentals of java.

Edited by erickho123

Share this post


Link to post
Share on other sites

As you are aware, I am now giving applicants a code challenge to earn my vote assuming the applicant meets the requirements. Since you said my challenges can be easily googled, then this one should be of no trouble.

Your challenge:

Find a Square

Given an array of 4 RSTile objects, determine if the tiles create a square. Each RSTile in the array is a corner of the polygon. The polygon is a square if the 4 sides are of equal length.

Hint: You may or may not need to create your own distance method to get the correct output.

Test cases:

// Input
{new RSTile(3232, 3224), new RSTile(3232, 3220), new RSTile(3236, 3220), new RSTile(3236, 3224)}
{new RSTile(3232, 3225), new RSTile(3232, 3220), new RSTile(3235, 3220), new RSTile(3235, 3225)}
{new RSTile(3237, 3220), new RSTile(3235, 3220), new RSTile(3235, 3221), new RSTile(3237, 3221)}

// Output
true
false
false

 


@Liam. http://pastebin.com/ci6PZUer is incorrect. That code will always return false. I'm a bit concerned you didn't even bother to test your own code. That pastebin doesn't even compile because there is a missing closing parenthesis which I had to add to test. You aren't being rushed to answer and I would much rather see the right answer than a fast response.

Edited by Encoded

Share this post


Link to post
Share on other sites

I personally talked to you about what your intentions were and what you really wanted. I enjoyed what you had to say and I believe your intentions are in the right place. 

You're a good person and you help out the community quite a lot which I love to see. You're also very active and have been a member of this community for the past 2 years.

I believe that you have the knowledge and what it takes to be a Scripter for this community so I'm going to vote yes. I can see you here for a long time providing good content and you don't seem to be a flaky person like I have seen in the past.

 

  • Like 3

Share this post


Link to post
Share on other sites

The application system is exactly that. It's to get all your dirty secrets to light. If I want to discuss your scamming in a private chat, it's my prerogative. So USA said if someone wants to buy scripts off site from and offsite scripter and have no contact through any tribot endorsed mediums then it's fine? Yeah he did. Did he say you could sell to tribot users, through the tribot repository and forums? Fuck no he didn't. Also the post you show literally says the words "against the rules". 

Edited by Assume

Share this post


Link to post
Share on other sites

Just a quick 5 minute glance

https://github.com/Internetwarrior/tribotscript/blob/master/scripts/tribot/liam/winegrabber/nodes/GrabWine.java

Line 30, 32, 44: can return NPE. The object returned is 100% unrelated from line 29. It is likely it won't be null.
It however is possible, and will throw a NPE eventually. Easily within a few hours of operation if no faster.

Line 61: why not dynamic sleep, there are very clear conditions to denote the end of this state. A wine appearing in your inventory, the wine disappearing etc.


https://github.com/Internetwarrior/tribotscript/blob/master/scripts/tribot/liam/winegrabber/nodes/WorldHop.java

getWorld : I'm just happy to see someone submit something with recursion 

https://github.com/Internetwarrior/tribotscript/blob/master/scripts/tribot/liam/encrafting/nodes/UseFurnace.java#L71

Can return a null pointer, unless your custom interface class won't return a null. In which case you should remove line 109.

General Suggestions:
- You seem to constantly be dealing with if something else is already selected. 
    Centralize this code, as it appeared in most of your nodes I looked over (and I didn't look over that many).
    It is frustrating because I believe this issue should be solved at the client level. I often find myself when
    writing quick scripts passing through empty strings to the .click method to avoid having to deal with this edge case.
    ughhh!
    ie. You miss clicked the wrong spell, and want to use tele grab, but you have the wrong spell selected.
    
- Use if/else properly. There are alot of cases where you check a condition then a few lines later check the inverse.
    Instead of rechecking, just use an if/else. Your go to design seems to use two ifs, and check the condition in each if (ie. checking it twice)
    just one example, but issue persists through nearly all of your code:
   https://github.com/Internetwarrior/tribotscript/blob/master/scripts/tribot/liam/encrafting/nodes/UseFurnace.java#L81
    
- Use more dynamic sleeps instead of hard coded ones. I think this is just you getting a little bit lazy. But putting together
    a solid combination of dynamic sleeps can be the difference between an ok script, and an amazing one.
    We have all been to the point where writing the dynamic sleep seems daunting, and a quick dirty hardcoded one
    gets the job done, myself included. 
    
warfront1

    

Share this post


Link to post
Share on other sites

Well i thought i would pass on reviewing this one. But seeing that this application has become a bit old now and it hasn't been closed yet, i figure more opinions are welcome.

Personally; Nothing against you, you seemed like a nice guy when i briefly talked to you some time ago. I'm not going to dive into the mess that is clearly stated in this thread, i rather stay wide away from that.

That being said, my vote is a no. Your code just isn't up to the standard for me. There are many empty if statements, static sleeps and general logic mishaps. I am not even going to link to them, i think @warfront1 and others gave enough pointers on that. Your entire application feels rushed, you state that 1 of your 3 scripts is over a year old and is being rewritten, why not apply when you finished that? Whats the rush? Also seeing your answer to @Encoded's challenge were minus points in my book.

I'm sorry, i'm sure you're a nice guy and the above drama with rule-breaking has a solution that will satisfy all involved party's. And i hope you will continue to post and improve new and existing code. Then i will be glad to see another application coming from you.

  • Like 1

Share this post


Link to post
Share on other sites

While the rules may not have been clear as they are now due to misinterpreted quotes from 2013, you were never granted special permission to sell private scripts without the required rank and I do not appreciate you quoting me in this thread and Discord stating so. Your screenshots show exactly what the context of my message was.

That being said, this application wasn't too bad and while its not part of the requirements, your response to Encoded's challenge was concerning as it wasn't even a partial solution.

This application has been open too long to give a definitive yes so I am closing it until your next application after you have something new to show us and the issues that came up in this thread are no longer a factor.

Closed.

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

  • Our picks

    • Today marks a big day for TRiBot! To make it easier for users to use TRiBot, we've created installers available for every platform! These installers are all bundled with the latest version of OpenJDK 1.8 (Java 😎, which is LG compatible.

      Using TRiBot is now easy. Simply download the installer for your platform, install TRiBot, and run it. The TRiBot Loader will correctly identify the bundled JDK so there's no need to change the Java selection.

      Windows

      EXE installer: TRiBot-windows-x64-4.0.3.exe


      MSI installer: TRiBot-windows-x64-4.0.3.msi


      Portable version: TRiBot-windows-x64-4.0.3.zip


      Mac OS

      Installer: TRiBot-macos-4.0.3.dmg


      Portable version: TRiBot-macos-4.0.3.tgz


      Unix/Linux

      Installer: TRiBot-unix-4.0.3.sh


      RPM installer (CentOS/Fedora): TRiBot-linux-4.0.3.rpm


      DEB installer (Debian): TRiBot-linux-4.0.3.deb


      Portable version: TRiBot-unix-4.0.3.tar.gz


      Platform Independent

      JAR file: tribot-loader-4.0.3.jar


      Note that this jar file does not include the bundled JDK.



      Windows and Mac OS users may notice a warning message stating that the installer/application is un-recognized or un-trusted. Please ignore this message and proceed with running the installer/application. We need to acquire a code signing certificate so that we can sign the installers letting the operating system know that these files can be trusted. It will take a week or more to acquire one, so please hold tight.

      Other notable changes to the TRiBot Loader:

      Support getting the version from OpenJDK distributions


      Add check for bundled JDK


      Copy OpenJDK tools.jar to the bundled JDK if not present


      Set the current java as the first available list entry


      Ignore Java versions which are symbolic links


      Make the bundled JDK the preferred Java version


      Update icon images


      Reduce the number of HTTP calls
        • Like
      • 11 replies
    • TRiBot is looking to improve a lot of its customer relationship management, customer on boarding process, customer experience, design elements, community engagement and pretty much everything else you can imagine when it comes to marketing.

      Our goal: To ensure that the marketing done TRULY reflects the experience and does not shine an inaccurate light on what TRiBot is lacking in.

      So I ask, what do you love about TRiBot and what do you hate about TRiBot? What does O S Bot, Rune M8, PowR Bot and Dre amBot do better? (yes I purposely didn't spell it right 😂).

      Love, 

      RileyZ
        • Like
      • 7 replies
    • Hello TRiBot,

      Today we have a significant release that has been in the works for the last month addressing several key issues, features and bugs in the backlog.

      With these changes, we are also including a new TRiBot Loader which will allow you to select any version that is released. This adds the flexibility of allowing you to revert to a previous version should an issue arise, run development only builds, view an accurate change log between versions etc. we are very proud to offer this feature and think it will add a lot more functionality down the road as we continue to release new versions.

      These changes include 80+ commits by our development team, a list of them is summarized below and also available for your viewing pleasure in the new TRiBot Loader.

      In addition, we have taken additional steps to improve as a development team by adding continuous integration and deployment into our workflow to assist in delivering timely releases such as bug fixes as well as new features on a weekly basis depending on our development cycle.
        • Thanks
        • Like
      • 39 replies
    • Over the last three weeks, I've been working on upgrading our server infrastructure. It's finally ready and is now live!

      Why?

      Increased reliability - less server errors


      Increased availability - less downtime


      Increased security - keeping us and you secure


      Increased capacity - ability to serve you better


      Increased speed - less waiting for things to load


      Faster development - server and service updates will come faster


      What are the changes?

      Move from a single AWS EC2 instance to AWS ECS (Elastic Container Service)


      Distributed computing


      Load balancing


      Git management of server files and filesystem


      Redis caching


      How?

      AWS ECS (with 10 EC2 instances)


      AWS ElastiCache (Redis)


      AWS Load Balancing


      AWS EFS (Elastic file system)


      Please bare with us as I continue to tune the server for maximum performance. Slow loading speeds may occur temporarily. I thank everyone for their patience.

      Please post on this thread if you experience any issues other than slow loading times.
        • Like
      • 51 replies
    • This update features:

      Fixed broken hooks from today's update


      Fix wilderness level with RuneLite (Thanks @Todd)


      Add support for Kotlin .class files in scripts (Thanks @wastedbro)


      Overhaul Inventory API (Thanks @wastedbro)


      Add List support for common methods


      Change method grouping to make more sense (by functionality)


      Refactor methods to utilize Java 8 streams instead of cumbersome loops




      Recognize chatbox minimization (Thanks @JoeDezzy1)


      Fix Screen#isInViewport when NPC chat is open (Thanks @JoeDezzy1)


      Fix login bot bugs (Thanks @erickho123)


      Fix hint arrow return values (Thanks @Encoded)


      Fix depositAllExcept functionality (Thanks @wastedbro)


      Change containing box interface bound and adjust for Y values (Thanks @erickho123)
        • Like
      • 151 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...