Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Buy OSRS Gold

Sell OSRS Gold
Sphiinx

Sphiinx's Scripter Application

Application Poll  

37 members have voted

You do not have permission to vote in this poll, or see the poll results. Please sign in or register to vote in this poll.

Recommended Posts

1) Snippets: [sOURCE] (Link to thread)
  • N/A
2) Tutorials: [sOURCE] (Link to thread)
  • Conditional Sleeping
  • Tribot Rank & Title List (Not sure if this should be here)
3) Randoms/updates submitted: [sOURCE] (Link to thread)
  • N/A
4) Scripts available to the public: [sOURCE] (Link to thread)
5) Short biography / Coding Experience: [1-2 short paragraphs]
  • Redacted at the request of Sphiinx.
6) Reasons why you feel you deserve Scripter: [1-3 short paragraphs]
  • I believe that I can provide and uphold quality scripts for the Tribot community. Programming is a passion of mine and I believe we always have to continue learning. I love interacting with the community and this gives me more opportunity to make users happy. I have been apart of this community for almost a year now. It's amazing how much I have learned and I feel that it is my time to give back.
7) What you plan to provide the community with: [1-3 short Paragraphs]
  • I plan to continue to support the community with quality updated scripts that we can all benefit from. Including that I hope to be able to support anyone who is in need with the information I can provide. I have contributed to this community with my experience and expertise for almost a year now and I plan to continue that. I try to keep my scripts as clean as possible for anyone to understand, learn from, and benefit from.
8) Do you agree to continue to not only update, but provide more free, open sourced scripts to the community? [YES/NO]
  • Of course!
9) Responses to replies:
  • USA
    • Redundant Code - I use a lot of classes for OO Java, I see what you mean about combining things that are the same or similar in fashion though.
    • SPXCowKiller Looping - I changed this to what you said, can you take another look?
  • Assume
    • Any reason why you said "nah" so I can improve?
  • Encoded/xCode
    • I believe I did implement full ABCL10 in my AIO Planker script in my ABCL class. I implemented everything that applied to the script and calculated it according to TRiLeZ's documentation and it came out to ABCL10. Do you mind taking another look?
Edited by iFluffee
Sphiinx wanted his bio removed.
  • Like 7

Share this post


Link to post
Share on other sites


 

SPX AIO Cooker

DepositItems / WithdrawItems

Not necessary to have two classes with the same functions, you have redundant code. Maybe move them to a Banking Class where the node is validated on,

 

return Inventory.getCount(vars.foodId) <= 0;

CookFoodOnFire / CookFoodOnStove WalkToFire / WalkToStove

Same here, redundant code.

 

Use an Enum of Type CookingObject for Fire(String name) / Stove(String name) and call your methods on those types.

 



 

SPXAIOPlanker

DepositItems / WithdrawItems

Same here, redundant code just use a class Bank within your framework.

 


 

SPXCowKiller

        RSNPC[] cows = NPCs.findNearest("Cow");        for (final RSNPC cow : cows) {            if (!cow.isInCombat()) {

Instead of looping through each cow, use a filter and use that array of RSNPC.

	private RSNPC[] getCows() {		return NPCs.findNearest(new Filter<RSNPC>() {			public boolean accept(RSNPC npc) {				String name = npc.getName();				if (name == null || !name.equalsIgnoreCase("Cow"))					return false;				return !npc.isInCombat();			}		});			}


 

Overall not too bad, limited use of ABCL but nothing looked too out of order.

 

I will omit my vote for this application pending comments from the Scripters.

  • Like 1

Share this post


Link to post
Share on other sites

nah

 

edit: you asked my reason

 

Everything you wrote would take a scripter no more than 5 minutes start to finish. None of it is impressive nor good enough for a scripter application. 

Edited by Assume

Share this post


Link to post
Share on other sites

I’d like to personally thank @Sphiinx for his help on my programming/botting oriented teamspeak.

One thing that has impressed me about Sphiinx is that he has taken it upon himself to help other members of the teamspeak with their programming issues.

Sphiinx is able to identify issues that others are having, and help draft a path to resolution.

 

Sphiinx, although being a very young developer, has key traits that set him up on a path for success.

He has a fire inside him driving him to retain as much information as possible.

Sphiinx is certainly retaining information at such a rapid rate, that I’m personally excited to see where he will grow within the new year.

If we isolate Sphiinx at this point in time, I think we can all agree he has the know how to create and maintain free content for the community.

A few more months of refining, and releasing free content, I believe Sphiinx could make a significant difference in our community.

 

If I had one take away for Sphiinx it would be to continue keeping your mind open,

and retaining as much information as possible.

Don’t shut yourself out to different ideas, and never lose the desire to continue your education.

There is no end to learning when it comes to programming.

Exposing yourself to other’s ideas can only strengthen your own skill set.

Best,
Warfront1

Edited by warfront1
  • Like 5

Share this post


Link to post
Share on other sites

Couldn't agree with @warfront1 more.

 

From my discussions with @Sphiinx , I've found that he is a pretty quick learner with a certain drive to want to do things correctly. Whenever he asks questions, he always seems to take the response to heart and actually learn from it.

 

I believe this to be a very positive and important quality, that you don't see too often with aspiring programmers. I also feel that he'll contribute some fantastic content to the community in the near future.

 

I'm torn between yes & no on this application. I'd have to agree with @Assume in that I would've liked to see something more complex and involved. Not necessarily just in script concept, but also in design that shows a more intimate relationship with Java.

 

With that said, I also know his knowledge is right on the cusp, if not already enough, to be a competent script writer.

 

I will omit my vote due to the above reasons, but leave this post with the hope that this feedback assists with the process.

  • Like 1

Share this post


Link to post
Share on other sites

I've been talking to @Sphiinx since he started learning Java (which was the beginning of july, 2015).

A lot I have to say about him is already mentioned by @Final_Calibur and @warfront1, so I'll keep it short about him as a very motivated person.

 

Let's talk code-wise:

 

I must say that what you are able to produce in 6 months of learning is pretty good. You use nice structuring of code and put dependancies where they should be.

What I also like, and I mention this at almost every application I review, is that you use proper checking of booleans returned by functions.

There are some tips and tricks you should use as @Usa mentioned (like using Filters, etc.). So checking the API documentation once in a while for things like this might help.

 

I therefore have to agree with @Assume that the complexity of the scripts you wrote is not that high. I don't think this should matter that much since you showed that you are capable of writing a decent AIO script, so I'm very interested in what you might think of when you apply for Premium Scripter.

Another thing (which is not mandatory tho) is that none of your scripts have ABCL10 implemented, which is not really that hard and would prevent a lot of bans for community-members that use your scripts. So this is something you might wanna implement in your scripts.

 

Conclusion:

I think you are a very motivated person in general and you have learned a lot the past 6 months. Your code looks decent and I will therefore vote yes, on condition that you will keep the feedback from us in mind and use it in your current/future scripts.

  • Like 1

Share this post


Link to post
Share on other sites

It's actually a requirement to have at least one script that implements ABCL10.

My bad.

"At least 1 of the Scripts must demonstrate full ABCL10 implementation."

Thought I read in another application that it was not mandatory.

 

Edit: Seems like his scripts do have ABCL10 implemented.

It just seemed like it didn't, because the only if-statement used in combination with ABC, was for run-energy.

 

A yes from me.

Edited by xCode
  • Like 1

Share this post


Link to post
Share on other sites


 

SPX AIO Cooker

DepositItems / WithdrawItems

Not necessary to have two classes with the same functions, you have redundant code. Maybe move them to a Banking Class where the node is validated on,

 

return Inventory.getCount(vars.foodId) <= 0;

CookFoodOnFire / CookFoodOnStove WalkToFire / WalkToStove

Same here, redundant code.

 

Use an Enum of Type CookingObject for Fire(String name) / Stove(String name) and call your methods on those types.

 


 

SPXAIOPlanker

DepositItems / WithdrawItems

Same here, redundant code just use a class Bank within your framework.

 


 

SPXCowKiller

        RSNPC[] cows = NPCs.findNearest("Cow");        for (final RSNPC cow : cows) {            if (!cow.isInCombat()) {

Instead of looping through each cow, use a filter and use that array of RSNPC.

	private RSNPC[] getCows() {		return NPCs.findNearest(new Filter<RSNPC>() {			public boolean accept(RSNPC npc) {				String name = npc.getName();				if (name == null || !name.equalsIgnoreCase("Cow"))					return false;				return !npc.isInCombat();			}		});			}


 

Overall not too bad, limited use of ABCL but nothing looked too out of order.

 

I will omit my vote for this application pending comments from the Scripters.

The code is not pointlessly redundant. In fact it's quite the opposite. Creating methods that do a lot of things at once is not correct and will confuse people. Imagine that Sphiinx is writing the banking API for other people to use and someone sees the method called "openBank()". They think "awesome, my character will open the bank when I call this method", but then they test it out and see that the openBank() method also deposits items. They would be incredibly confused because it doesn't make sense for that method to do both of those things.

 

On top of that, creating different nodes for each thing related to banking like depositing, opening the bank, closing it etc gives you the most control possible.

edit: I might have mis-read what you were saying, I didn't realize you were talking about methods that do the same thing in multiple places.

 

I vote yes. While you have a good amount to improve on, it is clear that you have a growing grasp on the TRiBot api and I see some things in your code that I wouldn't expect novice/beginner scripters to know how to do like accessing the script manifest.

Edited by Starfox
  • Like 1

Share this post


Link to post
Share on other sites

Adding on to the positive comments, I still remember in the early days when you were trying to learn to script. I used to help you out a bit cos I knew you was interested in learning. I believe you will do your best to fulfil your duties as a scripter and both parties, tribot and yourself, would benefit from you being a scripter so its a yes from me :).

 

You've still got a long way to go so keep it up. 

  • Like 2

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

  • Our picks

    • Hello everyone,

      Last week we tried to roll out Auth0 Login, but we lost that battle. Now it's time to win the war!

      Important changes

      When logging into the client, you'll now have to enter your Auth0 account credentials instead of your forums credentials

      Note: 2FA is still handled through your forums account (for the time being)



      Changes for existing users

      You'll have to link your Auth0 account to your forums account here: https://tribot.org/forums/settings/login/?service=11


      Auth0 accounts have been created for most existing users. Please use your forums email address and password to login.



      Important notes

      Make sure to verify your email address upon creating a new Auth0 account


      When we mention your Auth0 account, we mean your account used for auth.tribot.org as displayed below
      • 43 replies
    • To better support the upcoming changes (TRiBot X, new repository), we're switching our login handler to Auth0. Instead of logging in with the standard form, you'll now be required to login through our Auth0 application.

      All existing accounts which have been used within approximately the past year have been imported into Auth0 using the same email and password combination which has been stored on the forums.

      What does this mean for users?

      Your account credentials are now even more securely stored


      You'll be able to login via Facebook, Google, and others in the future


      Is there anything users have to do differently now?

      Existing users: You'll have to login with the standard login, open your Account Settings, then link your Auth0 account


      New users: You'll be redirected to our Auth0 app (auth.tribot.org) where you'll be able to create an account


      Why was this change made?

      The new apps we are creating (such as the new repository) aren't able to use the forums to handle user logins


      To centralize all user accounts in one area


      To ensure that the client login doesn't go down when the forums are having problems


      To speed up our development


      Other considerations

      There's no documentation or official support for using Invision Community combined with Auth0, so there are still a few kinks we're working out


      We're in the works of creating an account management panel specifically for Auth0 accounts (ETA August)


      It's not possible to change email addresses for the time being (this will be resolved this August)


      Changing passwords is a weird process for the time being. To change your password, you'll have to use the "Don't remember your password" tool on the Auth0 login page
      • 10 replies
    • Over the past month, we've been working hard on TRiBot's new repository - a much needed update. This change has been deemed necessary for TRiBot X, and will allow us to really speed up development of all aspects of TRiBot.

      Today we are going to share what we've been working on!


      Now you must be wondering what kind of features the new repository will have.... well, you'll have to be patient for a little while longer. We're still figuring out various technical aspects so we can't provide answers to all possible questions. We're also focusing on development rather than writing about it so that everyone can get access to our latest developments at lightning speed. I will however answer a few users' questions.

      We're planning on a release of this early to mid August, giving users some goodies before TRiBot X's release.

      Thank you all for being patient. I hope everyone is excited as much as I am!
      • 17 replies
    • Over the past few months, I’ve been working diligently on a new project - TRiBot X. Everything has been written from the ground up, with all of the best practices of software engineering. Every aspect of TRiBot has been re-imagined to support three main goals: flexibility, useability, and reliability.
      • 50 replies
    • Come give us feedback on the next version of TRiBot!
      • 86 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...