Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Genka

Genkas script writer application

  

5 members have voted

You do not have permission to vote in this poll, or see the poll results. Please sign in or register to vote in this poll.

Recommended Posts

1) Snipplets: [sOURCE] (Link to thread) NONE that are not in dump

2) Tutorials: [sOURCE] (Link to thread) NONE that are not in dump

3) Randoms/updates submitted: [sOURCE] (Link to thread) NONE that are not in dump

4) Scripts available to the public: [sOURCE] (Link to thread)
 
Ardy cake stealer : Thread - Source (Really old one)
GMasterFarmer : Thread - Source
GFireCrafter : Thread - Source

GEnchant : Thread - Source

 

OLD flax spinner with progressive 1-10 leveling, antiban, clan chat support, deathwalk and mule support

http://pastebin.com/wPuhuae2

 

5) Short biography / Coding Experience: [1-2 short paragraphs]

 

I am 23 years old guy from Estonia who has been involved with runescape since the age of 13. I've been botting since 2010.

When oldschool Runescape came out, I found Tribot community and since there were'nt many scripts at the beginning I started learning how to write my own. I remember making my own abyss runecrafter when USA's abyss crafter was the only player in town :P Since then I have written many private scripts for myself and others. Now I see that my scripting skills would be so much more helpful to the community than to myself.

6) Reasons why you feel you deserve Scripter: [1-3 short paragraphs]

 

I have been in this community for 3 years now and i'm familiar with botting scene. I can write scripts that will do the job and I am very eager to learn. In the approved section I see only 2 new application from this year. The community needs new blood and I am up for the task of providing new and useful scripts and the competition so the community won't stagnate.

7) What you plan to provide the community with: [1-3 short Paragraphs]

 

I am planning to provide community with free and premium high quality scripts. Help and support where I can, and of course fresh ideas and open mind.

8) Do you agree to continue to not only update, but provide more free, open sourced scripts to the community? [YES/NO]

YES

 

 

 

EDIT:

 

xCode: 

I know this rank takes dedication and hard work so I actually posted this application to get pointers in which areas I have to improve.

Maybe you can explain it a little bit better where you saw the mistakes and how to I can improve.

 

Encoded: I really appreciate your input and would like to get some examples especially about nullpointers. 

Edited by Genka
  • Like 3

Share this post


Link to post
Share on other sites

No. You just released these scripts in the past two weeks. Also, the quality of your code is really not at a level as a Script Writer should be.

You often do not check if certain actions succeeded, nor do you use multiple classes to make your code easier maintainable and easier to read.

What you provided us will just not suffice for a Scripter rank in my opinion. Goodluck on further improving :)

Share this post


Link to post
Share on other sites

I've glanced at your code a couple times since you've posted this and I see many potential NullPointerExceptions. I also notice an irregular use of access modifiers for your variables.
I'll expand more on this post later tonight when I have time to go a bit more in depth. Having multiple classes is not required, but it greatly increases readability and maintainability.

 

ArdyCakeStealer:

Line 65 and 66: The RSTile objects should be saved as constants instead of creating new RSTile objects each time the statements are executed.

Line 90: Game.getUptext() can return null, I would suggest using Game.isUptext("Steal-from").

Line 94: getDefinition() can return null as well as getName().

According to the docs, Player.getRSPlayer() can return null. Personally, I would create a Player07 wrapper class that null checks for you.

 

GMasterFarmer:

You have access modifiers on some of the variables at the top of the script, but not all. Try to at least be consistent, but I would say as a general rule, make private whatever can be private.

For your GUI, use SwingUtilities.invokeAndWait(..) as you currently aren't creating your GUI on the Event Dispatch Thread.

Line 184: Use Inventory.getCount(..) rather than Inventory.find(..).length. The same goes for any other usages in the script where you length check for count.

 

GFireCrafter:

Line 86, 87, and 88: Inefficient. Use the getCount method as mentioned above instead of length checking on line 86. Ideally the only time you want to length check for count is when you use Inventory.getAll().length to see if you have items in your inventory or not since there is no Inventory.isEmpty() method. Also unfortunately there is no getCount method in the Banking class.

Line 202: Instead of returning a String in your getLocation method, use enums. Also in Java, == is comparing two objects' references, not the values of the objects. When comparing equality between two String objects you should be using the equals method.

 

GEnchant:

Same points as mentioned above.

Line 61, 62, and 63: I can't even...

Line 66: No length check.

 

 

Lots of methods you are using return a value of some sort based on success/failure and you rarely, if at all, make any use of that. Also look into conditional sleeps.

Turns out the potential null pointer exceptions were just in that first script.

I think you would also benefit in having a better script structure because these scripts feel a bit messy.

Edited by Encoded
  • Like 2

Share this post


Link to post
Share on other sites

Thanks for your contributions and desire to join the Scripters but it appears that you still have some more development to do before you are ready to join the ranks.

 

Take Encoded's comments above and post in the Scripting Help section for programming related questions where we will help you.

 

Closed.

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

  • Our picks

    • Today marks a big day for TRiBot! To make it easier for users to use TRiBot, we've created installers available for every platform! These installers are all bundled with the latest version of OpenJDK 1.8 (Java 😎, which is LG compatible.

      Using TRiBot is now easy. Simply download the installer for your platform, install TRiBot, and run it. The TRiBot Loader will correctly identify the bundled JDK so there's no need to change the Java selection.

      Windows

      EXE installer: TRiBot-windows-x64-4.0.3.exe


      MSI installer: TRiBot-windows-x64-4.0.3.msi


      Portable version: TRiBot-windows-x64-4.0.3.zip


      Mac OS

      Installer: TRiBot-macos-4.0.3.dmg


      Portable version: TRiBot-macos-4.0.3.tgz


      Unix/Linux

      Installer: TRiBot-unix-4.0.3.sh


      RPM installer (CentOS/Fedora): TRiBot-linux-4.0.3.rpm


      DEB installer (Debian): TRiBot-linux-4.0.3.deb


      Portable version: TRiBot-unix-4.0.3.tar.gz


      Platform Independent

      JAR file: tribot-loader-4.0.3.jar


      Note that this jar file does not include the bundled JDK.



      Windows and Mac OS users may notice a warning message stating that the installer/application is un-recognized or un-trusted. Please ignore this message and proceed with running the installer/application. We need to acquire a code signing certificate so that we can sign the installers letting the operating system know that these files can be trusted. It will take a week or more to acquire one, so please hold tight.

      Other notable changes to the TRiBot Loader:

      Support getting the version from OpenJDK distributions


      Add check for bundled JDK


      Copy OpenJDK tools.jar to the bundled JDK if not present


      Set the current java as the first available list entry


      Ignore Java versions which are symbolic links


      Make the bundled JDK the preferred Java version


      Update icon images


      Reduce the number of HTTP calls
        • Like
      • 11 replies
    • TRiBot is looking to improve a lot of its customer relationship management, customer on boarding process, customer experience, design elements, community engagement and pretty much everything else you can imagine when it comes to marketing.

      Our goal: To ensure that the marketing done TRULY reflects the experience and does not shine an inaccurate light on what TRiBot is lacking in.

      So I ask, what do you love about TRiBot and what do you hate about TRiBot? What does O S Bot, Rune M8, PowR Bot and Dre amBot do better? (yes I purposely didn't spell it right 😂).

      Love, 

      RileyZ
        • Like
      • 7 replies
    • Hello TRiBot,

      Today we have a significant release that has been in the works for the last month addressing several key issues, features and bugs in the backlog.

      With these changes, we are also including a new TRiBot Loader which will allow you to select any version that is released. This adds the flexibility of allowing you to revert to a previous version should an issue arise, run development only builds, view an accurate change log between versions etc. we are very proud to offer this feature and think it will add a lot more functionality down the road as we continue to release new versions.

      These changes include 80+ commits by our development team, a list of them is summarized below and also available for your viewing pleasure in the new TRiBot Loader.

      In addition, we have taken additional steps to improve as a development team by adding continuous integration and deployment into our workflow to assist in delivering timely releases such as bug fixes as well as new features on a weekly basis depending on our development cycle.
        • Thanks
        • Like
      • 39 replies
    • Over the last three weeks, I've been working on upgrading our server infrastructure. It's finally ready and is now live!

      Why?

      Increased reliability - less server errors


      Increased availability - less downtime


      Increased security - keeping us and you secure


      Increased capacity - ability to serve you better


      Increased speed - less waiting for things to load


      Faster development - server and service updates will come faster


      What are the changes?

      Move from a single AWS EC2 instance to AWS ECS (Elastic Container Service)


      Distributed computing


      Load balancing


      Git management of server files and filesystem


      Redis caching


      How?

      AWS ECS (with 10 EC2 instances)


      AWS ElastiCache (Redis)


      AWS Load Balancing


      AWS EFS (Elastic file system)


      Please bare with us as I continue to tune the server for maximum performance. Slow loading speeds may occur temporarily. I thank everyone for their patience.

      Please post on this thread if you experience any issues other than slow loading times.
        • Like
      • 51 replies
    • This update features:

      Fixed broken hooks from today's update


      Fix wilderness level with RuneLite (Thanks @Todd)


      Add support for Kotlin .class files in scripts (Thanks @wastedbro)


      Overhaul Inventory API (Thanks @wastedbro)


      Add List support for common methods


      Change method grouping to make more sense (by functionality)


      Refactor methods to utilize Java 8 streams instead of cumbersome loops




      Recognize chatbox minimization (Thanks @JoeDezzy1)


      Fix Screen#isInViewport when NPC chat is open (Thanks @JoeDezzy1)


      Fix login bot bugs (Thanks @erickho123)


      Fix hint arrow return values (Thanks @Encoded)


      Fix depositAllExcept functionality (Thanks @wastedbro)


      Change containing box interface bound and adjust for Y values (Thanks @erickho123)
        • Like
      • 151 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...