Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Buy OSRS Gold

Sell OSRS Gold
Sign in to follow this  
ITryNotToTroll

ITryNotToTroll's Scripter Application

  

4 members have voted

You do not have permission to vote in this poll, or see the poll results. Please sign in or register to vote in this poll.

Recommended Posts

Yup, it's me again.

 

Last application (The "New Source" for the smelter was added after)

 

Snippets

 

Scripts

Bio

 

I'll try not to let this drag on too much. I started programming back in 2013, for tribot. It was the first time that I really started to delve into code, but honestly, until recently I didn't really do much programming. I've been kind of muddling around for a long while, but now I seriously want to start learning. I believe that my skills have improved quite a lot since back then (I actually found my first smelter, which you can find here if you're at all interested) since completing projects such as a small platformed and I'm currently in the process of completing a minesweeper bot, which I know isn't that complicated but I enjoy it.

 

About tribot specifically, I believe I have starting writing scripts that are a lot better laid out and a lot, well, less crap then the ones I created before. I enjoy creating scripts for people to use, and I believe that lately my scripts have been better and easier for people to use. What I want to do now is get even better, hopefully to a much higher level in the coming months and years as I learn more.

 

About the community aspect, I'm fairly sure none of you should see that as an issue, I have tribot up on a monitor constantly and post frequently helping people out with various things.

 

Why I believe I should be a scripter

 

Because I want to help people out, and want to learn more. I believe that both of these would be easier to achieve while being a scripter, due to people being more willing to use my scripts and give feedback if they see that logo and being more involved with the other scripters in the community. I've been on tribot for a long while now and hope to give more back.

 

What I plan on providing the community with

 

Good, solid and useful scripts in all areas. Support with issues, and answers for questions.

 

Do I agree to not only update, but provide more free scripts to the community?

 

Of course 

 

 

 

 

A request for scripters reviewing this

 

Can you please leave feedback on your opinions? If you find something wrong with my code, or something I can improve upon, can you please tell me what is wrong rather than just linking a large thread, or saying "No". Thank you!

 

 

Responses:

 

XCode:

 

Thank you! I actually didn't realise the first thing. I added the second section after because I noticed that sometimes the bank would not be loaded in time, so the script would falsely assume the bank was completely empty. I didn't notice that I could just put them together.

 

Second point: I've never though of it like that, will be implementing that from now on.

 

Third point: I do believe that I check most of the time, but I will adapt and do it more now :)

 

Todd:

 

Sorry about that, I actually stole some of the code from another script (Tuna Potatoes) which has the items you combine change. I will start to update that now.

 

Is it better to keep code more flat? Is there any advantage to it or is it just better practice in order to make scripts more efficient? Should I use multiple method to help achieve this?

 

Is there any chance you could link this to me? All I remember is adding a sleep to help reduce CPU usage, but from now on I will increase it to that amount.

 


 

Updated code a little for @xCode and @Todd, any better?

 


 

Updated code 7:12pm GMT 20/8/15, please have a quick check through if you are judging based on previous code

Edited by ITryNotToTroll
  • Like 10

Share this post


Link to post
Share on other sites

Things I notice:

if(Timing.waitCondition(new Condition() {				@Override				public boolean active() {					General.sleep(20, 30);					return Inventory.getAll().length <= 3;				}			}, General.random(1000, 1500))) {				Timing.waitCondition(new Condition() {					@Override					public boolean active() {						General.sleep(20, 30);						return Banking.getAll().length > 0;					}				}, General.random(2000, 300));
BankHandler.java: You have a waitCondition right after another waitCondition which returns true if the one before that return true. Why would you do this? The second one is unnecessary.

 

if(leather.length > 0 && leather[0] != null) {        if(leather[0].getStack() <= 5) 		Variables.running = false;} else	Variables.running = false;
Could be shorter:

Variables.running = leather.length > 0 && leather[0].getStack() > 5;
Banking.withdraw(0, Variables.leather.getID());				Timing.waitCondition(new Condition() {					@Override					public boolean active() {						General.sleep(20, 30);						return Inventory.isFull();					}				}, General.random(1000, 1500));
You may want to check if you have successfully clicked withdraw, so surround the Banking.withdraw with an if-statement before waiting.

 

I've seen more examples like these where you sleep after an action, without checking if the action was successful.

 

- -

 

Based on what I've seen I think you would be able to hold the scripter rank. Just make sure to check for some things like I mentioned above. If you could apply that to your scripts, it's a yes from me.

Share this post


Link to post
Share on other sites

I don't actually have a vote, but just some things I noticed from the wine script.

 

Also this line of code obviously needs to be fixed

RSItem[] one = Banking.find(Variables.itemOne);RSItem[] two = Banking.find(Variables.itemOne);

Some of your variables are not variables at all. Maybe have a Constants class instead.

 

Try to keep your code as flat as possible, sometimes you have code 7 indents deep. That's way to much for a simple bank handler class, no reason to ever put 3 timing.waitconditions inside of each other.

"General.sleep(20, 30);" 

Trilez wrote about this somewhere in his scripting guide, there is no reason to check this often in your wait conditions, average human reaction is around 200-500 ms.

Share this post


Link to post
Share on other sites

Not going to look through every script thoroughly since I've reviewed your code last time. I see improvements from the last time which is all I'm looking for. I would suggest moving the anonymous inner classes into a separate method to make the code more compact and readable.

 

You're an active and dedicated member of Tribot who provides the support for people in need. It's a yes from me.

  • Like 2

Share this post


Link to post
Share on other sites

I'm going to vote yes as well because you've been at this community for a very long time, but your code definitely could be improved. xCode touched a little bit with them, please take them into consideration. I might go back and evaluate your code.

 

Scripts don't have to be perfect clean or as efficient as it should be to work, and you have provided these scripts for the community to use.

  • Like 1

Share this post


Link to post
Share on other sites

There are still some issues with your code, but as pointed out already this isn't the level of mastery we expect at the Scripter level and we are all still learning. You've shown a great amount of support and dedication to TRiBot and I believe you will make a good addition to the Scripter group.

 

Approved.

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.
Sign in to follow this  

  • Our picks

    • Hello everyone,

      Last week we tried to roll out Auth0 Login, but we lost that battle. Now it's time to win the war!

      Important changes

      When logging into the client, you'll now have to enter your Auth0 account credentials instead of your forums credentials

      Note: 2FA is still handled through your forums account (for the time being)



      Changes for existing users

      You'll have to link your Auth0 account to your forums account here: https://tribot.org/forums/settings/login/?service=11


      Auth0 accounts have been created for most existing users. Please use your forums email address and password to login.



      Important notes

      Make sure to verify your email address upon creating a new Auth0 account


      When we mention your Auth0 account, we mean your account used for auth.tribot.org as displayed below
      • 43 replies
    • To better support the upcoming changes (TRiBot X, new repository), we're switching our login handler to Auth0. Instead of logging in with the standard form, you'll now be required to login through our Auth0 application.

      All existing accounts which have been used within approximately the past year have been imported into Auth0 using the same email and password combination which has been stored on the forums.

      What does this mean for users?

      Your account credentials are now even more securely stored


      You'll be able to login via Facebook, Google, and others in the future


      Is there anything users have to do differently now?

      Existing users: You'll have to login with the standard login, open your Account Settings, then link your Auth0 account


      New users: You'll be redirected to our Auth0 app (auth.tribot.org) where you'll be able to create an account


      Why was this change made?

      The new apps we are creating (such as the new repository) aren't able to use the forums to handle user logins


      To centralize all user accounts in one area


      To ensure that the client login doesn't go down when the forums are having problems


      To speed up our development


      Other considerations

      There's no documentation or official support for using Invision Community combined with Auth0, so there are still a few kinks we're working out


      We're in the works of creating an account management panel specifically for Auth0 accounts (ETA August)


      It's not possible to change email addresses for the time being (this will be resolved this August)


      Changing passwords is a weird process for the time being. To change your password, you'll have to use the "Don't remember your password" tool on the Auth0 login page
        • Haha
      • 10 replies
    • Over the past month, we've been working hard on TRiBot's new repository - a much needed update. This change has been deemed necessary for TRiBot X, and will allow us to really speed up development of all aspects of TRiBot.

      Today we are going to share what we've been working on!


      Now you must be wondering what kind of features the new repository will have.... well, you'll have to be patient for a little while longer. We're still figuring out various technical aspects so we can't provide answers to all possible questions. We're also focusing on development rather than writing about it so that everyone can get access to our latest developments at lightning speed. I will however answer a few users' questions.

      We're planning on a release of this early to mid August, giving users some goodies before TRiBot X's release.

      Thank you all for being patient. I hope everyone is excited as much as I am!
      • 17 replies
    • Over the past few months, I’ve been working diligently on a new project - TRiBot X. Everything has been written from the ground up, with all of the best practices of software engineering. Every aspect of TRiBot has been re-imagined to support three main goals: flexibility, useability, and reliability.
        • Like
      • 50 replies
    • Come give us feedback on the next version of TRiBot!
      • 86 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...