Jump to content
WillB

WillB's scripter application

  

5 members have voted

  1. 1. Does WillB deserve the Scripter rank?

    • Yes
      3
    • No
      2


Recommended Posts

WillB    72

WillB Scripter Application

 

Snippets:

Get Item Name Via ID: http://pastebin.com/Vvpaxwpu https://tribot.org/forums/topic/36901-snippet-get-item-name-via-id/ (outdated)

 

Tutorial: N/A

 

Randoms / Updates: N/A

 

Scripts:
           wbChickenKiller: 
https://tribot.org/forums/topic/36871-abcl-10-wbchickenkiller/?p=445473                 

 

           wbTanner:    https://tribot.org/forums/topic/49807-willbs-hide-tanner-al-kharid/                   

 

           wbClayMiner:  https://tribot.org/forums/topic/49841-wbclayminer-mines-clay-at-varrock/

 

           wbBlastFurnace:  https://tribot.org/forums/topic/38979-blast-furnace-wbblastfurnace-300k-profithr-low-requirements/ (Still in development)

 

                 All script sources can be found at: https://www.mediafire.com/folder/o38cj7d3hltw1//Scripts

 

Short biography / coding experience:

                 I have been programming on/off for a few years now, when I first started out I felt like I was copying and pasting more than I was actually programming my self, but have come extremely far from them. In the past year or so, I have mostly been into Game Development in the Unity Engine using C# and UE4 more recently. I have mostly been programming in java for TRiBot and a few other small projects I have been working on.

 

Reasons why you feel you deserve Scripter:

                 I feel I deserve Scripter because I enjoy programming, and now I have the time, I am able to keep my scripts updated.
I have tried my best to make sure that my scripts work as well as they can, although this can be hard with people not posting bug reports.

               

What you plan to provide the community with:

                 I plan to provide the community with plenty of free scripts, as well as any useful snippets I have and I may release some tutorials in the future. I will try my best to help people where I can.

 

Do you agree to continue to not only update, but provide more free, open sourced scripts to the community?

                 Yes.

 

@AlphaDog It's about a year old and I haven't checked it since then, I wasn't even going to include it on the application. That was something I hadn't realized at the time. But if you see here: https://tribot.org/forums/topic/37220-ultimate-zybez-api-tool/ and here: http://pastebin.com/EFfT6cE6 someone had a use for it.

 

@Zainy I do have other scripts, one is outdated (being updated) and the other I am currently developing the latest version. One is a Blast Furnace script and the other is a Rock crab killer. I figured It'd be better to apply with completed scripts than non completed ones.

 

@Assume That's understandable I have also included the source to my Blast Furnace script which is no where near complete and needs a lot of tidying up to do, buy hopefully it's a bit more advanced. https://www.mediafire.com/folder/o38cj7d3hltw1//Scripts

 

@daxmagex Thanks, I will keep that all in mind :P

 

 

@Usa

Edited by WillB
  • Like 1

Share this post


Link to post
Share on other sites
Zainy    234
 

 

What about

RSItemDefinition itemDef = RSItemDefinition.get(id);
if (itemDef != null) {
String name = itemDef.getName();
}

 

He does have 'outdated' written next to it :P

I'm not sure if your 3 scripts contribute enough. There many chicken killers out there; there are many tanners out there; and i'm pretty sure its the same with clay mining too. I'm gonna see what others think before I make further comments

Share this post


Link to post
Share on other sites
daxmagex    907

Since no one commented on the actual code, here's my input.

 

373ed631a4.png

 

Your null checking is wrong. The value of NPCChat.getOptions()  varies so you can't assume method() == method(). You are missing a cache to hold the values to null check. The documentation states that getOptions may return null, so you need to null and length check it. This block can also be replaced with a switch statement for readability. Y

 

Some of your wait conditions are missing sleeps.

 

 

cee424fe7a.png

 

Same issues as the code above. Also, your buryBones method buries one bone.  Also there is a bit of logic issue here. The condition cancels the sleep out. It will always wait until you are idle, unless you are accounting for the Rune Scape delay before your animation changes which in that case the sleep is too short.

 

 

81128679f4.png

 

Some of your if statements are empty. If you don't care bout the return value, simply call the method.

 

2f754b76d8.png

 

3a3d4cc3e1.png

 

Another logic issue.

 

Since you are constantly looping through the script, your hover next value will constantly be reset, rendering the ABC feature useless. Also you are missing a null check. The condition here is redundant.

 

f8c0297aaf.png

 

Nothing will be done if the rock is not on screen. The timeout is also too short.

  • Like 2

Share this post


Link to post
Share on other sites
Usa    1,368

Potential is definitely there but as listed above there are several fundamental issues with the sources you posted. I was on the fence and the votes are not conclusive, I would take those suggestions into consideration and revamp those portions and apply again at a later date where we can all agree on adding you to the Scripter ranks, thanks for applying @WillB.

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

  • Recently Browsing   0 members

    No registered users viewing this page.

×