Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
WillB

WillB's scripter application

  

5 members have voted

You do not have permission to vote in this poll, or see the poll results. Please sign in or register to vote in this poll.

Recommended Posts

WillB Scripter Application

 

Snippets:

Get Item Name Via ID: http://pastebin.com/Vvpaxwpu https://tribot.org/forums/topic/36901-snippet-get-item-name-via-id/ (outdated)

 

Tutorial: N/A

 

Randoms / Updates: N/A

 

Scripts:
           wbChickenKiller: 
https://tribot.org/forums/topic/36871-abcl-10-wbchickenkiller/?p=445473                 

 

           wbTanner:    https://tribot.org/forums/topic/49807-willbs-hide-tanner-al-kharid/                   

 

           wbClayMiner:  https://tribot.org/forums/topic/49841-wbclayminer-mines-clay-at-varrock/

 

           wbBlastFurnace:  https://tribot.org/forums/topic/38979-blast-furnace-wbblastfurnace-300k-profithr-low-requirements/ (Still in development)

 

                 All script sources can be found at: https://www.mediafire.com/folder/o38cj7d3hltw1//Scripts

 

Short biography / coding experience:

                 I have been programming on/off for a few years now, when I first started out I felt like I was copying and pasting more than I was actually programming my self, but have come extremely far from them. In the past year or so, I have mostly been into Game Development in the Unity Engine using C# and UE4 more recently. I have mostly been programming in java for TRiBot and a few other small projects I have been working on.

 

Reasons why you feel you deserve Scripter:

                 I feel I deserve Scripter because I enjoy programming, and now I have the time, I am able to keep my scripts updated.
I have tried my best to make sure that my scripts work as well as they can, although this can be hard with people not posting bug reports.

               

What you plan to provide the community with:

                 I plan to provide the community with plenty of free scripts, as well as any useful snippets I have and I may release some tutorials in the future. I will try my best to help people where I can.

 

Do you agree to continue to not only update, but provide more free, open sourced scripts to the community?

                 Yes.

 

@AlphaDog It's about a year old and I haven't checked it since then, I wasn't even going to include it on the application. That was something I hadn't realized at the time. But if you see here: https://tribot.org/forums/topic/37220-ultimate-zybez-api-tool/ and here: http://pastebin.com/EFfT6cE6 someone had a use for it.

 

@Zainy I do have other scripts, one is outdated (being updated) and the other I am currently developing the latest version. One is a Blast Furnace script and the other is a Rock crab killer. I figured It'd be better to apply with completed scripts than non completed ones.

 

@Assume That's understandable I have also included the source to my Blast Furnace script which is no where near complete and needs a lot of tidying up to do, buy hopefully it's a bit more advanced. https://www.mediafire.com/folder/o38cj7d3hltw1//Scripts

 

@daxmagex Thanks, I will keep that all in mind :P

 

 

@Usa

Edited by WillB
  • Like 1

Share this post


Link to post
Share on other sites
 

 

What about

RSItemDefinition itemDef = RSItemDefinition.get(id);
if (itemDef != null) {
String name = itemDef.getName();
}

 

He does have 'outdated' written next to it :P

I'm not sure if your 3 scripts contribute enough. There many chicken killers out there; there are many tanners out there; and i'm pretty sure its the same with clay mining too. I'm gonna see what others think before I make further comments

Share this post


Link to post
Share on other sites

Since no one commented on the actual code, here's my input.

 

373ed631a4.png

 

Your null checking is wrong. The value of NPCChat.getOptions()  varies so you can't assume method() == method(). You are missing a cache to hold the values to null check. The documentation states that getOptions may return null, so you need to null and length check it. This block can also be replaced with a switch statement for readability. Y

 

Some of your wait conditions are missing sleeps.

 

 

cee424fe7a.png

 

Same issues as the code above. Also, your buryBones method buries one bone.  Also there is a bit of logic issue here. The condition cancels the sleep out. It will always wait until you are idle, unless you are accounting for the Rune Scape delay before your animation changes which in that case the sleep is too short.

 

 

81128679f4.png

 

Some of your if statements are empty. If you don't care bout the return value, simply call the method.

 

2f754b76d8.png

 

3a3d4cc3e1.png

 

Another logic issue.

 

Since you are constantly looping through the script, your hover next value will constantly be reset, rendering the ABC feature useless. Also you are missing a null check. The condition here is redundant.

 

f8c0297aaf.png

 

Nothing will be done if the rock is not on screen. The timeout is also too short.

  • Like 2

Share this post


Link to post
Share on other sites

Potential is definitely there but as listed above there are several fundamental issues with the sources you posted. I was on the fence and the votes are not conclusive, I would take those suggestions into consideration and revamp those portions and apply again at a later date where we can all agree on adding you to the Scripter ranks, thanks for applying @WillB.

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

  • Our picks

    • Today marks a big day for TRiBot! To make it easier for users to use TRiBot, we've created installers available for every platform! These installers are all bundled with the latest version of OpenJDK 1.8 (Java 😎, which is LG compatible.

      Using TRiBot is now easy. Simply download the installer for your platform, install TRiBot, and run it. The TRiBot Loader will correctly identify the bundled JDK so there's no need to change the Java selection.

      Windows

      EXE installer: TRiBot-windows-x64-4.0.3.exe


      MSI installer: TRiBot-windows-x64-4.0.3.msi


      Portable version: TRiBot-windows-x64-4.0.3.zip


      Mac OS

      Installer: TRiBot-macos-4.0.3.dmg


      Portable version: TRiBot-macos-4.0.3.tgz


      Unix/Linux

      Installer: TRiBot-unix-4.0.3.sh


      RPM installer (CentOS/Fedora): TRiBot-linux-4.0.3.rpm


      DEB installer (Debian): TRiBot-linux-4.0.3.deb


      Portable version: TRiBot-unix-4.0.3.tar.gz


      Platform Independent

      JAR file: tribot-loader-4.0.3.jar


      Note that this jar file does not include the bundled JDK.



      Windows and Mac OS users may notice a warning message stating that the installer/application is un-recognized or un-trusted. Please ignore this message and proceed with running the installer/application. We need to acquire a code signing certificate so that we can sign the installers letting the operating system know that these files can be trusted. It will take a week or more to acquire one, so please hold tight.

      Other notable changes to the TRiBot Loader:

      Support getting the version from OpenJDK distributions


      Add check for bundled JDK


      Copy OpenJDK tools.jar to the bundled JDK if not present


      Set the current java as the first available list entry


      Ignore Java versions which are symbolic links


      Make the bundled JDK the preferred Java version


      Update icon images


      Reduce the number of HTTP calls
        • Like
      • 11 replies
    • TRiBot is looking to improve a lot of its customer relationship management, customer on boarding process, customer experience, design elements, community engagement and pretty much everything else you can imagine when it comes to marketing.

      Our goal: To ensure that the marketing done TRULY reflects the experience and does not shine an inaccurate light on what TRiBot is lacking in.

      So I ask, what do you love about TRiBot and what do you hate about TRiBot? What does O S Bot, Rune M8, PowR Bot and Dre amBot do better? (yes I purposely didn't spell it right 😂).

      Love, 

      RileyZ
        • Like
      • 7 replies
    • Hello TRiBot,

      Today we have a significant release that has been in the works for the last month addressing several key issues, features and bugs in the backlog.

      With these changes, we are also including a new TRiBot Loader which will allow you to select any version that is released. This adds the flexibility of allowing you to revert to a previous version should an issue arise, run development only builds, view an accurate change log between versions etc. we are very proud to offer this feature and think it will add a lot more functionality down the road as we continue to release new versions.

      These changes include 80+ commits by our development team, a list of them is summarized below and also available for your viewing pleasure in the new TRiBot Loader.

      In addition, we have taken additional steps to improve as a development team by adding continuous integration and deployment into our workflow to assist in delivering timely releases such as bug fixes as well as new features on a weekly basis depending on our development cycle.
        • Thanks
        • Like
      • 39 replies
    • Over the last three weeks, I've been working on upgrading our server infrastructure. It's finally ready and is now live!

      Why?

      Increased reliability - less server errors


      Increased availability - less downtime


      Increased security - keeping us and you secure


      Increased capacity - ability to serve you better


      Increased speed - less waiting for things to load


      Faster development - server and service updates will come faster


      What are the changes?

      Move from a single AWS EC2 instance to AWS ECS (Elastic Container Service)


      Distributed computing


      Load balancing


      Git management of server files and filesystem


      Redis caching


      How?

      AWS ECS (with 10 EC2 instances)


      AWS ElastiCache (Redis)


      AWS Load Balancing


      AWS EFS (Elastic file system)


      Please bare with us as I continue to tune the server for maximum performance. Slow loading speeds may occur temporarily. I thank everyone for their patience.

      Please post on this thread if you experience any issues other than slow loading times.
        • Like
      • 51 replies
    • This update features:

      Fixed broken hooks from today's update


      Fix wilderness level with RuneLite (Thanks @Todd)


      Add support for Kotlin .class files in scripts (Thanks @wastedbro)


      Overhaul Inventory API (Thanks @wastedbro)


      Add List support for common methods


      Change method grouping to make more sense (by functionality)


      Refactor methods to utilize Java 8 streams instead of cumbersome loops




      Recognize chatbox minimization (Thanks @JoeDezzy1)


      Fix Screen#isInViewport when NPC chat is open (Thanks @JoeDezzy1)


      Fix login bot bugs (Thanks @erickho123)


      Fix hint arrow return values (Thanks @Encoded)


      Fix depositAllExcept functionality (Thanks @wastedbro)


      Change containing box interface bound and adjust for Y values (Thanks @erickho123)
        • Like
      • 151 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...