Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Sign in to follow this  
ITryNotToTroll

ITryNotToTroll Scripter Application

Recommended Posts

You seem like a good guy and being part of a community for 2 years show hella of a dedication and stability, however, scripter rank first and foremost requirment is the ability to produce clean and effective code. Having said that and looked over your code, i'm sorry to say that it is a definite NO from me.

 

Reading through your code it's obvious that you have no other coding experience other than scripting, you have not read any Trilez' scripting tutorials, you don't know the API very well.

 

  1. The horrible, horrible, horrible new line brace style..
    someMethod(){  //code here}
    This does not belong to Java. I could let this slide if you were consistent. But you have methods that use the normal ANSI style aswell.
     
  2. Suspectible null pointers and inefficient code everywhere
    if(NPCs.find("Man").length > 0 && NPCs.find("Man")[0].getPosition().distanceTo(Player.getPosition()) < 8)if(!inventoryItems[i].getDefinition().getName().contains(foodName))
  3. Multiple methods could be shortened without hurting readabilty
     

  4. You could easily extract parts of your code into methods to improve readability by over 9000. For example make method that handles all the gui stuff instead of just having 100 lines of GUI code in your run method. Even if you are the only programmer on the team keeping your code clean helps you aswell.
     
  5. Lack of dynamic sleeps and API knowledge

    tea[i].click("Drop Cup of tea");sleep(200, 300);
  6. New scripters should also do ABC10 to demontrate the ability and willingness to learn.
  7. Etc.. etc

Sorry but it's a NO.

Share this post


Link to post
Share on other sites

You seem like a good guy and being part of a community for 2 years show hella of a dedication and stability, however, scripter rank first and foremost requirment is the ability to produce clean and effective code. Having said that and looked over your code, i'm sorry to say that it is a definite NO from me.

 

Reading through your code it's obvious that you have no other coding experience other than scripting, you have not read any Trilez' scripting tutorials, you don't know the API very well.

 

  1. The horrible, horrible, horrible new line brace style..

    someMethod(){  //code here}
    This does not belong to Java. I could let this slide if you were consistent. But you have methods that use the normal ANSI style aswell.

     

  2. Suspectible null pointers and inefficient code everywhere

    if(NPCs.find("Man").length > 0 && NPCs.find("Man")[0].getPosition().distanceTo(Player.getPosition()) < 8)if(!inventoryItems[i].getDefinition().getName().contains(foodName))
  3. Multiple methods could be shortened without hurting readabilty

     

  4. You could easily extract parts of your code into methods to improve readability by over 9000. For example make method that handles all the gui stuff instead of just having 100 lines of GUI code in your run method. Even if you are the only programmer on the team keeping your code clean helps you aswell.

     

  5. Lack of dynamic sleeps and API knowledge

    tea[i].click("Drop Cup of tea");sleep(200, 300);
  6. New scripters should also do ABC10 to demontrate the ability and willingness to learn.
  7. Etc.. etc

Sorry but it's a NO.

There is no correct brace formatting, it's personal preference no matter what you think or what the majority is.

 

Anyway, @OP I think that if you studied a bit more and got a good foot-hold on object oriented programming you could apply for script again at a later time and I would vote yes.

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.
Sign in to follow this  

  • Our picks

    • Today marks a big day for TRiBot! To make it easier for users to use TRiBot, we've created installers available for every platform! These installers are all bundled with the latest version of OpenJDK 1.8 (Java 😎, which is LG compatible.

      Using TRiBot is now easy. Simply download the installer for your platform, install TRiBot, and run it. The TRiBot Loader will correctly identify the bundled JDK so there's no need to change the Java selection.

      Windows

      EXE installer: TRiBot-windows-x64-4.0.3.exe


      MSI installer: TRiBot-windows-x64-4.0.3.msi


      Portable version: TRiBot-windows-x64-4.0.3.zip


      Mac OS

      Installer: TRiBot-macos-4.0.3.dmg


      Portable version: TRiBot-macos-4.0.3.tgz


      Unix/Linux

      Installer: TRiBot-unix-4.0.3.sh


      RPM installer (CentOS/Fedora): TRiBot-linux-4.0.3.rpm


      DEB installer (Debian): TRiBot-linux-4.0.3.deb


      Portable version: TRiBot-unix-4.0.3.tar.gz


      Platform Independent

      JAR file: tribot-loader-4.0.3.jar


      Note that this jar file does not include the bundled JDK.



      Windows and Mac OS users may notice a warning message stating that the installer/application is un-recognized or un-trusted. Please ignore this message and proceed with running the installer/application. We need to acquire a code signing certificate so that we can sign the installers letting the operating system know that these files can be trusted. It will take a week or more to acquire one, so please hold tight.

      Other notable changes to the TRiBot Loader:

      Support getting the version from OpenJDK distributions


      Add check for bundled JDK


      Copy OpenJDK tools.jar to the bundled JDK if not present


      Set the current java as the first available list entry


      Ignore Java versions which are symbolic links


      Make the bundled JDK the preferred Java version


      Update icon images


      Reduce the number of HTTP calls
        • Like
      • 11 replies
    • TRiBot is looking to improve a lot of its customer relationship management, customer on boarding process, customer experience, design elements, community engagement and pretty much everything else you can imagine when it comes to marketing.

      Our goal: To ensure that the marketing done TRULY reflects the experience and does not shine an inaccurate light on what TRiBot is lacking in.

      So I ask, what do you love about TRiBot and what do you hate about TRiBot? What does O S Bot, Rune M8, PowR Bot and Dre amBot do better? (yes I purposely didn't spell it right 😂).

      Love, 

      RileyZ
        • Like
      • 7 replies
    • Hello TRiBot,

      Today we have a significant release that has been in the works for the last month addressing several key issues, features and bugs in the backlog.

      With these changes, we are also including a new TRiBot Loader which will allow you to select any version that is released. This adds the flexibility of allowing you to revert to a previous version should an issue arise, run development only builds, view an accurate change log between versions etc. we are very proud to offer this feature and think it will add a lot more functionality down the road as we continue to release new versions.

      These changes include 80+ commits by our development team, a list of them is summarized below and also available for your viewing pleasure in the new TRiBot Loader.

      In addition, we have taken additional steps to improve as a development team by adding continuous integration and deployment into our workflow to assist in delivering timely releases such as bug fixes as well as new features on a weekly basis depending on our development cycle.
        • Thanks
        • Like
      • 39 replies
    • Over the last three weeks, I've been working on upgrading our server infrastructure. It's finally ready and is now live!

      Why?

      Increased reliability - less server errors


      Increased availability - less downtime


      Increased security - keeping us and you secure


      Increased capacity - ability to serve you better


      Increased speed - less waiting for things to load


      Faster development - server and service updates will come faster


      What are the changes?

      Move from a single AWS EC2 instance to AWS ECS (Elastic Container Service)


      Distributed computing


      Load balancing


      Git management of server files and filesystem


      Redis caching


      How?

      AWS ECS (with 10 EC2 instances)


      AWS ElastiCache (Redis)


      AWS Load Balancing


      AWS EFS (Elastic file system)


      Please bare with us as I continue to tune the server for maximum performance. Slow loading speeds may occur temporarily. I thank everyone for their patience.

      Please post on this thread if you experience any issues other than slow loading times.
        • Like
      • 51 replies
    • This update features:

      Fixed broken hooks from today's update


      Fix wilderness level with RuneLite (Thanks @Todd)


      Add support for Kotlin .class files in scripts (Thanks @wastedbro)


      Overhaul Inventory API (Thanks @wastedbro)


      Add List support for common methods


      Change method grouping to make more sense (by functionality)


      Refactor methods to utilize Java 8 streams instead of cumbersome loops




      Recognize chatbox minimization (Thanks @JoeDezzy1)


      Fix Screen#isInViewport when NPC chat is open (Thanks @JoeDezzy1)


      Fix login bot bugs (Thanks @erickho123)


      Fix hint arrow return values (Thanks @Encoded)


      Fix depositAllExcept functionality (Thanks @wastedbro)


      Change containing box interface bound and adjust for Y values (Thanks @erickho123)
        • Like
      • 151 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...