Welcome to TRiBot Forums

Register now to gain access to all of our features. Once registered and logged in, you will be able to contribute to this site by submitting your own content or replying to existing content. You'll be able to customize your profile, receive reputation points as a reward for submitting content, while also communicating with other members via your own private inbox, plus much more! This message will be removed once you have signed in.

WillB

WillB Scripter application

WillB For scripter   7 members have voted

  1. 1. WillB For scripter


Please sign in or register to vote in this poll.

6 posts in this topic

WillB Scripter Application

 

Snippets:

Get Item Name Via ID: http://pastebin.com/Vvpaxwpu https://tribot.org/forums/topic/36901-snippet-get-item-name-via-id/ 

 

Tutorial: N/A

 

Randoms / Updates: N/A

 

Scripts:
           wbCrabKiller: 
https://tribot.org/forums/topic/37177-free-wbcrabkiller-east-crabs-only-banking-eating-now-added/

                 Main script: http://pastebin.com/neVV7wp8

                 GUI: http://pastebin.com/sgY8jiqe

                 User variables: http://pastebin.com/Aei8akDC

 

           wbSmelterAIO:  https://tribot.org/forums/topic/37419-freewbsmelteraio-aio-smelting-al-kharidport-phasmatyssmelting/

 

                 Main script: http://pastebin.com/gqNNjqzi

                 GUI: http://pastebin.com/K50Q45Up

                 User variables: http://pastebin.com/vvDnHgcy

 

           wbBlastFurnace:  https://tribot.org/forums/topic/38979-free-open-source-wbblastfurnace-steel-bars-only/

 

                 Main script: http://pastebin.com/geKGxmA2

 

Short biography / coding experience:

                 I have been programming on/off for a few years now, when I first started out I felt like I was copying and pasting more than I was actually programming my self, but have come extremely far from them. In the past year or so, I have mostly been into Game Development in the Unity Engine using C#. Recently I have mostly been programming in java for TRiBot and a few other small projects I have been working on.

 

Reasons why you feel you deserve Scripter:

                 I feel I deserve Scripter because I enjoy programming, and try to keep my Scripts update as much as possible.
I have tried my best to make sure that my scripts work as well as they can, although this can be hard with people not posting bug reports.

               

What you plan to provide the community with:

                 I plan to provide the community with plenty of free scripts, as well as any useful snippets I have and I may release some tutorials in the future. I will try my best to help people where I can.

 

Do you agree to continue to not only update, but provide more free, open sourced scripts to the community?

                 Yes.

 

@Starfox Okay thank you, would you say the crab script is the worst in general?

Edited by WillB

Share this post


Link to post
Share on other sites

Your code structure can be improved upon greatly. You aren't making the best use of the methods available in the TRiBot API. I like that you are using dynamic sleeps. The lack of ABC is a big downfall as that should be the heart and soul of your script and is a big part of keeping the TRiBot community ban free. Suggest to read over the TRiBot API docs, do some research on ABC and maybe try using a node framework may help clean your code up.

 

Starfox has a good reference for you to use for ABC: https://tribot.org/forums/topic/37431-easy-to-use-anti-ban-compliance-helper-class/

 

if you need someone for guidance add me on Skype or join the Teamspeak elitescripts.tk

 

You have a good attitude and I will be voting yes as I strongly believe you will improve you code and the scripter rank will give you some extra motivation.

Edited by peticca10
1 person likes this

Share this post


Link to post
Share on other sites

It's nice you're developing free scripts, however I don't think your code has demonstrated that you deserve the Scripter rank yet. 

 

Your overall code structure isn't very good, most of the code is inefficient and in some cases would break.

 

In addition you're not using the TRiBot API very well.

 

For example:

 

 
        private String getCrabClick(String crabName) {
 
                if (crabName != "Rock Crab") {
 
                        return "Walk here";
                } else {
 
                        return "Attack Rock Crab";
                }
        }
 
        private RSTile getCrabPos(RSNPC crab) {
                if (crab.getDefinition().getName() == "Rocks") {
 
                        return new RSTile(crab.getPosition().getX(), crab.getPosition()
                                        .getY() - General.random(-1, 1));
                } else {
 
                        return new RSTile(crab.getPosition().getX(), crab.getPosition()
                                        .getY());
                }
        }
 
        private RSArea getCrabArea() {
                if (UserVariables.eastCrabs == true) {
                        return this.eastCrabArea;
                } else {
                        return this.westCrabArea;
                }
        }
 
        private RSTile[] getCrabPath() {
                if (UserVariables.eastCrabs == true) {
                        return this.bankToEastCrabsPath;
                } else {
                        return this.bankToWestCrabsPath;
                }
        }
 
        private RSArea getPlayerArea() {
                if (bankArea.contains(Player.getPosition())) {
                        return bankArea;
                } else if (getCrabArea().contains(Player.getPosition())) {
                        return getCrabArea();
                }
                return null;
        }
 
        private void bank() {
 
                if (Banking.isBankScreenOpen()) {
                        if (Banking.find(UserVariables.foodID)[0].getStack() >= 3) {
                                Banking.depositAll();
                                sleep(General.random(200, 400));
                                Banking.withdraw(UserVariables.foodWithdrawAmmount,
                                                UserVariables.foodID);
                        } else {
                                Login.logout();
                        }
                } else {
                        Banking.openBank();
                }
        }
 
        private void eatFood() {
                RSItem[] food = Inventory.find(UserVariables.foodID);
 
                if (food != null && food.length > 0) {
                        food[0].click("Eat");
                }
        }
 
        private boolean needToEat() {
                return SKILLS.HITPOINTS.getCurrentLevel() <= SKILLS.HITPOINTS
                                .getActualLevel() / 2;
        }
 
        private boolean checkCombat() {
                RSNPC[] all = NPCs.getAll();
 
                for (RSNPC n : all) {
                        if (n.isInteractingWithMe() && n.isInCombat()) {
                                return true;
                        }
                }
                return false;
        }
Edited by Druid

Share this post


Link to post
Share on other sites

try working on your class structure. as I pointed out in a previous application, having methods such as you do (walkToBank(), walkToCrabs(), refreshCrabAgressiveness() etc.) all in the same class leads me to believe you don't have a good understanding of object oriented programming. i think your use of the tribot api is ok though. i think you should work on what the people above stated, and your structure of your scripts and apply again at a later time; i would like to see an improvement on this application.

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

  • Recently Browsing   0 members

    No registered users viewing this page.