Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Buy OSRS Gold

Sell OSRS Gold
Sign in to follow this  
Trees

[07] Quest Class

Recommended Posts

Array

Somethings about the code:

  1. Use General.sleep, not Thread.sleep
  2. Look into the correct Java naming conventions.
  3. Don't return "null". A String is an object, so you should just return null, not a string saying null. But shouldn't quest points be an integer?
  4. You can change return GetState(quest) == COMPLETED ? true : false;
    to return GetState(quest) == COMPLETED;
  5. The method getState also needs to return an int (if temp == null, it won't know what to do.) An IDE will tell you this.
  6. It also might be more efficient to look into enums/arrays for the quest name and ids.
     

With these additions, good work.

Edited by Worthy
  • Like 1

Share this post


Link to post
Share on other sites

Somethings about the code:

  • Use General.sleep, not Thread.sleep
  • Look into the correct Java naming conventions.
  • Don't return "null". A String is an object, so you should just return null, not a string saying null. But shouldn't quest points be an integer?
  • You can change return GetState(quest) == COMPLETED ? true : false;

    to return GetState(quest) == COMPLETED;

  • The method getState also needs to return an int (if temp == null, it won't know what to do.) An IDE will tell you this.
  • It also might be more efficient to look into enums/arrays for the quest name and ids.

With these additions, good work.

* Ok, I wasn't sure which sleep function to use.

* I was going to do all uppercase but forgot before I uploaded.

I will change the rest of the stuff, but eclipse didn't mention anything about not returning a value for int. I guess if you don't return anything it just returns -1. EDIT: My bad there was a stray bracket that caused it not to parse anything in the code.

Edited by Trees

Share this post


Link to post
Share on other sites

Interesting way of getting this information, although, surely there is a better way than doing this

 

b69edbcb92.png

 

You can loop through all of the children of the interface, see if the text is equal to name of the quest you are doing, and return what color that text happens to be. 

Share this post


Link to post
Share on other sites

Interesting way of getting this information, although, surely there is a better way than doing this

 

b69edbcb92.png

 

You can loop through all of the children of the interface, see if the text is equal to name of the quest you are doing, and return what color that text happens to be.

Would be better off mapping to a String and Integer.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this  

  • Similar Content

    • By ELON
      OVERVIEW:
      Completes The Mage Cape Quest FX Easy To Use Gui Paint Custom Equipment Support Custom Inventory Support (automatically recognizes if you have Prayer potions) Magic Prayer Support Custom Spell Support (Max Fire Bolt) Message Me if you want me to add the death rune spells  
      DESCRIPTION: 
      Travels to Edgeville if you are not at the mage bank deposits your equipment and inventory and withdraws a knife and then travels to the mage bank arena using the Edgeville wildly tele lever.
      If die by a pker it will run back to edgeville and tele up again and run to the mage bank.
      It does not support death at the mage arena when fighting the bosses currently you should very rarely die there if ever if using  prayer.
      Once at the mage bank arena it will withdraw your custom equipment and inventory and select the spell you have selected in the GUI and start the mage arena quest.
      After you have killed the bosses it will grab 3 capes and ends the script.
       
      SCRIPT LINK: https://tribot.org/repository/script/id/3602
    • By ELON
      Fully automated Nmz ready account builder with loads of customization 
       

       
      QUESTS SUPPORTED:
      Fight Arena Tree Gnome Village Witch House Lost City Vampire Slayer Rock Cake Fishing Contest Cook's Assistant Quests Animal magnetism  Ernest The Chicken Restless Ghost Priest In Peril Waterfall  
      SKILLS SUPPORTED:
      Slayer Range Mage Woodcutting Prayer Fishing Crafting FireMaking  
      EXTRA / ANTIBAN FEATURES:
      Dark Mode Modern FX Easy To Use GUI Mid Quest Support Custom Equipment Grand Exchange Support (Will Buy your Custom Equipment If Missing) Custom Combat style for Quest Bosses Automaticlly picks best Spell to Auto cast (Max Fire Bolt) Custom Break Handler (recommend) Sleek Paint Quests And Skills Are toggable  (Prayer Lvls Can not be turnt Off) Custom Eat and Drink Pray % Multiple ways to deal with chat Food used can be Changed (post me if you want  a certain food added) Shuffles Quest List Automaticlly Shuffles Banking Withdraw Order/Ge Buy Order Multiple Areas for Training skills Randomly Picks One Advanced Grand Exchange Api Advanced Banking Api ABC 2 Lvl 10 Automatically turns off your music and roofs ect..... And Much More  
      To complete all quests and skills on a fresh lvl 3 account 1.4 Mil minimum is recommend
       
      Get Script Here: https://tribot.org/repository/script/id/3598
       
       
       
       
       
    • By Virt
      My name is Case sensitive on discord Becareful of imposters - I NEVER TRADE VIA PMS EVER. 
      Unique ID: 460089618331860993
      or click here to join my discord and open a ticket:  https://discord.gg/b47uuQH  
       
      Why use VirtGold as your Service provider?
      in business since 2016
      over 250 Positive feedback from customers
      Over $1k in donations across various forums
      Everything is 100% hand trained and all work are monitored
      Provide sufficient updates frequently 
       












       
       


      Terms of services ~:
       
       
       
       
       





    • By Final Calibur
      Attention: The script has been retired. I'd like to thank everyone who supported FC scripts over the past couple of years! (See the last post for more details)
       
      FC Questing
       
      FC Questing is here for all to enjoy! This script is built on a framework which allows for easy chaining of quests, as well as new quests to be added with minimal effort. I will consistently add new quests to the script.
      Suicide Farm Edition:
      In addition to the full FC Questing script, I'm also offering a cheaper edition specifically for suicide farmers. The suicide farm edition will include the following:
      Tutorial Island Cook's Assistant Romeo & Juliet Sheep Shearer Pricing options are below.

      Features:
      Start anywhere Grand exchange support for quests that should utilize it Quest chaining Clean and detailed paint 15 quests supported and counting (GE indicates grand exchange support, GA indicates manual gathering support, SR indicates that the script will achieve skill requirements on it's own, QR indicates that the script will achieve quest point requirements on it's own)  Tutorial Island Doric's Quest GE GA Sheep Shearer GA Cook's Assistant GA Romeo & Juliet GA Rune Mysteries GA Imp Catcher GE Goblin Diplomacy GE Druidic Ritual GE Witch's Potion GE Prince Ali Rescue GE The Knight's Sword GE SR Ernest the Chicken GA The Restless Ghost GA Black Knight's Fortress GE QR Script Arguments:
      profile_name Simply type in the name of a previously saved profile, and it will be used! 7qp Romeo & Juliet Sheep Shearer Cook's Assistant all All supported quests, random order tut-ge Tutorial island Walks to GE after tutorial island tut Tutorial island Account Queue:
      FC Questing supports an account queue, meaning you can run many accounts through the script with ease. Simply create a file in the directory which is opened by the "load accts" button, and format it like so:
      username:password
      Each account must be on it's own line. The accounts will all be ran with the same settings that you have selected. If a banned / locked / invalid account is provided, it will skip over it.
      GE Support / Gathering:
      The script currently features Grand Exchange support for quests that should utilize it. Also, the script supports gathering items manually as well. Check the quest list above to see what each quest supports. Here are some things you should know:
      If supported, the script will attempt to purchase items from the GE first before gathering manually If the player doesn't have enough gold for all of the items, it will then resort to manually gathering the rest of the materials (if gathering is supported for the quest) The script will attempt to purchase items < 2,000 GP for double their market price, to try and avoid waiting. >= 2000 GP will be bought at 1.3 times their market price (this can be changed if you have suggestions) If the quest does not support manual gathering, and the GE process fails, the script will end The script will abort & resubmit any offers that don't sell instantly, for 15% higher (if the character has enough gp to do so). This helps avoid waiting around for items to sell. General Notes:
      As this is a quest script, there are a lot of moving parts. This almost ensures that bugs will pop up now and then. Please report them when they arise, provide a detailed description, and I will fix it as fast as possible.
      The script generally should be able to start in the middle of a quest, however please be aware that this may result in questionable script behavior and / or the quest not completing properly.
      Bug Reports / Suggestions / Questions:
      Please see the thread here on how to report an issue or suggestion. Direct posts on the thread or private messages will be redirected to here.
      Please join my discord channel here for other miscellaneous inquiries. This is the fastest way to contact me.
      Pricing for FC Questing (FULL):
      1 hour free trial (resets on the first of every month) $3.99 per month, 10 instances (great for the casual user) $9.99 per month, 30 instances (great for the large bot farmer) $14.99 per 6 months ($2.50 per month), 10 instances (great for the long term user) $39.99 per 6 months ($6.67 per month), 30 instances (great for the long term large bot farmer) Pricing for FC Questing Lite (TUTORIAL + 7QP):
      1 hour free trial (resets on the first of every month) $0.99 per month, 10 instances $2.49 per 3 months ($.83 cents per month), 10 instances $3.99 per 6 months ($.67 per month), 10 instances $9.99 per 6 months ($1.67 per month), 30 instances  
      Images:
       


      Time Lapse:
       
       
       
       
    • By Worthy
      |w| Quests
      By Worthy
      ·
      Features
      Gathers all auxiliary items for you Quick and easy to use GUI setup Sexy mouse paint Multi-threaded system for food support and combat defence Screenshots completed quests!
      All completed quests are put in your .tribot folder /Worthy Quests/Screenshots
      Flawless deathwalking ABCL AntiBan Intelligent World Hopping resource finder Chain Questing - see documentation on bottom of page ·
      Steps
      Enable Lite Mode. File > Settings Click the View stats and items button and make sure you have all the items specified in your inventory unless further specified. Turn off auto-retaliate. Input your accout details into the TRiBot Bot Manager Select a quest and, unless restarting it from a bug, leave the checkpoint on the default setting. Block user input when done. [NOTE] Detailed information on what the bot is doing can be found under the bot debug window: ·
       
      Easy 7 Minute Account Trade Setup
       

      Supported Quests
      Waterfall Quest Rune Mysteries Doric's Quest Monk's Friend Cook's Assistant Prince Ali Rescue Death Plateau Tree Gnome Village Dwarf Cannon The green quests are the most bug-free and tested. They work well almost every single time and can be relied upon without baby-sitting. Bugs in them are fixed with priority.
      The yellow quests should be baby-sat and may be buggy if using LG, or in general. Bugs here are fixed eventually. Do not buy the script if you plan on using the yellow quests only.
      The reason being, I plan on rewriting this questing script, from the ground up. This is one of the first scripts I wrote for TRiBot and I have not gotten around to rewriting yet with my learned experience and knowledge over the years. Supporting old code is time consuming and I would like to spend those efforts writing new code that is more reliable in the future  
       
      ·
      How to submit and bug report
      BUG REPORT 1) Name of quest: 2) Picture of screen (rs window (show inventory): I recommend gyazo/shareX 3) Detailed description of bug: 4) Bot Debug: Right click the tab and press copy to clipboard. I recommend to upload to www.pastebin.com 5) Client Debug: Example:
       

      ·
      In the Repository!
      --> Two Authorizations [monthly] (Player edition)
      --> Unlimited [lifetime] (Farming edition)

      ·
      Video Proggies
      ·
       
      ·
      Completed Quest Proggies:
      More proggies: http://imgur.com/a/wIHOS
      · ·
       
      Script Documentation and How-To:


      Enjoy!

    • By rewie
      - Completes Witch's potion quest
      - No GUI so can be used with script queue/client starter
      - Start at any point in the quest
      - Uses WebWalker so you can start from anywhere it supports
      - Let me know if there is any bugs/improvements
      - Gathers all the required items (see more in the spoiler)
      Change log:
      TO DO:
       
       
      Get it here
       
       
    • By saulszinc
      Discord server: https://discord.gg/ybURa9S    - Use Code Tribot for 10% off your first order
      I do not use Skype.
      Feel free to send requests for anything you don't see listed & I shall get back to you with a quote for the said service
    • By killerjanne
      Hello!

      I'm releasing my Witch's House quest script. It's not fully tested yet but works great for me as it is now.
      Please make sure to babysit while running.
      And please write here if you get any errors 

      It safespot after two first monsters and all my testing has been at level 3 accounts.
      Req: none;
      Items needed:
      3 Cheese
      1 Leather gloves
      1 Staff of air
      500 Mind runes
      18 Trout
      You can start the quest everywhere Dax walker function.
      I recommend starting at Falador either with the items in bank or all of them in your inventory.

      Click here to try it now! :)
      Thanks to:
      Dax for his Webwalker and all the people helping me at tribots discord.
      EasyAsPie for helping me with packaging errors
    • By Ibomeister
      I have discord now!
      Fabrii#0516
       
      Workers
      @Rx7xr Is currently working for me with a deposit. (on osbot)

      Profile link on osbot 
      https://osbot.org/forum/profile/281558-ibomeister/

      Order form
      What do you need? :
      Payment method? :
      Going first or middleman? :
      What is your Skype? :
      Do you agree to the TOS? :
    • By Savage Squad
      Howdy everyone, I am fairly new to the forums and my hobby in my free time is to quest. I have been playing Runescape for over 7 years now and questing has always been my thing; I know all quests by memory already and would like to help the community with my services.
       
      Application
      Combat Level:
      Quests:
       
      Contact

       
      Vouches
  • Our picks

    • Over the past few months, I’ve been working diligently on a new project - TRiBot X. Everything has been written from the ground up, with all of the best practices of software engineering. Every aspect of TRiBot has been re-imagined to support three main goals: flexibility, useability, and reliability.
        • Like
      • 50 replies
    • Come give us feedback on the next version of TRiBot!
        • Thanks
        • Like
      • 86 replies
    • TRiBot is looking to improve a lot of its customer relationship management, customer on boarding process, customer experience, design elements, community engagement and pretty much everything else you can imagine when it comes to marketing.

      Our goal: To ensure that the marketing done TRULY reflects the experience and does not shine an inaccurate light on what TRiBot is lacking in.

      So I ask, what do you love about TRiBot and what do you hate about TRiBot? What does O S Bot, Rune M8, PowR Bot and Dre amBot do better? (yes I purposely didn't spell it right 😂).

      Love, 

      RileyZ
        • Like
      • 25 replies
    • Over the last three weeks, I've been working on upgrading our server infrastructure. It's finally ready and is now live!

      Why?

      Increased reliability - less server errors


      Increased availability - less downtime


      Increased security - keeping us and you secure


      Increased capacity - ability to serve you better


      Increased speed - less waiting for things to load


      Faster development - server and service updates will come faster


      What are the changes?

      Move from a single AWS EC2 instance to AWS ECS (Elastic Container Service)


      Distributed computing


      Load balancing


      Git management of server files and filesystem


      Redis caching


      How?

      AWS ECS (with 10 EC2 instances)


      AWS ElastiCache (Redis)


      AWS Load Balancing


      AWS EFS (Elastic file system)


      Please bare with us as I continue to tune the server for maximum performance. Slow loading speeds may occur temporarily. I thank everyone for their patience.

      Please post on this thread if you experience any issues other than slow loading times.
        • Like
      • 51 replies
    • This release will:

      Fix prayers and world hopper API (Thanks @JoeDezzy1 and @erickho123)


      Improve banking API (Thanks @Encoded)


      Adds methods for returning and using Java Lists, rather than arrays


      Slightly randomizes some hardcoded behaviour


      Removes sleeps from waitConditions; the efficiency saving potential is negligible in these use-cases, therefore cleaner code is preferable


      Other back-end improvements





      Note: If you are using LG, please restart both the RS client and TRiBot.
        • Sad
        • Haha
        • Thanks
        • Like
      • 90 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...