Jump to content
Sign in to follow this  
TRiLeZ

TRiBot Beta 7.43_0

Recommended Posts

Hey Trilez, thanks for fixing the Banking API so fast.

 

Banking.DepositAll() could just click the [Deposit All] button now, instead of looping through the inventory items array, right clicking each item, and clicking deposit all. (Not only more efficient, but if everyone in rs is using the Deposit All button, and the bots still deposit all the old one, might look suspicious).

 

I also recommend adding Banking.DepositAllEquipped() // clicks the [Deposit All Equipped Items] on the bank screen.

 

Also, 3 bank rows (24 bank slots) were added to the bank. Which means the scroll bar height has changed, meaning bank scrolling (in the Banking API) could be off. So if an item is not on the top screen of the bank, the withdraw function may fail, since the scrollbars have changed (ratios, height, etc). My suggestion is this:

 

Inside of withdraw(), if the item is not on the first bank page, it clicks [search] button, it types in the item name, then this makes the item show at the top of the bank, then withdraw can run as normal. This is an easy-fix, but also a much more accurate method for withdrawing items that are not on the first bank page (even with the old bank, it often failed, which is why script writers would always say that you must put items at the top of your bank)

 

Also if someone does Banking.DepositAllExcept(x) and let's say X is a "Knife" (fletching script), then it might be better for it to click the [Deposit All] button, then to left click to withdraw the Knife back into the inventory. Much quicker, and more human-like. (This behaviour on DepositAllExcept would only occur if 1 item is passed as the argument, and there is only 1 of this item in the inventory).

Share this post


Link to post
Share on other sites

Banking.DepositAll() could just click the [Deposit All] button now, instead of looping through the inventory items array, right clicking each item, and clicking deposit all. (Not only more efficient, but if everyone in rs is using the Deposit All button, and the bots still deposit all the old one, might look suspicious).

Banking.depositAll() was changed with this update to use the button. :)

 

I also recommend adding Banking.DepositAllEquipped() // clicks the [Deposit All Equipped Items] on the bank screen.

Banking.depositEquipment() was also added, just not in the java docs yet.

Also, 3 bank rows (24 bank slots) were added to the bank. Which means the scroll bar height has changed, meaning bank scrolling (in the Banking API) could be off. So if an item is not on the top screen of the bank, the withdraw function may fail, since the scrollbars have changed (ratios, height, etc). My suggestion is this:

 

Inside of withdraw(), if the item is not on the first bank page, it clicks [search] button, it types in the item name, then this makes the item show at the top of the bank, then withdraw can run as normal. This is an easy-fix, but also a much more accurate method for withdrawing items that are not on the first bank page (even with the old bank, it often failed, which is why script writers would always say that you must put items at the top of your bank)

Typing takes too long. I'll just change the scroll position calculation.

Also if someone does Banking.DepositAllExcept(x) and let's say X is a "Knife" (fletching script), then it might be better for it to click the [Deposit All] button, then to left click to withdraw the Knife back into the inventory. Much quicker, and more human-like. (This behaviour on DepositAllExcept would only occur if 1 item is passed as the argument, and there is only 1 of this item in the inventory).

I don't really want the API having too much logic for a method like this. It should be up to the script to have that logic. The API is just a framework that should do exactly what it is told.

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.
Sign in to follow this  

  • Our picks

    • This release will:

      Fix key event handling issue


      Fix other event handling issue


      Fix RSServer hook


      Update world hopper to have it use OCR, thanks to Todd


      Use proper disposal of old Graphics objects


      Reformat code


      Rearrange code


      Organize code imports


      Apply around 8000 automated code refactorings


      Make preparations for Java 9


      Fix 11 various bugs


      Add more reliable debugging support


      Fix mouseEntered/Exited event dispatching bug


      Fix minimap walking bug where it opens the map


      Fix broken hooks for today's game update
        • Thanks
        • Like
      • 86 replies
    • This update will:

      Fix GE inventory item positioning bug


      Fix broken object hooks
        • Like
      • 27 replies
    • This release will:

      Fix some ClosedChannelException bug


      Fix bug in RSObject#getAllTiles


      Add game tab support for "Kourend Favour"
        • Like
      • 15 replies
    • This release will:

      Fix Settings UI placement bug


      Fix game object location bug


      Fix small layout bug making the client shift up and down


      Fix client crashing bug where loading the client with a small display area will cause the client to crash


      Fix annoying Linux bug relating to painting events and peers


      Fix settings saving bug where settings are saved to disk more often than they should


      Fix RSInterface#isBeingDrawn bug affecting a limited amount of people


      Drop Java 1.7 bytecode version for 1.8


      Important: Since the downloadable RS client uses Java 7, it will no longer be compatible with Looking Glass. To make up for this, we will add support for using other clients such as RuneLite (at a later date).


      This change was necessary to allow us to use Java 8 syntax. It also paves the way for Java 9/10/11 support.
        • Like
      • 40 replies
    • This update will:

      Fix the RSMenuNode bug which also fixes the bug with bank opening


      Fix the incorrect object positions bug


      Fix and re-enable the LG Objects API Accelerator


      Fix the RSObject#getAllTiles bug
        • Like
      • 22 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×