Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

flamekiller999

Registered
  • Content Count

    269
  • Joined

  • Last visited

  • Days Won

    5
  • Feedback

    100%

Everything posted by flamekiller999

  1. Exactly what the others have said. The code should be something like this, if (itemsOnGround[0].click("Take " + itemsOnGround[0].getDefinition().getID())) { // or if you change it from ID to the name of the item, change the "getID()" //to "getName()"
  2. Agreed, part of my plan for this it to increase its efficiency and also increase it's functionality in the coming weeks. (I'm having to fit it in around my thesis and work at the moment)
  3. Oh good point! Yeah that was stupid of me! Thanks for pointing that out. I will add more check into to make sure that interface is open and null checked Thanks for pointing that out
  4. https://github.com/FlameK/src/blob/master/api/fairyRingHandler/fairyRingHandler.java Thanks for the suggestion! Feel free to make and contributions you would like! I will also be looking to optimise this over the coming weeks
  5. Thank you for the feedback, its always really appreciated! I agree that the interface needs to be open. The first part of this will always be to call the following part to make sure the interface is open. public boolean fairyRingInterfaceIsOpen(){ return Interfaces.get(398) != null; } But I agree with you on the enum front, I will be looking to optimise it more to make this easier to use in the future. I also am looking at building upon this to add the saved searches so that interaction with the dials doesn't even need to be used.
  6. Oh damn, some money moves there for LG
  7. Yeah funnily enough I though about that as I was finishing this up. Then it would make it nicer to print the location into the Debug too. That's definitely one of my ideas for developing this into the future and cleaning up the code. Also congratulations on Scripter rank!
  8. The aim of this class is increase the ease of interacting with Fairy rings. I created it while making a script earlier today. This class allows you to firstly check if the fairy ring interface is open, then select each letter of the fairy ring, and finally it allows the conformation of the teleport location. Admittedly I could have simplified it slightly, however, this works perfectly fine for me. Hope some others find it helpful! An example of how it can be used is as follows: if (FairyRingHelper.get().fairyRingInterfaceIsOpen()) { FairyRingHelper.get().setFirstFairyRingLetterB(); FairyRingHelper.get().setSecondFairyRingLetterK(); FairyRingHelper.get().setThirdFairyRingLetterR(); FairyRingHelper.get().confirmFairyRingTeleport(); } fairyRingHelper.java class: package scripts.fairyRingHelper; import org.tribot.api.General; import org.tribot.api.Timing; import org.tribot.api2007.Interfaces; import org.tribot.api2007.Player; import org.tribot.api2007.types.RSInterface; import org.tribot.api2007.types.RSInterfaceChild; import org.tribot.api2007.types.RSVarBit; public class FairyRingHelper { // Created by Elliott 12/02/2020 private FairyRingHelper() {} private static FairyRingHelper fairyRingHelper = new FairyRingHelper(); public static FairyRingHelper get() { return fairyRingHelper; } public RSInterface fairyRingInterfaceIsValid() { return Interfaces.get(398); } public RSInterfaceChild firstFairyRingLetterClockwise() { return Interfaces.get(398, 19); } public RSInterfaceChild firstFairyRingLetterAntiClockwise() { return Interfaces.get(398, 20); } public RSInterfaceChild secondFairyRingLetterClockwise() { return Interfaces.get(398, 21); } public RSInterfaceChild secondFairyRingLetterAntiClockwise() { return Interfaces.get(398, 22); } public RSInterfaceChild thirdFairyRingLetterClockwise() { return Interfaces.get(398, 23); } public RSInterfaceChild thirdFairyRingLetterAntiClockwise() { return Interfaces.get(398, 24); } public RSInterfaceChild confirmFairyRingTeleportButton() { return Interfaces.get(398, 26); } public RSVarBit firstFairyRingLetterVarbit = RSVarBit.get(3985); // 0 = a 1 = d 2 = c 3 = b public RSVarBit secondFairyRingLetterVarbit = RSVarBit.get(3986); // 0 = i 1 = l 2 = k 3 = j public RSVarBit thirdFairyRingLetterVarbit = RSVarBit.get(3987); // 0 = p 1 = s 2 = r 3 = q /** Call this to check that the fairy ring interface is open before selecting letters. **/ public boolean fairyRingInterfaceIsOpen(){ return Interfaces.get(398) != null; } /** sets the first fairy ring letter to A **/ public boolean setFirstFairyRingLetterA() { if (firstFairyRingLetterVarbit.getValue() != 0) { if (firstFairyRingLetterVarbit.getValue() == 1) { final RSInterfaceChild firstFairyRingLetterClockwise = firstFairyRingLetterClockwise(); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (firstFairyRingLetterVarbit.getValue() == 2) { final RSInterfaceChild firstFairyRingLetterClockwise = firstFairyRingLetterClockwise(); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (firstFairyRingLetterVarbit.getValue() == 3) { final RSInterfaceChild firstFairyRingLetterAntiClockwise = firstFairyRingLetterAntiClockwise(); firstFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: First letter 'A' is set"); return firstFairyRingLetterVarbit.getValue() == 0; } /** sets the first fairy ring letter to D **/ public boolean setFirstFairyRingLetterD() { if (firstFairyRingLetterVarbit.getValue() != 1) { if (firstFairyRingLetterVarbit.getValue() == 0) { final RSInterfaceChild firstFairyRingLetterClockwise = firstFairyRingLetterClockwise(); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (firstFairyRingLetterVarbit.getValue() == 3) { final RSInterfaceChild firstFairyRingLetterClockwise = firstFairyRingLetterClockwise(); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (firstFairyRingLetterVarbit.getValue() == 2 ) { final RSInterfaceChild firstFairyRingLetterAntiClockwise = firstFairyRingLetterAntiClockwise(); firstFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: First letter 'D' is set"); return firstFairyRingLetterVarbit.getValue() == 1; } /** sets the first fairy ring letter to C **/ public boolean setFirstFairyRingLetterC() { if (firstFairyRingLetterVarbit.getValue() != 2) { if (firstFairyRingLetterVarbit.getValue() == 0) { final RSInterfaceChild firstFairyRingLetterClockwise = firstFairyRingLetterClockwise(); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (firstFairyRingLetterVarbit.getValue() == 1) { final RSInterfaceChild firstFairyRingLetterClockwise = firstFairyRingLetterClockwise(); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (firstFairyRingLetterVarbit.getValue() == 3 ) { final RSInterfaceChild firstFairyRingLetterAntiClockwise = firstFairyRingLetterAntiClockwise(); firstFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: First letter 'C' is set"); return firstFairyRingLetterVarbit.getValue() == 2; } /** sets the first fairy ring letter to B **/ public boolean setFirstFairyRingLetterB() { if (firstFairyRingLetterVarbit.getValue() != 3) { if (firstFairyRingLetterVarbit.getValue() == 1) { final RSInterfaceChild firstFairyRingLetterClockwise = firstFairyRingLetterClockwise(); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (firstFairyRingLetterVarbit.getValue() == 2) { final RSInterfaceChild firstFairyRingLetterClockwise = firstFairyRingLetterClockwise(); firstFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (firstFairyRingLetterVarbit.getValue() == 0 ) { final RSInterfaceChild firstFairyRingLetterAntiClockwise = firstFairyRingLetterAntiClockwise(); firstFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: First letter 'B' is set"); return firstFairyRingLetterVarbit.getValue() == 3; } /** sets the second fairy ring letter to I **/ public boolean setSecondFairyRingLetterI() { if (secondFairyRingLetterVarbit.getValue() != 0) { if (secondFairyRingLetterVarbit.getValue() == 1) { final RSInterfaceChild secondFairyRingLetterClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (secondFairyRingLetterVarbit.getValue() == 2) { final RSInterfaceChild secondFairyRingLetterClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (secondFairyRingLetterVarbit.getValue() == 3) { final RSInterfaceChild secondFairyRingLetterAntiClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: Second letter 'I' is set"); return secondFairyRingLetterVarbit.getValue() == 0; } /** sets the second fairy ring letter to L **/ public boolean setSecondFairyRingLetterL() { if (secondFairyRingLetterVarbit.getValue() != 1) { if (secondFairyRingLetterVarbit.getValue() == 0) { final RSInterfaceChild secondFairyRingLetterClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (secondFairyRingLetterVarbit.getValue() == 3) { final RSInterfaceChild secondFairyRingLetterClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (secondFairyRingLetterVarbit.getValue() == 2) { final RSInterfaceChild secondFairyRingLetterAntiClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: Second letter 'L' is set"); return secondFairyRingLetterVarbit.getValue() == 1; } /** sets the second fairy ring letter to K **/ public boolean setSecondFairyRingLetterK() { if (secondFairyRingLetterVarbit.getValue() != 2) { if (secondFairyRingLetterVarbit.getValue() == 1) { final RSInterfaceChild secondFairyRingLetterClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (secondFairyRingLetterVarbit.getValue() == 0) { final RSInterfaceChild secondFairyRingLetterClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (secondFairyRingLetterVarbit.getValue() == 3) { final RSInterfaceChild secondFairyRingLetterAntiClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: Second letter 'K' is set"); return secondFairyRingLetterVarbit.getValue() == 2; } /** sets the second fairy ring letter to J **/ public boolean setSecondFairyRingLetterJ() { if (secondFairyRingLetterVarbit.getValue() != 3) { if (secondFairyRingLetterVarbit.getValue() == 2) { final RSInterfaceChild secondFairyRingLetterClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (secondFairyRingLetterVarbit.getValue() == 1) { final RSInterfaceChild secondFairyRingLetterClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); secondFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (secondFairyRingLetterVarbit.getValue() == 0) { final RSInterfaceChild secondFairyRingLetterAntiClockwise = firstFairyRingLetterClockwise(); secondFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: Second letter 'J' is set"); return secondFairyRingLetterVarbit.getValue() == 3; } /** sets the second fairy ring letter to P **/ public boolean setThirdFairyRingLetterP() { if (thirdFairyRingLetterVarbit.getValue() != 0) { if (thirdFairyRingLetterVarbit.getValue() == 1) { final RSInterfaceChild thirdFairyRingLetterClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (thirdFairyRingLetterVarbit.getValue() == 2) { final RSInterfaceChild thirdFairyRingLetterClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (thirdFairyRingLetterVarbit.getValue() == 3) { final RSInterfaceChild thirdFairyRingLetterAntiClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: Third letter 'P' is set"); return thirdFairyRingLetterVarbit.getValue() == 0; } /** sets the second fairy ring letter to S **/ public boolean setThirdFairyRingLetterS() { if (thirdFairyRingLetterVarbit.getValue() != 1) { if (thirdFairyRingLetterVarbit.getValue() == 0) { final RSInterfaceChild thirdFairyRingLetterClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (thirdFairyRingLetterVarbit.getValue() == 3) { final RSInterfaceChild thirdFairyRingLetterClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (thirdFairyRingLetterVarbit.getValue() == 2) { final RSInterfaceChild thirdFairyRingLetterAntiClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: Third letter 'S' is set"); return thirdFairyRingLetterVarbit.getValue() == 1; } /** sets the second fairy ring letter to R **/ public boolean setThirdFairyRingLetterR() { if (thirdFairyRingLetterVarbit.getValue() != 2) { if (thirdFairyRingLetterVarbit.getValue() == 1) { final RSInterfaceChild thirdFairyRingLetterClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (thirdFairyRingLetterVarbit.getValue() == 0) { final RSInterfaceChild thirdFairyRingLetterClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (thirdFairyRingLetterVarbit.getValue() == 3) { final RSInterfaceChild thirdFairyRingLetterAntiClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: Third letter 'R' is set"); return thirdFairyRingLetterVarbit.getValue() == 2; } /** sets the second fairy ring letter to Q **/ public boolean setThirdFairyRingLetterQ() { if (thirdFairyRingLetterVarbit.getValue() != 3) { if (thirdFairyRingLetterVarbit.getValue() == 2) { final RSInterfaceChild thirdFairyRingLetterClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } if (thirdFairyRingLetterVarbit.getValue() == 1) { final RSInterfaceChild thirdFairyRingLetterClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); thirdFairyRingLetterClockwise.click(); General.sleep(General.randomSD(750, 75)); } else if (thirdFairyRingLetterVarbit.getValue() == 0) { final RSInterfaceChild thirdFairyRingLetterAntiClockwise = firstFairyRingLetterClockwise(); thirdFairyRingLetterAntiClockwise.click(); General.sleep(General.randomSD(750, 75)); } } General.println("[FAIRY RING NAVIGATION]: Third letter 'Q' is set"); return thirdFairyRingLetterVarbit.getValue() == 3; } /** confirms fairy rings and initiates the teleport **/ public boolean confirmFairyRingTeleport() { if (fairyRingInterfaceIsOpen()) { final RSInterfaceChild confirmFairyRingTeleport = confirmFairyRingTeleportButton(); confirmFairyRingTeleport.click(); General.sleep(General.randomSD(2000, 75)); General.println("[FAIRY RING NAVIGATION]: Confirming fairy ring location."); Timing.waitCondition(() -> { while (Player.getAnimation() == 3265 || Player.getAnimation() == 3266) { General.println("[FAIRY RING NAVIGATION]: Player is interacting with fairy rings, sleeping until finished."); General.sleep(General.randomSD(1700, 100)); } return Player.getAnimation() == -1; }, General.randomSD(1500, 100)); } return !fairyRingInterfaceIsOpen(); } }
  9. Yeah that doesn't need to be there anymore. I got rid of the first part as its now redundant
  10. Yeah I agree with you there, having all the variables in one class would make it a lot cleaner for sure. I will clean that all up a bit more so that it is easier to understand. And being critical is more helpful than anything else imo so don't worry at all about that. I've been slowly learning Java mainly from other scripts on here and Youtube so I know sometimes what I'm doing isn't the best. But will look at your script to get an idea of your structure etc
  11. Yes I always seem to have the issue of not using the upperCamelCase all the time. I know it's meant to be used but i still do not use it properly it would seem. Thanks for the suggestions! Yeah I agree the priority method is slightly invalid here. It's just the structure that I have become used to while writing other scripts so it was easy for me to use it to structure this script. And I will look into the enum you've mentioned to rewrite that. Thank you for the feedback though! It's always really helpful for me
  12. Thanks guys! Any advice you can give me on how to improve is always appreciated
  13. This is my first official script that I will have released on Tribot and I am making it open source to get feedback on my code and suggested improvements. This is a basic script that will make Mud runes, I have got around 1200 runes per hour which when testing was over 350k GP/hr. The script also implements ABC2 and can be found at the following link. https://tribot.org/repository/script/id/3420 Skill Requirement: 14 Runecrafting Start in Varrock East Bank with the following items (in brackets are the estimated amount of the item used per hour): Water rune (1500) Water talisman (60) Binding necklace (4) Stamina potion (7.5) Varrock teleport (60) Pure essence (1500) I recommend having your bank and inventory set up something similar to this to increase efficiency: Additionally, have the bank withdraw option set to 25. I'm open to any suggestions/improvements to the script and also suggestions for future scripts. Link to Source: https://github.com/FlameK/src/tree/master/Scripts/MudRuneMaker
  14. @testing1 For Mac, to properly uninstall Java you use these commands in the terminal (don't know if you want to add it to your original post) One by one, execute each of the following commands individually: sudo rm -rf "/Library/Internet Plug-Ins/JavaAppletPlugin.plugin" sudo rm -rf "/Library/PreferencePanes/JavaControlPanel.prefPane" sudo rm -rf "~/Library/Application Support/Java" A good link as well with detailed instructions for a non terminal approach can be found by following this link. http://osxdaily.com/2017/06/16/uninstall-java-mac/
  15. As always, looks like another amazing addition
  16. Great to see some new scripts coming out! You may like to make these open source so that Premium Scripters can give some feedback / others can learn from your code.
  17. I know Texan made a script for this which works for Lava runes (got me a fair few levels on it!). @adamhackz would you be looking at doing lavas I'm guessing? Because the big issue which was encountered last time is multiple bots interacting with each other in order to determine which needs to bring a binding necklace for the host. If you need a solution for that I can help out there haha
  18. Botting F2P is notoriously high ban rates to the point where it is almost not worth it imo. If they're using the same script/method that could be why as they may be monitoring it more closely
  19. Personally I have an account which had a 2 day ban. It is still going, although I barely bot on it anymore. If you are going to only do short time periods, play legit, dont bot goldfarming methods, and quest on the account. Personally I find human mouse data makes a big difference in ban rates, but I also have heard people say it makes no difference to them. I have also used the blastmine script for a short period with no issues on the account with a 2 day ban.
  20. Disabled is very different from a ban. If you are using a proxy then there is a good chance your account will get locked. It is easy to unlock an account tho, just use this tutorial Now being banned is a different thing. What are you botting? F2P or P2P? Is the method very common and what are the customisation settings like on the script your using (or what is the script your using?)
  21. How long do you bot per time, VIP-E I also find is helpful for the human mouse data as I've personally noticed a difference in ban rates (lower when using it). Also if you are botting your main LG is a good feature to lower your chance of a ban further.
  22. There is an House sitter script on Tribot for free which I used for my host. Never got it banned using it and it was easy
  23. This is amazing! Been wanting something like this on TB for ages! Great work, if it’s still available to test hmu and I can potentially propose suggestions and improvements!
  24. flamekiller999

    [R] Fungus

    You'd be better off messaging @godspower33 directly, posting on the thread for the script directly or joining the TriBot discord and talking to him on there.
×
×
  • Create New...